Do not notify for events marked as not attending

[David Planella]

This is a follow-up from bug #1371871. While it was marked as Fix Released, it doesn't seem to have had any effect. I'm reporting it as two separate bugs to reopen it now.

I've got a few events in my calendar for meetings where I'm marked as not going, which I still want to see in my calendar unless I explicitly delete them.

An example is a recurring event which I've got on my work calendar. During my holiday:
- I'll mark myself as not attending
- I will not delete the event
- I don't expect to be notified

As I'm not marked as attending, I wouldn't expect to get a reminder notification, even less if I'm in a different timezone and it's 3:00 a.m. :)

See bug 1508440 for the "display events not being attended clearly" part.

[Kunal Parmar (pkunal-parmar)]

I think best place to resolve this issue is notification system, then can check status before firing the notification and act accordingly.

[David Planella (dpm)]

Thanks Kunal. Could you expand on the comment? Do you mean it is something that cannot be fixed in Calendar?

[Kunal Parmar (pkunal-parmar)]

Hi David, Yes, I dont think we can support this requirement from Calendar side. We can partially handle this from calendar for events generated from calendar app, but for sync events we dont have any control. So I think best place to address this bug is notification system.

[David Planella (dpm)]

Thanks Kunal. Going into more detail, could you help us understand:

- How exactly can this be (partially) handled by Calendar for events
generated from within the app?
- Why isn't there any control over sync'd events? Is there a field that we
need to track that it's missing?
- By notification system, do you mean EDS? Or the Alarms API?

On Tue, Dec 8, 2015 at 7:17 PM, Kunal Parmar <email address hidden>
wrote:

> Hi David, Yes, I dont think we can support this requirement from
> Calendar side. We can partially handle this from calendar for events
> generated from calendar app, but for sync events we dont have any
> control. So I think best place to address this bug is notification
> system.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1508438
>
> Title:
> Do not notify for events marked as not attending
>
> Status in Ubuntu Calendar App:
> Triaged
>
> Bug description:
> This is a follow-up from bug #1371871. While it was marked as Fix
> Released, it doesn't seem to have had any effect. I'm reporting it as
> two separate bugs to reopen it now.
>
> I've got a few events in my calendar for meetings where I'm marked as
> not going, which I still want to see in my calendar unless I
> explicitly delete them.
>
> An example is a recurring event which I've got on my work calendar.
> During my holiday:
> - I'll mark myself as not attending
> - I will not delete the event
> - I don't expect to be notified
>
> As I'm not marked as attending, I wouldn't expect to get a reminder
> notification, even less if I'm in a different timezone and it's 3:00
> a.m. :)
>
> See bug 1508440 for the "display events not being attended clearly"
> part.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1508438/+subscriptions
>

[Kunal Parmar (pkunal-parmar)]

Hi David,
Please find details as below,

- How exactly can this be (partially) handled by Calendar for events generated from within the app?
KP: If events are generated from calendar app, then we can remove Alarm value from event and then event will not fire notification. This can not be done for event from google, as we can not scan all events and remove the Alarm value.

- Why isn't there any control over sync'd events? Is there a field that we need to track that it's missing?
KP: It can be done, but its not appropriate for calendar all to scan all event and modify event to modify event so that notification is not triggered for certain event

- By notification system, do you mean EDS? Or the Alarms API?
KP: Not EDS but component which handles notification, I forgot the exact component

[Renato Araujo Oliveira Filho (renatofilho)]

this need to be implemented in the indicator.

[Charles Kerr (charlesk)]

The thing to do here is to get some sample input from an imported calendar with "not attending" set so that (a) this ical can be used as the basis for a regression test and (b) we can see how to test for this state in engine-eds.cc.

Once we have that test in place the rest of implementation is trivial, just don't call add_alarms_to_subtask() for components that have "not attending" set.