Ubuntu
indicator-datetime package

calendar icon wrong colour (compared to clock) for upcoming appointments

Bug #1307048 reported by Alan Pope 🍺🐧🐱 🦄
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
indicator-datetime (Ubuntu)
Invalid
Undecided
Charles Kerr
unity8 (Ubuntu)
Fix Released
Medium
Nick Dedekind

Bug Description

Have appointments sync via calendar, note that pulling down indicator reveals icon which is black-on-grey whereas clock items appear white-on-grey.
Calendar icons are hard to see compared to clock items. See photo.

Related branches

lp:~nick-dedekind/unity8/lp1307048-appointment-colour
Andrea Cimitan (community): Approve
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Diff: 102 lines (+30/-5)
2 files modified
plugins/Unity/Indicators/qml/MenuItemFactory.qml (+1/-1)
tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml (+29/-4)
lp:ubuntu/utopic-proposed/unity8
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :
Revision history for this message
Charles Kerr (charlesk) wrote :

Hm, interesting. Alan, thanks for the photo.

The calendar with the correct color is being created in indicator-datetime-service's src/menu.cpp by a call to g_themed_icon_new_with_default_fallbacks("calendar").

The black-on-grey calendar is coming from unity8's plugins/Unity/Indicators/qml/MenuItemFactory.qml's appointmentMenu definition, which uses "image://theme/calendar".

If indicator-datetime-service needs to send the same icon over in both instances that's an easy enough fix; however, I wonder why image://theme/calendar is returning a black-on-grey item in the first place?

Changed in unity8 (Ubuntu):
assignee: nobody → Nick Dedekind (nick-dedekind)
Changed in indicator-datetime (Ubuntu):
assignee: nobody → Charles Kerr (charlesk)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in indicator-datetime (Ubuntu):
status: New → Confirmed
Changed in unity8 (Ubuntu):
status: New → Confirmed
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Bug was in unity8. Old code which wasn't updated when the rest was.

Charles Kerr (charlesk)
Changed in indicator-datetime (Ubuntu):
status: Confirmed → Invalid
Changed in unity8 (Ubuntu):
importance: Undecided → Medium
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.