packaging of libappindicator0-cil is in violation of the Debian CLI Policy, making ${cli:Depends} not work

[Sense Egbert Hofstede]

Indicator Application does not call dh_makeclilibs at the correct place, due to improper target (binary-arch) naming, causing conflicts with CDBS's internal binary-arch rule. Hints from the build log:

make: Circular binary/libappindicator0-cil <- binary-arch dependency dropped.

The attached debdiff fixes this bug, in addition to fixing a few more CLI policy violations found in the package.

Symptoms/Consequences:
Banshee's AppIndicator extension, which links references the AppIndicator DLL, does not depend on libappindicator0-cil, despite having ${cli:Depends} in the list of binary dependencies.

$ apt-cache depends banshee-extension-appindicator
    banshee-extension-appindicator
      Depends: banshee
      Depends: banshee-extensions-common
      Depends: indicator-applet
      Depends: indicator-application
      Depends: libglib2.0-cil
      Depends: libgtk2.0-cil
      Depends: libmono-addins0.2-cil
      Depends: libmono-corlib2.0-cil
      Depends: libnotify0.4-cil

[Sense Egbert Hofstede (sense)]

If I'm correct it does not have to depend on indicator-applet or indicator-application, that's unnecessary.

[Sense Egbert Hofstede (sense)]

Chow Loong Jin pointed out that this is not an issue with the way banshee-extension-appindicator is packaged, but by the way 'libappindicator0-cil' is packaged. The way it is currently done is in violation of the Debian Policy and makes ${cli:Depends} work incorrect for packages that want to use libappindicator0-cil.

He said he would try to solve this bug.

[Chow Loong Jin (hyperair)]

On Sunday 11,April,2010 02:39 AM, Sense Hofstede wrote:
> Chow Loong Jin pointed out that this is not an issue with the way
> banshee-extension-appindicator is packaged, but by the way
> 'libappindicator0-cil' is packaged. The way it is currently done is in
> violation of the Debian Policy and makes ${cli:Depends} work incorrect
> for packages that want to use libappindicator0-cil.
>
> He said he would try to solve this bug.

Solved. Please refer to the CLI policy[1] when doing any packaging work that
involves CLI libraries in the future to avoid these kinds of errors.

[1] http://pkg-mono.alioth.debian.org/cli-policy/

  affects ubuntu/indicator-application
  status triaged

After this is uploaded, banshee-community-extensions will have to be rebuilt for
the changes to propagate. Other reverse-depends might need to be rebuilt as
well, but I'm not sure if any exist.

  affects ubuntu/banshee-community-extensions
  status triaged
  assignee hyperair

--
Kind regards,
Chow Loong Jin (GPG: 0x8F02A411)
Ubuntu Developer

[Sense Egbert Hofstede (sense)]

$ apt-cache rdepends libappindicator0-cil
    libappindicator0-cil
    Reverse Depends:
      libappindicator-cil-dev

Unless other applications suffer from the same bug there are no other rdepends for libappindicator0-cil.

[Chow Loong Jin (hyperair)]

Add a new debdiff that closes this bug in the changelog entry.

[Launchpad Janitor (janitor)]

This bug was fixed in the package indicator-application - 0.0.19-0ubuntu2

---------------
indicator-application (0.0.19-0ubuntu2) lucid; urgency=low

  * debian/control:
    + Set libappindicator0-cil and libappindicator-cil-dev to Arch: all
    + Make libappindicator0-cil depend on libappindicator0 >= ${source:Version}
      instead
  * debian/rules:
    + Fix ordering of dh_*cli* (LP: #560095)
  * debian/libappindicator0-cil.install,
    debian/libappindicator0-cil.installcligac:
    + Fix CLI policy breakage:
      - Wrong installation paths for GAC'd CLI libraries
      - Direct installation of GAC'd libraries
 -- Chow Loong Jin <email address hidden> Wed, 14 Apr 2010 18:44:22 +0800

[Launchpad Janitor (janitor)]

This bug was fixed in the package banshee-community-extensions - 1.6.0-1ubuntu3

---------------
banshee-community-extensions (1.6.0-1ubuntu3) lucid; urgency=low

  * debian/(control, rules):
    + Demote avant-window-navigator to suggests in banshee-extension-awn
    + Drop banshee-extension-telepathy; not installable due to dependency
      on telepathy-gabble >= 0.9 (LP: #559978)
    + Tighten build-dep on libappindicator-cil-dev due to missing clilibs
      in older versions (LP: #560095)
    + Drop indicator-applet and indicator-application from binary-deps of
      -appindicator
 -- Chow Loong Jin <email address hidden> Thu, 15 Apr 2010 00:26:37 +0800