[FTBFS] Don't treat -Wdeprecated-declarations as errors

[Khurshid Alam]

Don't treat -Wdeprecated-declarations as errors.

But we should really use G_DECLARE_TYPE_PRIVATE for this.

The launchpad bzr repo is not in sync with ubuntu source.

Hence attaching a patch here.

[Khurshid Alam (khurshid-alam)]

The patch is attached.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "deprecated_declarations.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Sebastien Bacher (seb128)]

The patch doesn't do what the title/description claims, you remove -Werror (which is fine) which has impact on warning other than the 'deprecated-declarations' ones

[Sebastien Bacher (seb128)]

Also what vcs are you talking about? Did we have one for the gtk2 compat version? If so could you share the url, maybe we can get that one updated?

[Sebastien Bacher (seb128)]

oh, also do we still need that package? it was added for xubuntu/lubuntu which were still using gtk2 at the time but xubuntu switched to gtk3 since no? (and is lubuntu still a thing?)

[Sebastien Bacher (seb128)]

(see bug #1811489)