"return" missing in ImpactPacket.TCPOptions.get_ts_echo

Bug #132802 reported by Swen Kühnlein
4
Affects Status Importance Assigned to Milestone
impacket (Ubuntu)
Undecided
Unassigned

Bug Description

The last statement in ImpackPacket.TCPOption.get_ts_echo is
self.get_long(6)
and get_ts_echo thus always returns None. Instead it should be
return self.get_long(6)

Revision history for this message
Swen Kühnlein (swen) wrote :
Revision history for this message
Daniel Holbach (dholbach) wrote :

To get your fix included in Ubuntu, try transforming it into a debdiff (http://wiki.ubuntu.com/PackagingGuide/Recipes/Debdiff) and submitting it for review (http://wiki.ubuntu.com/SponsorshipProcess).

Setting to 'incomplete' for now.

Changed in impacket:
status: New → Incomplete
Revision history for this message
Daniel Holbach (dholbach) wrote :

Setting to In Progress.

Changed in impacket:
status: Incomplete → In Progress
Revision history for this message
Catalin Patulea (cpatulea) wrote :

This was fixed in impacket SVN r67 and made it into impacket releases >= 0.9.7.0. Someone just needs to update the Ubuntu package with the latest release tarball from google code:
http://impacket.googlecode.com/files/Impacket-0.9.7.0.tar.gz

Revision history for this message
Emmanuel Arias (eamanu) wrote :

Hi, this issue seems to be out-of-date.

I think we should close this bug.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers