out-of-bounds write in coders/pdb.c:697

[Moshe Kaplan]

This bug was found while fuzzing ImageMagick with afl-fuzz

Tested on ImageMagick git commit %s

Command: magick id:000248,sig:06,src:003373,op:havoc,rep:8 /dev/null

=================================================================
==607==ERROR: AddressSanitizer: heap-buffer-overflow on address 0xb5b07113 at pc 0x866c784 bp 0xbf92de28 sp 0xbf92de20
WRITE of size 1 at 0xb5b07113 thread T0
    #0 0x866c783 in EncodeRLE /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/coders/pdb.c:697
    #1 0x866c783 in WritePDBImage /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/coders/pdb.c:906
    #2 0x8a95688 in WriteImage /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickCore/constitute.c:1091
    #3 0x8a9906c in WriteImages /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickCore/constitute.c:1309
    #4 0x93762df in CLINoImageOperator /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickWand/operation.c:4719
    #5 0x937e0f1 in CLIOption /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickWand/operation.c:5179
    #6 0x910bd93 in ProcessCommandOptions /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickWand/magick-cli.c:526
    #7 0x910e215 in MagickImageCommand /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickWand/magick-cli.c:786
    #8 0x91126f9 in MagickCommandGenesis /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickWand/mogrify.c:172
    #9 0x80de16d in MagickMain /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/utilities/magick.c:74
    #10 0x80de16d in main /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/utilities/magick.c:85
    #11 0xb7490a82 in __libc_start_main /build/buildd/eglibc-2.19/csu/libc-start.c:287
    #12 0x80ddf94 in _start (/usr/local/bin/magick+0x80ddf94)

0xb5b07113 is located 0 bytes to the right of 3-byte region [0xb5b07110,0xb5b07113)
allocated by thread T0 here:
    #0 0x80c6bc1 in malloc (/usr/local/bin/magick+0x80c6bc1)
    #1 0x81889a9 in AcquireMagickMemory /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickCore/memory.c:475
    #2 0x81889a9 in AcquireQuantumMemory /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickCore/memory.c:548
    #3 0x8a95688 in WriteImage /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickCore/constitute.c:1091
    #4 0x8a9906c in WriteImages /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickCore/constitute.c:1309
    #5 0x93762df in CLINoImageOperator /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickWand/operation.c:4719
    #6 0x937e0f1 in CLIOption /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickWand/operation.c:5179
    #7 0x910bd93 in ProcessCommandOptions /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/MagickWand/magick-cli.c:526

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/user/Desktop/imagemagick_fuzz_results/ImageMagick/coders/pdb.c:697 EncodeRLE
Shadow bytes around the buggy address:
  0x36b60dd0: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
  0x36b60de0: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
  0x36b60df0: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
  0x36b60e00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36b60e10: fa fa fa fa fa fa fa fa fa fa 04 fa fa fa 02 fa
=>0x36b60e20: fa fa[03]fa fa fa 00 00 fa fa 00 04 fa fa 00 00
  0x36b60e30: fa fa 00 04 fa fa 00 04 fa fa 00 04 fa fa 00 04
  0x36b60e40: fa fa 00 04 fa fa 00 07 fa fa fd fd fa fa fd fd
  0x36b60e50: fa fa 00 fa fa fa fd fd fa fa fd fd fa fa 00 fa
  0x36b60e60: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
  0x36b60e70: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable: 00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone: fa
  Heap right redzone: fb
  Freed heap region: fd
  Stack left redzone: f1
  Stack mid redzone: f2
  Stack right redzone: f3
  Stack partial redzone: f4
  Stack after return: f5
  Stack use after scope: f8
  Global redzone: f9
  Global init order: f6
  Poisoned by user: f7
  ASan internal: fe
==607==ABORTING

[Moshe Kaplan (moshekaplan)]

input file to trigger crash

[Moshe Kaplan (moshekaplan)]

Reported upstream at: https://github.com/ImageMagick/ImageMagick/issues/121

[Launchpad Janitor (janitor)]

This bug was fixed in the package imagemagick - 8:6.9.6.6+dfsg-1ubuntu3

---------------
imagemagick (8:6.9.6.6+dfsg-1ubuntu3) zesty; urgency=medium

  * debian/patches/0020-Revert-GradientImage-change.patch: Revert patch
    per https://github.com/ImageMagick/ImageMagick/issues/316. Thanks
    to Cristy <email address hidden>. Closes LP: #1645406.

 -- Nishanth Aravamudan <email address hidden> Tue, 06 Dec 2016 17:26:36 +0100