out-of-bounds read in coders/psd.c:524

Bug #1537418 reported by Moshe Kaplan on 2016-01-24
256
This bug affects 1 person
Affects Status Importance Assigned to Milestone
imagemagick (Ubuntu)
Undecided
Unassigned

Bug Description

=================================================================
==14781==ERROR: AddressSanitizer: heap-buffer-overflow on address 0xb4804860 at pc 0x87748af bp 0xbfc4b818 sp 0xbfc4b810
READ of size 1 at 0xb4804860 thread T0
    #0 0x87748ae in DecodePSDPixels /home/user/Desktop/ImageMagick/coders/psd.c:524
    #1 0x87748ae in ReadPSDChannelRLE /home/user/Desktop/ImageMagick/coders/psd.c:1024
    #2 0x875d46b in ReadPSDMergedImage /home/user/Desktop/ImageMagick/coders/psd.c:1733
    #3 0x875d46b in ReadPSDImage /home/user/Desktop/ImageMagick/coders/psd.c:2004
    #4 0x8a9438a in ReadImage /home/user/Desktop/ImageMagick/MagickCore/constitute.c:494
    #5 0x8a9c1ff in ReadImages /home/user/Desktop/ImageMagick/MagickCore/constitute.c:844
    #6 0x9371649 in CLINoImageOperator /home/user/Desktop/ImageMagick/MagickWand/operation.c:4663
    #7 0x9379b31 in CLIOption /home/user/Desktop/ImageMagick/MagickWand/operation.c:5157
    #8 0x910713d in ProcessCommandOptions /home/user/Desktop/ImageMagick/MagickWand/magick-cli.c:474
    #9 0x910a4b5 in MagickImageCommand /home/user/Desktop/ImageMagick/MagickWand/magick-cli.c:786
    #10 0x910e999 in MagickCommandGenesis /home/user/Desktop/ImageMagick/MagickWand/mogrify.c:172
    #11 0x80de12d in MagickMain /home/user/Desktop/ImageMagick/utilities/magick.c:74
    #12 0x80de12d in main /home/user/Desktop/ImageMagick/utilities/magick.c:85
    #13 0xb7512a82 in __libc_start_main /build/buildd/eglibc-2.19/csu/libc-start.c:287
    #14 0x80ddf54 in _start (/usr/local/bin/magick+0x80ddf54)

0xb4804860 is located 0 bytes to the right of 64-byte region [0xb4804820,0xb4804860)
allocated by thread T0 here:
    #0 0x80c6b81 in malloc (/usr/local/bin/magick+0x80c6b81)
    #1 0x81932f9 in AcquireMagickMemory /home/user/Desktop/ImageMagick/MagickCore/memory.c:475
    #2 0x81932f9 in AcquireQuantumMemory /home/user/Desktop/ImageMagick/MagickCore/memory.c:548

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/user/Desktop/ImageMagick/coders/psd.c:524 DecodePSDPixels
Shadow bytes around the buggy address:
  0x369008b0: 00 00 00 00 00 00 00 04 fa fa fa fa 00 00 00 00
  0x369008c0: 00 00 00 04 fa fa fa fa 00 00 00 00 00 00 00 04
  0x369008d0: fa fa fa fa 00 00 00 00 00 00 00 04 fa fa fa fa
  0x369008e0: 00 00 00 00 00 00 00 04 fa fa fa fa 00 00 00 00
  0x369008f0: 00 00 00 04 fa fa fa fa 00 00 00 00 00 00 00 04
=>0x36900900: fa fa fa fa 00 00 00 00 00 00 00 00[fa]fa fa fa
  0x36900910: 00 00 00 00 00 00 00 04 fa fa fa fa 00 00 00 00
  0x36900920: 00 00 00 04 fa fa fa fa 00 00 00 00 00 00 00 04
  0x36900930: fa fa fa fa 00 00 00 00 00 00 00 04 fa fa fa fa
  0x36900940: 00 00 00 00 00 00 00 04 fa fa fa fa 00 00 00 00
  0x36900950: 00 00 00 04 fa fa fa fa 00 00 00 00 00 00 00 04
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable: 00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone: fa
  Heap right redzone: fb
  Freed heap region: fd
  Stack left redzone: f1
  Stack mid redzone: f2
  Stack right redzone: f3
  Stack partial redzone: f4
  Stack after return: f5
  Stack use after scope: f8
  Global redzone: f9
  Global init order: f6
  Poisoned by user: f7
  ASan internal: fe
==14781==ABORTING

Moshe Kaplan (mk-moshe-kaplan) wrote :

input file to trigger crash

Moshe Kaplan (mk-moshe-kaplan) wrote :

This bug was found while fuzzing ImageMagick with afl-fuzz

Tested on git commit 87b213f9e2578611654a74ea0c6014367f4dc2fa

Command: magick $infile /dev/null

summary: - heap-buffer-overflow in coders/psd.c:524
+ out-of-bounds read in coders/psd.c:524
Changed in imagemagick (Ubuntu):
status: New → Confirmed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package imagemagick - 8:6.9.6.6+dfsg-1ubuntu3

---------------
imagemagick (8:6.9.6.6+dfsg-1ubuntu3) zesty; urgency=medium

  * debian/patches/0020-Revert-GradientImage-change.patch: Revert patch
    per https://github.com/ImageMagick/ImageMagick/issues/316. Thanks
    to Cristy <email address hidden>. Closes LP: #1645406.

 -- Nishanth Aravamudan <email address hidden> Tue, 06 Dec 2016 17:26:36 +0100

Changed in imagemagick (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public Security information  Edit
Everyone can see this security related information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.