out-of-bounds read in MagickCore/pixel-accessor.h:778 SetPixelViaPixelInfo

Bug #1533451 reported by Moshe Kaplan
256
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ImageMagick
Fix Released
Unknown
imagemagick (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

This bug was found while fuzzing ImageMagick with afl-fuzz

Tested on ImageMagick version d8382f9c0ffa52057271a6a323e7e062f0fe4ff6

Command: magick infile /dev/null

Build info:

#Configure command:
CC=afl-clang-fast CXX=afl-clang-fast++ ./configure --with-bzlib=no --with-djvu=no --with-dps=no --with-fftw=no --with-fpx=no --with-fontconfig=no --with-freetype=no --with-gvc=no --with-jbig=no --with-jpeg=no --with-lcms=no --with-lqr=no --with-ltdl=no --with-lzma=no --with-openexr=no --with-openjp2=no --with-pango=no --with-png=no --with-tiff=no --with-wmf=no --with-x=no --with-xml=no --with-zlib=no --enable-hdri=no --enable-shared=no

#Make command:
CC=afl-clang-fast CXX=afl-clang-fast++ make

ASAN output:

=================================================================
==21361==ERROR: AddressSanitizer: heap-buffer-overflow on address 0xb3107468 at pc 0x877c883 bp 0xbf826798 sp 0xbf826790
READ of size 4 at 0xb3107468 thread T0
    #0 0x877c882 in SetPixelViaPixelInfo /home/user/Desktop/imagemagick_reporting/ImageMagick/./MagickCore/pixel-accessor.h:778:5
    #1 0x877c882 in ReadPSDChannelPixels /home/user/Desktop/imagemagick_reporting/ImageMagick/coders/psd.c:837
    #2 0x8776ccb in ReadPSDChannelRaw /home/user/Desktop/imagemagick_reporting/ImageMagick/coders/psd.c:925
    #3 0x875eb8f in ReadPSDMergedImage /home/user/Desktop/imagemagick_reporting/ImageMagick/coders/psd.c:1728
    #4 0x875eb8f in ReadPSDImage /home/user/Desktop/imagemagick_reporting/ImageMagick/coders/psd.c:1994
    #5 0x8a8b97a in ReadImage /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickCore/constitute.c:494
    #6 0x8a937ef in ReadImages /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickCore/constitute.c:844
    #7 0x93754a9 in CLINoImageOperator /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/operation.c:4663
    #8 0x937d98f in CLIOption /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/operation.c:5157
    #9 0x910afad in ProcessCommandOptions /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/magick-cli.c:474
    #10 0x910e325 in MagickImageCommand /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/magick-cli.c:786
    #11 0x9112809 in MagickCommandGenesis /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/mogrify.c:172
    #12 0x80de10d in MagickMain /home/user/Desktop/imagemagick_reporting/ImageMagick/utilities/magick.c:74
    #13 0x80de10d in main /home/user/Desktop/imagemagick_reporting/ImageMagick/utilities/magick.c:85
    #14 0xb7499a82 in __libc_start_main /build/buildd/eglibc-2.19/csu/libc-start.c:287
    #15 0x80ddf34 in _start (/home/user/Desktop/imagemagick_reporting/ImageMagick/utilities/magick+0x80ddf34)

AddressSanitizer can not describe address in more detail (wild memory access suspected).
SUMMARY: AddressSanitizer: heap-buffer-overflow /home/user/Desktop/imagemagick_reporting/ImageMagick/./MagickCore/pixel-accessor.h:778 SetPixelViaPixelInfo
Shadow bytes around the buggy address:
  0x36620e30: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36620e40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36620e50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36620e60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36620e70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x36620e80: fa fa fa fa fa fa fa fa fa fa fa fa fa[fa]fa fa
  0x36620e90: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36620ea0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36620eb0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36620ec0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36620ed0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable: 00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone: fa
  Heap right redzone: fb
  Freed heap region: fd
  Stack left redzone: f1
  Stack mid redzone: f2
  Stack right redzone: f3
  Stack partial redzone: f4
  Stack after return: f5
  Stack use after scope: f8
  Global redzone: f9
  Global init order: f6
  Poisoned by user: f7
  ASan internal: fe
==21361==ABORTING

Revision history for this message
Moshe Kaplan (moshekaplan) wrote :
information type: Private Security → Public Security
summary: - heap-buffer-overflow in MagickCore/pixel-accessor.h:778
+ out-of-bounds read in MagickCore/pixel-accessor.h:778
SetPixelViaPixelInfo
Revision history for this message
Moshe Kaplan (moshekaplan) wrote :
Revision history for this message
Moshe Kaplan (moshekaplan) wrote :

Resolved upstream

Changed in imagemagick (Ubuntu):
status: New → Confirmed
Changed in imagemagick (Ubuntu):
status: Confirmed → Fix Released
Changed in imagemagick:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public Security information  
Everyone can see this security related information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.