out-of-bounds read in coders/rle.c:590 ReadRLEImage

[Moshe Kaplan]

This bug was found while fuzzing ImageMagick with afl-fuzz

Tested on ImageMagick version d8382f9c0ffa52057271a6a323e7e062f0fe4ff6

Command: magick infile /dev/null

Build info:

#Configure command:
CC=afl-clang-fast CXX=afl-clang-fast++ ./configure --with-bzlib=no --with-djvu=no --with-dps=no --with-fftw=no --with-fpx=no --with-fontconfig=no --with-freetype=no --with-gvc=no --with-jbig=no --with-jpeg=no --with-lcms=no --with-lqr=no --with-ltdl=no --with-lzma=no --with-openexr=no --with-openjp2=no --with-pango=no --with-png=no --with-tiff=no --with-wmf=no --with-x=no --with-xml=no --with-zlib=no --enable-hdri=no --enable-shared=no

#Make command:
CC=afl-clang-fast CXX=afl-clang-fast++ make

ASAN output:

==2495==ERROR: AddressSanitizer: heap-buffer-overflow on address 0xb5006e40 at pc 0x87bb424 bp 0xbfd13a68 sp 0xbfd13a60
READ of size 1 at 0xb5006e40 thread T0
    #0 0x87bb423 in ReadRLEImage /home/user/Desktop/imagemagick_reporting/ImageMagick/coders/rle.c:590:21
    #1 0x8a8b97a in ReadImage /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickCore/constitute.c:494
    #2 0x8a937ef in ReadImages /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickCore/constitute.c:844
    #3 0x93754a9 in CLINoImageOperator /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/operation.c:4663
    #4 0x937d98f in CLIOption /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/operation.c:5157
    #5 0x910afad in ProcessCommandOptions /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/magick-cli.c:474
    #6 0x910e325 in MagickImageCommand /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/magick-cli.c:786
    #7 0x9112809 in MagickCommandGenesis /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/mogrify.c:172
    #8 0x80de10d in MagickMain /home/user/Desktop/imagemagick_reporting/ImageMagick/utilities/magick.c:74
    #9 0x80de10d in main /home/user/Desktop/imagemagick_reporting/ImageMagick/utilities/magick.c:85
    #10 0xb756ba82 in __libc_start_main /build/buildd/eglibc-2.19/csu/libc-start.c:287
    #11 0x80ddf34 in _start (/home/user/Desktop/imagemagick_reporting/ImageMagick/utilities/magick+0x80ddf34)

0xb5006e40 is located 0 bytes to the right of 6464-byte region [0xb5005500,0xb5006e40)
allocated by thread T0 here:
    #0 0x80c7001 in __interceptor_posix_memalign (/home/user/Desktop/imagemagick_reporting/ImageMagick/utilities/magick+0x80c7001)
    #1 0x8194163 in AcquireAlignedMemory /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickCore/memory.c:261
    #2 0x8194163 in AcquireVirtualMemory /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickCore/memory.c:591
    #3 0x87b0615 in ReadRLEImage /home/user/Desktop/imagemagick_reporting/ImageMagick/coders/rle.c:318
    #4 0x8a8b97a in ReadImage /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickCore/constitute.c:494
    #5 0x8a937ef in ReadImages /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickCore/constitute.c:844
    #6 0x93754a9 in CLINoImageOperator /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/operation.c:4663
    #7 0x937d98f in CLIOption /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/operation.c:5157
    #8 0x910afad in ProcessCommandOptions /home/user/Desktop/imagemagick_reporting/ImageMagick/MagickWand/magick-cli.c:474

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/user/Desktop/imagemagick_reporting/ImageMagick/coders/rle.c:590 ReadRLEImage
Shadow bytes around the buggy address:
  0x36a00d70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x36a00d80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x36a00d90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x36a00da0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x36a00db0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x36a00dc0: 00 00 00 00 00 00 00 00[fa]fa fa fa fa fa fa fa
  0x36a00dd0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a00de0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a00df0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a00e00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a00e10: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable: 00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone: fa
  Heap right redzone: fb
  Freed heap region: fd
  Stack left redzone: f1
  Stack mid redzone: f2
  Stack right redzone: f3
  Stack partial redzone: f4
  Stack after return: f5
  Stack use after scope: f8
  Global redzone: f9
  Global init order: f6
  Poisoned by user: f7
  ASan internal: fe

[Moshe Kaplan (moshekaplan)]

https://github.com/ImageMagick/ImageMagick/issues/82

[Moshe Kaplan (moshekaplan)]

Resolved upstream

[Launchpad Janitor (janitor)]

This bug was fixed in the package imagemagick - 8:6.9.6.6+dfsg-1ubuntu3

---------------
imagemagick (8:6.9.6.6+dfsg-1ubuntu3) zesty; urgency=medium

  * debian/patches/0020-Revert-GradientImage-change.patch: Revert patch
    per https://github.com/ImageMagick/ImageMagick/issues/316. Thanks
    to Cristy <email address hidden>. Closes LP: #1645406.

 -- Nishanth Aravamudan <email address hidden> Tue, 06 Dec 2016 17:26:36 +0100