[FFe] Update ogre-next to 2.3.3 for Noble

[Jose Luis Rivero]

Version bump for ogre-next to version 2.3.3, well tested by Open Robotics under the Gazebo simulator.

 * Package PPA:
  - https://code.launchpad.net/~j-rivero/+archive/ubuntu/ogre-next-recipe
 * Git ubunut/devel branch
   - https://code.launchpad.net/~j-rivero/ubuntu/+source/ogre-next/+git/ogre-next

[Justification]

ogre-next current version is 2.2.5 and was released in 2021. It does not support vulkan which probably make the release not interesting for the vast majority of current rendering developers. The bump also fixes
LP: #1987207 and LP: #2003346.

[Changelog]
Upstream does not provide a Changelog file nor a NEWS file nor other
updated mechanism that is not the GitHub release information notes.
The list of bugfixes and features listed from 2.2.5 is simply huge:
https://github.com/OGRECave/ogre-next/releases

[Other Info]

The package is not included in Debian. The version bump to 2.3.1 has been used by the Gazebo simulator team for the latest releases of Gazebo during several years and I've included the patches that has proven to be necessary, specially for vulkan support. Many of the
Open Robotics patches has been merged upstream.

Changes done with respect to ubuntu/devel branch:

1dc7fa0 (HEAD -> ubuntu/devel, origin/ubuntu/devel) Update d/changelog
fe78c7b Upstream fixed install paths to be standard
b272862 Update d/copyright
5ccf1e5 Massive cleanup of d/rules
c020ca5 Update d/changelog
5cb9fdb [PATCH] Added suport for riscv64 and ppc64
6ca8aa6 Rediff patches
3b2cb51 Update d/control and .install to 2.3.3
3d60843 Update upstream source from tag 'upstream/2.3.3+dfsg'
687514e (tag: upstream/2.3.3+dfsg, origin/upstream, upstream) New upstream version 2.3.3+dfsg
547df32 Fix blender-ogre conflict name
3940cc5 Update d/changelog
d50eb7e Added a d/gbp.conf
3286c7d Initial commit on orphan branch

Changes in d/changelog:
  * New upstream version 2.3.3+dfsg
  * Rediff patches
  * Massive cleanup of d/rules after upstream merges
  * Update d/control and .install to 2.3.3
  * Update d/copyright
  * Fix package name for conflict with 1.9
    (LP: #1987207) (LP: #2003346)
  * Fix blender-ogre conflict name
  * [PATCH] Added support for riscv64 and ppc64

[Dependencies]

Update from March 24: ignition-rendering was removed from Noble in https://bugs.launchpad.net/ubuntu/+source/ignition-rendering/+bug/2058851. There is no direct dependency for ogre-next in Noble.

There is another package that deal with ogre-next in an indirect manner providing build helpers: ignition-cmake. I've also patched this package to improve the ogre-next patch:

 * Same package PPA with ogre-next 2.17.1-2ubuntu2
  - https://code.launchpad.net/~j-rivero/+archive/ubuntu/ogre-next-recipe
 * Git and code for
   - https://code.launchpad.net/~j-rivero/ubuntu/+source/ignition-cmake/+git/ignition-cmake/+ref/ubuntu/devel

[Outdated info related to ignition-rendering]

Outdated after the removal of ignition-rendering on March 24th from Noble.
~~~~
There is one direct dependency of ogre-next, ignition-rendering. Given that the version in Debian/Ubuntu is too old and probably a candidate to be removed, I've uploaded a new version of ignition-rendering that drops the support for ogre-next. It is still useful since it can use ogre-1.9.

 * Same package PPA with ogre-next
  - https://code.launchpad.net/~j-rivero/+archive/ubuntu/ogre-next-recipe
 * Git and code for 6.1.0+ds-0ubuntu3:
   - https://code.launchpad.net/~j-rivero/ubuntu/+source/ignition-rendering/+git/ignition-rendering/+ref/ubuntu/devel
~~~~

[Andreas Hasenack (ahasenack)]

Noble has entered feature freeze yesterday[1], and this bug now needs a feature freeze exception[2] approval to move forward. Please follow the process described in [2] and once the Ubuntu Release team has approved this exception, re-subscribe sponsors.

1. https://lists.ubuntu.com/archives/ubuntu-devel-announce/2024-March/001343.html
2. https://wiki.ubuntu.com/FreezeExceptionProcess

[Steve Langasek (vorlon)]

FFe approved for ignition-rendering to drop use of ogre-next, and for updating ogre-next. I'm not sure why there's an ignition-cmake task here, please clarify.

[Jose Luis Rivero (j-rivero)]

Thanks Steve for the approval.

> I'm not sure why there's an ignition-cmake task here, please clarify.

ignition-cmake are a set of CMake helpers used by the ignition/gazebo family but can also be used alone. One of the helpers is a Find module for ogre-next (also named Ogre2) https://salsa.debian.org/science-team/ignition-cmake/-/blob/master/cmake/FindIgnOGRE2.cmake. Now that ogre-next used a more standard approach for installing files and dirs, we need to update the module to drop hacks and other ugly patches.

Final note: I realized yesterday that the vulkan support was not being detected in the packaging so I've imported a couple of patches to make it work on all arches. Final d/changelog:

ogre-next (2.3.3+dfsg-0ubuntu1) UNRELEASED; urgency=medium

  * New upstream version 2.3.3+dfsg
  * Rediff patches
  * Massive cleanup of d/rules after upstream merges
  * Update d/control and .install to 2.3.3
  * Update d/copyright
  * Fix package name for conflict with 1.9
    (LP: #1987207) (LP: #2003346)
  * Fix blender-ogre conflict name
  * Added vulkan dependencies
  * [PATCH] Added support for riscv64 and ppc64
  * [PATCH] Avoid shaderrc vulkan dependency
  * [PATCH] Fix armhf vulkan build

Corresponding 2.3.3+dfsg-5 build in the PPA
https://code.launchpad.net/~j-rivero/+recipe/ogre-next-daily-1

[Andreas Hasenack (ahasenack)]

Jose, if you feel like you answered the question from #2, then please change the bug status back to new, or else the release team won't get back to this bug.

[Jose Luis Rivero (j-rivero)]

Thanks for the info Andreas!

Update: yesterday ignition-rendering was removed from Noble in https://bugs.launchpad.net/ubuntu/+source/ignition-rendering/+bug/2058851. I'm going to update the description to remove the references to ignition-rendering.

[Dave Jones (waveform)]

Okay, ogre-next looks good for sponsoring, so I'm going ahead with that one. I'm not clear from the above if FFe acceptance was given for ignition-cmake so I'm leaving that for now.

One thing to bear in mind: the ogre-next build was pretty clean but did throw up some lintian warnings about obsolete packages (specifically libgl1-mesa-dev=>libgl-dev, libfreetype6-dev=>libfreetype-dev, and pkg-config=>pkgconf). I tried a quick test-build on amd64 to see if those broke the build and they didn't (but that doesn't mean the result worked or would on all archs, so I'm not uploading with that change), but it's something that may be worth checking for the future.

[Dave Jones (waveform)]

I've removed ubuntu-sponsors for now, but please feel free to re-subscribe when it's clear ignition-cmake is also ack'd for FFe.

[Jose Luis Rivero (j-rivero)]

I'm afraid that we are stuck in transitioning https://ubuntu-archive-team.ubuntu.com/proposed-migration/update_excuses.html#ogre-next because there is a problem with autopkgtest. Sorry for that.

I've created a new merge-request to solve the problem https://code.launchpad.net/~j-rivero/ubuntu/+source/ogre-next/+git/ogre-next/+merge/464598.

Adding back ubuntu-sponsors to help with the upload. Thanks!

> I'm not clear from the above if FFe acceptance was given for ignition-cmake so I'm leaving that for now.

That is waiting for release-team, I provided contexts and info in https://bugs.launchpad.net/ubuntu/+source/ogre-next/+bug/2054477/comments/3

[Jose Luis Rivero (j-rivero)]

The ogre-next update was released and ignition-cmake was removed in https://bugs.launchpad.net/ubuntu/+source/ros-catkin/+bug/2063103. I've updated the statuses. All done here.