Activity log for bug #1629972

Date Who What changed Old value New value Message
2016-10-03 18:43:10 LaMont Jones bug added bug
2016-10-03 18:43:38 LaMont Jones bug task added maas
2016-10-03 18:44:56 LaMont Jones nominated for series Ubuntu Xenial
2016-10-03 18:44:56 LaMont Jones bug task added ifupdown (Ubuntu Xenial)
2016-10-03 18:52:28 LaMont Jones description With the switch to systemd, all support for iscsi root (and other) filesystems disappeared, since shutdown yanks the rug out from under us. Rather than just relying on /etc/iscsi/iscsi.initramfs (which d-i creates..), the DEV check should be expanded to include iscsi devices, and networking.service ExecStop should honor those checks. With the switch to systemd, all support for iscsi root (and other) filesystems disappeared, since shutdown yanks the rug out from under us. Rather than just relying on /etc/iscsi/iscsi.initramfs (which d-i creates..), the DEV check should be expanded to include iscsi devices, and networking.service ExecStop should honor those checks. Related bugs: * bug 1229458: grub2 needed changes * bug 1621615: network not configured when ipv6 netbooted into cloud-init * bug 1621507: ipv6 network boot does not work [Impact] With the changes from the above, the iscsi root (at least in the ipv6 case) gets disconneceted prior to clean shutdown (ifdown downs the interface), resulting in a failure to enlist, commission, or deploy cleanly under MAAS. (and a failure to cleanly unmount the root filesystem when it is over iscsi.) [Test Case] Given a MAAS 2.0 installation, and the packages in the other bugs, attempt to enlist, commission, or deploy a host with xenial. [Regression potential] This restores the pre-xenial behavior of not shutting down the interface if there are network drives at the time that neworking is stopped (making it a no-op.) The additional change is to detect "/dev/disk/by-path/*-iscsi-*" as a network disk, replacing the check for the existence of /etc/iscsi/iscsi.initramfs, which was only created by debian-installer (and maas until recently).
2016-10-10 15:05:28 Andres Rodriguez maas: status New Triaged
2016-10-10 15:05:31 Andres Rodriguez maas: milestone 2.1.0
2016-10-11 22:34:07 LaMont Jones ifupdown (Ubuntu): assignee LaMont Jones (lamont)
2016-10-12 20:04:12 Scott Moser ifupdown (Ubuntu): status New Confirmed
2016-10-12 20:04:16 Scott Moser ifupdown (Ubuntu): importance Undecided High
2016-10-12 20:04:19 Scott Moser ifupdown (Ubuntu Xenial): status New Confirmed
2016-10-12 20:04:22 Scott Moser ifupdown (Ubuntu Xenial): importance Undecided High
2016-10-12 20:35:41 Scott Moser bug added subscriber Martin Pitt
2016-10-13 17:13:47 Andres Rodriguez maas: milestone 2.1.0 2.1.1
2016-10-13 20:16:23 Scott Moser ifupdown (Ubuntu): assignee Scott Moser (smoser)
2016-10-13 20:16:26 Scott Moser ifupdown (Ubuntu Xenial): assignee Scott Moser (smoser)
2016-10-17 17:43:10 Scott Moser bug watch added http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841106
2016-10-17 17:43:10 Scott Moser bug task added ifupdown (Debian)
2016-10-17 22:04:18 Bug Watch Updater ifupdown (Debian): status Unknown New
2016-10-20 18:30:48 Scott Moser nominated for series Ubuntu Yakkety
2016-10-20 18:30:48 Scott Moser bug task added ifupdown (Ubuntu Yakkety)
2016-10-20 18:31:03 Scott Moser ifupdown (Ubuntu Yakkety): importance Undecided Medium
2016-10-20 18:31:03 Scott Moser ifupdown (Ubuntu Yakkety): status New Confirmed
2016-10-20 19:32:41 Martin Pitt ifupdown (Ubuntu Yakkety): status Confirmed Fix Committed
2016-10-20 19:32:43 Martin Pitt bug added subscriber Ubuntu Stable Release Updates Team
2016-10-20 19:32:46 Martin Pitt bug added subscriber SRU Verification
2016-10-20 19:32:52 Martin Pitt tags maas-ipv6 maas-ipv6 verification-needed
2016-10-20 19:33:18 Martin Pitt ifupdown (Ubuntu): status Confirmed Fix Committed
2016-10-20 21:09:54 Launchpad Janitor ifupdown (Ubuntu): status Fix Committed Fix Released
2016-11-04 14:32:49 Blake Rouse maas: milestone 2.1.1 2.1.2
2016-11-23 13:51:05 Andres Rodriguez maas: milestone 2.1.2 2.1.3
2016-11-30 17:08:46 Scott Moser tags maas-ipv6 verification-needed maas-ipv6 verification-done
2016-11-30 17:40:48 Scott Moser ifupdown (Ubuntu Xenial): status Confirmed In Progress
2016-11-30 18:13:37 Scott Moser description With the switch to systemd, all support for iscsi root (and other) filesystems disappeared, since shutdown yanks the rug out from under us. Rather than just relying on /etc/iscsi/iscsi.initramfs (which d-i creates..), the DEV check should be expanded to include iscsi devices, and networking.service ExecStop should honor those checks. Related bugs: * bug 1229458: grub2 needed changes * bug 1621615: network not configured when ipv6 netbooted into cloud-init * bug 1621507: ipv6 network boot does not work [Impact] With the changes from the above, the iscsi root (at least in the ipv6 case) gets disconneceted prior to clean shutdown (ifdown downs the interface), resulting in a failure to enlist, commission, or deploy cleanly under MAAS. (and a failure to cleanly unmount the root filesystem when it is over iscsi.) [Test Case] Given a MAAS 2.0 installation, and the packages in the other bugs, attempt to enlist, commission, or deploy a host with xenial. [Regression potential] This restores the pre-xenial behavior of not shutting down the interface if there are network drives at the time that neworking is stopped (making it a no-op.) The additional change is to detect "/dev/disk/by-path/*-iscsi-*" as a network disk, replacing the check for the existence of /etc/iscsi/iscsi.initramfs, which was only created by debian-installer (and maas until recently). === Begin SRU Template === [Impact] The systemd networking.service unit will bring down the loopback device (lo) when it is stopped. This behavior differs from the behavior in other Ubuntu releases (upstart's networking.conf), where 'lo' is not taken down. The problem that was seen was that iscsi root over ipv6 would hang on shutdown. [Test Case] Test is fairly simple and can be demonstrated in lxc container. The key is really that the lo device should not have its link set down after stopping networking.service. So, below: out=$(ip address show dev lo up); [ -n "$out" ] && echo "$out" || echo empty should not show 'empty', but should have LOOPBACK,UP,LOWER in its output. $ release=yakkety; name=y1 $ lxc launch ubuntu-daily:$release $name $ sleep 10 $ lxc exec $name /bin/bash ## show only things that are up (note output has LOOPBACK,UP,LOWER_UP) % ip link show dev lo 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 % ip address show dev lo up 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft forever ## Stop the service and show lo link is down (no 'UP' or 'LOWER_UP'). % systemctl stop networking.service % ip link show dev lo 1: lo: <LOOPBACK> mtu 65536 qdisc noqueue state DOWN mode DEFAULT group default qlen 1 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 % out=$(ip address show dev lo up); [ -n "$out" ] && echo "$out" || echo empty empty ## Now enable proposed, install update, reboot and show. % rel=$(lsb_release -sc) % echo "deb http://archive.ubuntu.com/ubuntu $rel-proposed main" | sudo tee /etc/apt/sources.list.d/proposed.list % sudo apt update -qy && sudo apt install -qy ifupdown </dev/null % dpkg-query --show ifupdown ifupdown 0.8.13ubuntu3 % sudo reboot ## in rebooted system % ip link show dev lo 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 % ip address show dev lo up 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft forever % systemctl stop networking.service % ip link show dev lo 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 % out=$(ip address show dev lo up); [ -n "$out" ] && echo "$out" || echo empty 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft forever [Regression Potential] Should be pretty low. zesty and yakkety-proposed have this. Taking down 'lo' is often cause of problems, and never the solution to problems as far as I'm aware. [Other Info] === End SRU Template === With the switch to systemd, all support for iscsi root (and other) filesystems disappeared, since shutdown yanks the rug out from under us. Rather than just relying on /etc/iscsi/iscsi.initramfs (which d-i creates..), the DEV check should be expanded to include iscsi devices, and networking.service ExecStop should honor those checks. Related bugs:   * bug 1229458: grub2 needed changes   * bug 1621615: network not configured when ipv6 netbooted into cloud-init   * bug 1621507: ipv6 network boot does not work
2016-12-01 17:29:52 Brian Murray removed subscriber Ubuntu Stable Release Updates Team
2016-12-01 17:29:50 Launchpad Janitor ifupdown (Ubuntu Yakkety): status Fix Committed Fix Released
2016-12-09 18:14:55 Robie Basak ifupdown (Ubuntu Xenial): status In Progress Fix Committed
2016-12-09 18:14:58 Robie Basak bug added subscriber Ubuntu Stable Release Updates Team
2016-12-09 18:15:05 Robie Basak tags maas-ipv6 verification-done maas-ipv6
2016-12-09 18:15:06 Robie Basak tags maas-ipv6 maas-ipv6 verification-needed
2016-12-09 18:15:57 Robie Basak bug added subscriber Robie Basak
2016-12-19 14:27:10 LaMont Jones tags maas-ipv6 verification-needed maas-ipv6 verification-done
2016-12-19 16:28:35 Launchpad Janitor ifupdown (Ubuntu Xenial): status Fix Committed Fix Released
2016-12-20 13:00:53 Gavin Panella maas: status Triaged Confirmed
2017-01-11 03:36:08 Bug Watch Updater ifupdown (Debian): status New Fix Released
2019-09-19 15:01:47 Adam Collard maas: status Confirmed Invalid