ifup & ifdown crash if multiple interfaces are listed in no-scripts

Bug #1618726 reported by Richard Laager on 2016-08-31
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ifupdown (Debian)
Fix Released
Unknown
ifupdown (Ubuntu)
High
Unassigned
Xenial
High
Unassigned

Bug Description

[Impact]
ifup and ifupdown segfault if multiple interfaces are listed in no-scripts

This is a trivially reproducible crash in ifup/ifdown, with a patch attached.

[Test Case]
Steps to reproduce:
1) echo no-scripts foo bar >> /etc/network/interfaces
2) ifup baz

Expected results:
Unknown interface baz

Actual results:
Segmentation fault (core dumped)

It's irrelevant whether the second interface is on the same no-scripts line or separate one. This will crash just the same:
echo no-scripts foo >> /etc/network/interfaces
echo no-scripts bar >> /etc/network/interfaces

[Regression potential]
Seems slight. The patch fixes a clear bug in code that is only used to process the no-scripts (and apparently no-auto-down) stanzas.

Richard Laager (rlaager) wrote :
Richard Laager (rlaager) wrote :
description: updated
tags: added: patch
Changed in ifupdown (Ubuntu):
importance: Undecided → High
tags: added: xenial yakkety
Michael Hudson-Doyle (mwhudson) wrote :

Fun. This bug affects Debian too it seems, I'll forward it along there unless you have already?

Richard Laager (rlaager) wrote :

I did not forward it. I sometimes do, sometimes don't, depending on a lot of factors. In this case, even though I assumed it would affect Debian, I was hesitant to claim the existence of a high priority bug if I hadn't personally verified it.

Changed in ifupdown (Ubuntu):
status: New → Fix Committed
Changed in ifupdown (Ubuntu Xenial):
status: New → In Progress
Michael Hudson-Doyle (mwhudson) wrote :

Oops, meant to say a bit more than just that. I verified the problem in Debian unstable, verified that the patch fixed the problem, and forwarded the bug/patch along to debian.

I've also uploaded the patch to Yakkety and put it into the SRU queue for Xenial. Thanks for the report and patch!

Changed in ifupdown (Ubuntu Xenial):
importance: Undecided → High
Changed in ifupdown (Debian):
status: Unknown → New

Hello Richard, or anyone else affected,

Accepted ifupdown into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ifupdown/0.8.10ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ifupdown (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed
Richard Laager (rlaager) wrote :

The package from proposed works. I tested version 0.8.10ubuntu1.1. The diff looks correct.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ifupdown - 0.8.13ubuntu2

---------------
ifupdown (0.8.13ubuntu2) yakkety; urgency=medium

  * Fix a crash when multiple interfaces are specified for no-scripts
    (LP: #1618726)

 -- Richard Laager <email address hidden> Wed, 31 Aug 2016 02:26:31 -0500

Changed in ifupdown (Ubuntu):
status: Fix Committed → Fix Released
Changed in ifupdown (Debian):
status: New → Fix Released

The verification of the Stable Release Update for ifupdown has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ifupdown - 0.8.10ubuntu1.1

---------------
ifupdown (0.8.10ubuntu1.1) xenial; urgency=medium

  * Fix a crash when multiple interfaces are specified for no-scripts
    (LP: #1618726)

 -- Richard Laager <email address hidden> Wed, 31 Aug 2016 02:29:11 -0500

Changed in ifupdown (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.