Volume (slider) item isn't highlighted when selected

[Matthew Paul Thomas]

indicator-sound 0.1.1-0ubuntu2, Ubuntu Lucid
libido-0.1-0 0.1.11-0ubuntu2, indicator-sound 0.4.0-0ubuntu1, Ubuntu Maverick

1. Open the sound menu, without any music players running.
2. Press the Down key.
3. Press the Down key.
4. Press the Down key.

What should happen:
2. The "Mute All" item is highlighted.
3. The volume item is highlighted.
4. The "Sound Preferences…" item is highlighted.

What actually happens:
3. The volume item is not highlighted.

<https://wiki.ubuntu.com/SoundMenu#Volume%20item>: "The item should highlight when navigated to, or on mouseover, just as normal menu items do".

Mockup: <https://launchpadlibrarian.net/89751824/Sound%20menu%20highlighting.gif>

[Conor Curran (cjcurran)]

Noted, next version of IDO should support this.

[frizzle21 (frederik-nnaji)]

https://wiki.ubuntu.com/SoundMenu#Output%20volume%20item says:
"The item should highlight when navigated to, or on mouseover, just as normal menu items do, but the item should not be activatable (clicking it or pressing Enter should not close the menu)"

ok. The playback controls are the second example of horizontally arranged menu items / controls. For the playback controls, the spec says:
"When using the keyboard, the Play/Pause button alone should highlight in the same way. Pressing the Space key should visibly activate the Play/Pause button, and the Left and Right keys should visibly activate the Previous and Next buttons respectively."

wouldn't it be consistent to do the same thing with the volume item?
i.e. to "visibly activate" the Volume_To_Zero button upon CTRL+LEFT and the Volume_To_Max button upon CTRL+RIGHT?

This would mean that ONLY the fader would receive visible focus when navigated to or on hover..
Wouldn't that be easier also?

[Matthew Paul Thomas (mpt)]

That's not relevant to this bug. The buttons should appear pressed when their keyboard combos are invoked, but that should be reported as a separate bug.

[frizzle21 (frederik-nnaji)]

I still don't understand the bug description completely then:
which items should be highlighted exactly when navigated to via "down && down"?
the entire row with its 3 objects or only the slider?

[Matthew Paul Thomas (mpt)]

The entire row. That shows which item will respond to keypresses, for example.

[Mark Shuttleworth (sabdfl)]

I disagree: in the case of the volume slider, the thing which should be
highlighted is the grippy, since *that's* what will react to the left or
right keystrokes. In the case of the play/pause/next/previous row, it's
the play/pause button which should be highlighted. A left or right
stroke should *flash* the previous/next button, returning the highlight
to the central button immediately.

Mark

[Alberto Ruiz (alberto.ruiz)]

Depending on which area we should highlight this bug is going to have different fixes.

Note however that if we only want to highlight the grip, things are slightly easier. If we want to highlight the whole row, the fix is going to be a bit harder, since we are using offscreen windows here and they can't be painted transparent yet. Gtk+ has a fix for this on master but we won't be able to take advantage of that until 3.4 is out.

So, should I take Mark's comment as a final word or is this issue still being discussed?

[Andrea Cimitan (cimi)]

can't you just use paint/render focus?