Ubuntu
icon-slicer package

Hotspot ignores y-coordinates.

Bug #339044 reported by Tim Swast
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
icon-slicer (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: icon-slicer

When creating a cursor file, say I have a hotspot.png file with one non-transparent pixel at (10, 1). Ten being the x-coordinate, one being the y-coordinate. The cursor file output by icon-slicer ends up with a hotspot at coordinates (10, 10). This is obviously the incorrect coordinate (Though I may just be uninformed about some limitation in the cursor file type).

As this is the only command line tool I could find in recent repositories for creating cursor files, it would be nice if this program worked correctly.

Related branches

lp:ubuntu/karmic/icon-slicer
Revision history for this message
Tim Swast (tswast) wrote :

I modified main.c and the theme_source_location_bounds now gives the correct values for me. I'm not sure how I would diff it, so I'm attaching the whole file.

The line numbers that I changed are 106, 140, 141 in main.c

Revision history for this message
Tim Swast (tswast) wrote :

So, I followed some instructions and have come up with a better patch which represents the fix for this bug.

Revision history for this message
Tim Swast (tswast) wrote :
Revision history for this message
Daniel Holbach (dholbach) wrote :

Can you attach a patch for jaunty too?

https://wiki.ubuntu.com/StableReleaseUpdates is the procedure for getting it fixed in existing releases.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Unsubscribing Ubuntu Sponsors for universe from this bug for now.

Revision history for this message
Kjell Braden (afflux) wrote :

resubscribed u-u-s, the source package hasn't changed since hardy.

Revision history for this message
Iain Lane (laney) wrote :

Uploaded with a few changes for reference. Thanks for your work. ScottK gave his ACK on IRC.

Version should be 0.3-1ubuntu3. The number immediately preceding "ubuntu" is only to be incremented by Debian uploads.

Don't introduce a patch system for packages inherited from Debian.

Don't change standards-version. These are a Debianism.

I also made the changelog a little bit more verbose (helps to explain what the fixed problem is).

Changed in icon-slicer (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package icon-slicer - 0.3-1ubuntu3

---------------
icon-slicer (0.3-1ubuntu3) jaunty; urgency=low

  * Bug fix for creating cursors using a separate hotspot
    image file. Fixes issue where hotspot was created in the wrong place.
    (LP: #339044)

 -- Tim Swast <email address hidden> Thur, 12 Mar 2009 23:16:00 -0500

Changed in icon-slicer (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.