Ubuntu
humanity-icon-theme package

  1. Bug #466567
  2. Comment #37

Comment 37 for bug 466567

Revision history for this message
In , Mozilla (mozilla) wrote :

(In reply to comment #20)
> (In reply to comment #19)
> > (From update of attachment 418531 [details] [details])
> > >+#if GTK_CHECK_VERSION(2,4,0)
> >
> > Why do we need such a check here at all? configure.in has GTK2_VERSION=2.10.0
> > as the minimum version.
>
> There are a couple of such checks in already. I didn't know if the configure
> check is considered enough, so I did stick with the code style already there
> and added one such check myself.

IMO the check could make sense still. The reasons for requiring 2.10 are for example the new print dialog. In case someone wants to ship anything based on mozilla and don't need that it's still better to have checks for the other (older) stuff. But that's only my opinion.