[Patch] hp-fab crashes when importing adress book

Bug #1914743 reported by zdohnal on 2021-02-05
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HPLIP
Undecided
Unassigned
hplip (Fedora)
Unknown
Unknown
hplip (Ubuntu)
Undecided
Unassigned

Bug Description

Hi,

we have a following report in Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=1919556) , where hp-fab crashes if you try to import an address book as from file.

The reason of the crash is following:

The function used for opening a file, getOpenFileName(), returns a tuple, where the first member is an absolute path to the chosen file, and another member is the filter used in getOpenFileName() call. The current hp-fab code doesn't take this into account and puts whole tuple into str(), which makes the string from whole tuple. Using this 'string' further results into traceback.

The attached patch fixes it, would you mind adding it to the project?

Revision history for this message
zdohnal (zdohnal) wrote :
Revision history for this message
zdohnal (zdohnal) wrote :

I tested hp-fab in Ubuntu 20.05 and it crashes too.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Proposed patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.