move systemd bits from 56-hpmud_sysfs.rules to 56-hpmud.rules

Bug #1479431 reported by Jiri Popelka
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HPLIP
Invalid
Undecided
Unassigned
hplip (Ubuntu)
Invalid
Undecided
Till Kamppeter

Bug Description

Prior to 3.15.6 both 56-hpmud_sysfs.rules & 56-hpmud.rules contained
if [ -f /usr/bin/systemctl ]; then /usr/bin/systemctl --no-block start hplip-printer@$env{BUSNUM}:$env{DEVNUM}.service

With 3.15.6 this has been removed from 56-hpmud.rules, but still remains in 56-hpmud_sysfs.rules.
AFAICT 56-hpmud_sysfs.rules, which uses deprecated SYSFS instread of ATTR, exists only for older distributions like RHEL5, where there's no systemd. So IMHO it should have been removed from 56-hpmud_sysfs.rules, not from 56-hpmud.rules.

Related:
You might also consider using "TAG+="systemd", ENV{SYSTEMD_WANTS}=..." instread of RUN+=""
see:
http://jasonwryan.com/blog/2014/01/20/udev/
http://blog.fraggod.net/2012/06/16/proper-ish-way-to-start-long-running-systemd-service-on-udev-event-device-hotplug.html
man systemd.device

With regards,
--
Jiri

Revision history for this message
Sanjay Kumar (sanjay-kumar14) wrote :

Hello Jiri,

systemctl syntax was intentionally removed from 56-hpmud.rules, because RUN+= syntax is good enough to execute "hp-config_usb_printer" script(It does not take more time to run and does not create any daemon) . Regarding 56-hpmud-sysfs.rules, we should have removed systemctl syntax from this file as well but somehow missed it. Please let me know if you see any issues in 56-hpmud.rules.

affects: hplip → hplip (Ubuntu)
Changed in hplip (Ubuntu):
assignee: nobody → Till Kamppeter (till-kamppeter)
Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

Seb, this is still an upstream issue as it is reported by a Red Hat developer and worked on by the upstream developers at HP. So do not replace the upstream task by a task for the Ubuntu package, but if you want to make me as the Ubuntu maintainer of HPLIP aware of the bug, simply add the Ubuntu package task.

Re-added upstream task.

Seb, did you perceive any breaking effect by this in Wily? Is the problem release-critical? Or can we simply wait for the upstream developers to fix it (and then have the fix in 16.04)?

Revision history for this message
gf (gf-interlinks-deactivatedaccount) wrote :

Hello Jiri,
Thank you for submitting this bug and reporting a problem with hplip. You made this bug report some time ago and Ubuntu and hplip have been updated since then.

Could you confirm that this is no longer a problem and that we can close the ticket?
If it is still a problem, are you still interested in finding a solution to this bug?
If you are, could you let us know and, in the current version, could you run the following (only once):
apport-collect 1479431
and upload the updated logs and and any other logs that are relevant for this particular issue.

Thank you again for helping make Ubuntu and hplip better.
G
[Ubuntu Bug Squad volunteer triager]

Changed in hplip:
status: New → Incomplete
Changed in hplip (Ubuntu):
status: New → Incomplete
Revision history for this message
Jiri Popelka (jpopelka) wrote :

Hello,

I'm not interested in this any more, so feel free to close this.

Revision history for this message
gf (gf-interlinks-deactivatedaccount) wrote :

Thanks for the update, Jiri. I will close the report now.
Have a great day!
:)
G

Closed per reporter’s feedback.

Changed in hplip:
status: Incomplete → Invalid
Changed in hplip (Ubuntu):
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.