[mitaka] Hide nova lock/unlock if nova api <2.9 and when >= 2.9, "Lock/Unlock Instance" should not be shown at same time.

Bug #1725421 reported by Jill Rouleau on 2017-10-20
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Cloud Archive
Undecided
Unassigned
Mitaka
Medium
Unassigned
horizon (Ubuntu)
Undecided
Unassigned
Xenial
Medium
Shane Peters

Bug Description

[Impact]

* Similar/related to lp:1505845, which was fixed for Newton.
  Lock/unlock options are displayed in Horizon despite Nova API <2.9,
  which causes user confusion.
* Additionally, when Nova API is >= 2.9, the actions "Lock Instance"
  and "Unlock Instance" should not be shown at the same time.

[Test Case]

case 1:
  1. Deploy nova and horizon both at mitaka level.
  2. Log into Horizon dashboard.
  3. Create new instance.
  4. Wait for instance to switch to 'running' state.
  5. On the newly created instance, under Actions, you'll
     see both 'Lock Instance' and 'Unlock Instance' are
     available, even after locking the instance.

case 2:
  1. Deploy nova at kilo level and horizon at mitaka level (test with Nova API < 2.9)
  2. Log into Horizon dashboard.
  3. Create new instance.
  4. Wait for instance to switch to 'running' state.
  5. On the newly created instance, under Actions, you'll
     'Lock Instance' and 'Unlock Instance' should be hidden.

[Regression Potential]

* Regression potential is low. This bug has been fixed in all releases of
  OpenStack starting with Newton. The patch did have to be modified
  slightly to apply to mitaka.

[Discussion]

James Page (james-page) wrote :

Mitaka should support v2.25 of the Nova API?

James Page (james-page) wrote :

Or do we just need to backport the fix for horizon to query the lock status and provide the toggle option as required?

James Page (james-page) wrote :

On the assumption that we need to fix horizon (rather than the charm), moving the target to Ubuntu/Horizon.

affects: charm-openstack-dashboard → horizon (Ubuntu)
Changed in horizon (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Shane Peters (shaner) on 2017-10-30
Changed in horizon (Ubuntu):
assignee: nobody → Shane Peters (shaner)
Shane Peters (shaner) wrote :
Changed in horizon (Ubuntu):
status: Triaged → In Progress
Shane Peters (shaner) on 2017-12-11
Changed in horizon (Ubuntu):
milestone: none → xenial-updates

The attachment "fix_1725421.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Changed in cloud-archive:
importance: Undecided → Medium
tags: added: sts
Shane Peters (shaner) on 2018-01-04
description: updated
Shane Peters (shaner) on 2018-01-05
description: updated
Corey Bryant (corey.bryant) wrote :

I've updated the bug description and title as it was discussing 2 different scenarios.

description: updated
summary: - [mitaka] Nova lock/unlock should be hidden if nova api <2.9
+ [mitaka] Hide nova lock/unlock if nova api <2.9 and when >= 2.9,
+ "Lock/Unlock Instance" should not be shown at same time.
Changed in horizon (Ubuntu):
status: In Progress → Invalid
Changed in cloud-archive:
status: New → Invalid
Changed in horizon (Ubuntu Xenial):
status: New → Triaged
importance: Undecided → Medium
Changed in horizon (Ubuntu):
importance: Medium → Undecided
Changed in cloud-archive:
importance: Medium → Undecided
Changed in horizon (Ubuntu Xenial):
assignee: nobody → Shane Peters (shaner)
Changed in horizon (Ubuntu):
assignee: Shane Peters (shaner) → nobody
Corey Bryant (corey.bryant) wrote :

Shane, thanks for the patch. I have the package ready to upload. I'm combining it into 2:9.1.2-0ubuntu4 with the fix for LP: #1613900, which hasn't been accepted into proposed yet (meltdown/spectre are blocking LP builders). I've requested the current upload of 2:9.1.2-0ubuntu4 to be rejected and will then upload the same version with both bugs fixed in one version.

Corey Bryant (corey.bryant) wrote :

Updated horizon 2:9.1.2-0ubuntu4 is now in the unapproved queue awaiting SRU review.

Hello Jill, or anyone else affected,

Accepted horizon into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/horizon/2:9.1.2-0ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in horizon (Ubuntu Xenial):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-xenial
Corey Bryant (corey.bryant) wrote :

Hello Jill, or anyone else affected,

Accepted horizon into mitaka-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:mitaka-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-mitaka-needed to verification-mitaka-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-mitaka-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-mitaka-needed
Brian Murray (brian-murray) wrote :

Unsubscribing ubuntu-sponsors since it looks like no additional sponsoring is required.

tags: added: sts-sru-needed
Brian Murray (brian-murray) wrote :

Could somebody test this? Its blocking another SRU of horizon for Ubuntu 16.04.

Shane Peters (shaner) wrote :

Currently working on verification. I'm running into an issue where the (mitaka) nova-api isn't returning the 'locked' field which this patch relies on.

Corey Bryant (corey.bryant) wrote :

Hi Shane, if this isn't working we need to reject it as we have other fixes queued up that need to get into proposed for testing.

Corey Bryant (corey.bryant) wrote :

I chatted with Shane and he agreed we'd tag this as verification-failed so that we can unblock other SRUs. Once there is a new fix for this we can upload it after the currently blocked SRUs.

tags: added: verification-failed-xenial verification-mitaka-failed
removed: verification-mitaka-needed verification-needed-xenial
Edward Hope-Morley (hopem) wrote :

for ref: sru cancelled

Changed in horizon (Ubuntu Xenial):
status: Fix Committed → Invalid
tags: removed: sts-sru-needed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers