Please merge hdparm 9.15-1 (main) from Debian unstable

Bug #311451 reported by Shirish Agarwal
6
Affects Status Importance Assigned to Milestone
hdparm (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

hdparm (9.12-2) unstable; urgency=low

  * Use correct header for O_DIRECT (closes: #519747)

 -- Stephen Gran <email address hidden> Sun, 15 Mar 2009 10:59:20 +0000

hdparm (9.12-1) unstable; urgency=low

  * New upstream version (closes: #505284)

 -- Stephen Gran <email address hidden> Sat, 07 Mar 2009 17:48:59 +0000

======= Original Report =======

Binary package hint: hdparm

upstream released two new releases.

hdparm 9.3 and hdparm 9.6

http://freshmeat.net/projects/hdparm/?branch_id=4062&release_id=288158

release notes of 9.3

Release focus: Minor feature enhancements

Changes:
Support for Device Configuration Overlay was added, with the new flags "--dco-freeze", "--dco-identify", and "--dco-restore". A firmware download capability was implemented. Supposedly obsolete "cache/buffer size" reporting was added to "-I". New "--idle-immediate" and "--idle-unload" flags were implemented. Kernel bugs associated with "-N" are now detected and reported

Release notes of 9.6

http://freshmeat.net/projects/hdparm/?branch_id=4062&release_id=290822

Release focus: Minor bugfixes

Changes:
Several minor enhancements were made. The -N flag was fixed for 1.5 TB drives.

ProblemType: Bug
Architecture: i386
Dependencies:
 libgcc1 1:4.3.2-1ubuntu11
 gcc-4.3-base 4.3.2-1ubuntu11
 findutils 4.4.0-2ubuntu3
 libc6 2.8~20080505-0ubuntu7
DistroRelease: Ubuntu 8.10
Package: hdparm 8.9-1ubuntu1
ProcEnviron:
 SHELL=/bin/bash
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
 LANG=en_IN
SourcePackage: hdparm
Uname: Linux 2.6.27-9-generic i686

Tags: apport-bug

Related branches

Changed in hdparm:
importance: Undecided → Wishlist
Michael Terry (mterry)
summary: - update hdparm to 9.6
+ Please merge hdparm 9.12-2 (universe) from Debian unstable
description: updated
Changed in hdparm (Ubuntu):
assignee: nobody → Michael Terry (mterry)
status: New → In Progress
Revision history for this message
Michael Terry (mterry) wrote : Re: Please merge hdparm 9.12-2 (universe) from Debian unstable
Revision history for this message
Michael Terry (mterry) wrote :

Only debian/ changes.

Changed in hdparm (Ubuntu):
assignee: Michael Terry (mterry) → nobody
status: In Progress → Confirmed
summary: - Please merge hdparm 9.12-2 (universe) from Debian unstable
+ Please merge hdparm 9.12-2 (main) from Debian unstable
Revision history for this message
Martin Pitt (pitti) wrote : Re: Please merge hdparm 9.12-2 (main) from Debian unstable

Thanks, Michael. Some remarks:

 - debian/hdparm.{pre,post}inst changes are cleanup before/in hardy and thus can be dropped
 - the changed build-depends versions don't seem to serve a real purpose, can we drop them to lower our delta? In particular, depending on debhelper >= 7 doesn't make a difference if debian/compat remains at 5.
 - Homepage: addition can be forwarded to Debian
 - The udev rules changes should go to Debian; Debian has a current udev as well now, and also uses /lib/udev/rules.d/ now.

I know that you aren't responsible for introducing these deltas, but when we merge packages, we should be agressive about sending applicable changes to Debian and drop old cruft, so that the package delta stays meaningful and minimal. Thank you!

Changed in hdparm (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Michael Terry (mterry) wrote :

Here's an updated debdiff. I did very little of what you asked, though Martin. :)

Basically, I just dropped the preinst and postinst changes. We don't care about pre-hardy changes because they'd be end-of-life or we don't care because people have to upgrade releases incrementally and Karmic is >1 upgrade from Fiesty?

As for the debhelper change, that went in because dh_installudev was modified in Ubuntu to install into /usr/lib/rules.d. So Scott (who bumped the dependencies) didn't care about the compat version; he just wanted a fixed dh_installudev change. He also fixed the cdbs dependency to take into account Ubuntu versions of cdbs while he was there.

The udev changes can't go into Debian (as-is) until the aforementioned dh_installudev changes go in. See the discussion (in which you are involved) in Debian bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=491117.

As for Homepage, sure. Debian report here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533190

Changed in hdparm (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Martin Pitt (pitti) wrote :

> We don't care about pre-hardy changes because they'd be end-of-life or we don't care because people have to upgrade releases incrementally and Karmic is >1 upgrade from Fiesty?

More generally, we don't support upgrades which skip releases, except for LTS -> LTS. Thus, in order to upgrade from gutsy to anything, you first _must_ upgrade to karmic. Thus it is sufficient to only keep transition code until the next LTS.

> As for the debhelper change, that went in because dh_installudev was modified in Ubuntu to install into /usr/lib/rules.d.

Ah, indeed, I remember; sorry for the noise. So, while udev itself in Debian is up to date now, dh_installudev still does the wrong thing in Debian :-(

Revision history for this message
Martin Pitt (pitti) wrote :

The actual init script -> udev script changes can go to Debian, though.

summary: - Please merge hdparm 9.12-2 (main) from Debian unstable
+ Please merge hdparm 9.15-1 (main) from Debian unstable
Revision history for this message
Martin Pitt (pitti) wrote :

In the meantime, Debian got a new version, can you please update the merge?

Changed in hdparm (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Michael Terry (mterry) wrote :

OK, here's a debdiff for 9.15-1. Oddly, the Debian changelog has erased all mention of 9.12. I'll shortly submit a patch for the init->udev change to Debian.

Changed in hdparm (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Michael Terry (mterry) wrote :

oops, one more change i have to make

Changed in hdparm (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Michael Terry (mterry) wrote :

There. Debian somehow duplicated all their install rules, so I have to remove the install line for the .rules file twice. Should be correct now.

Changed in hdparm (Ubuntu):
status: In Progress → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hdparm - 9.15-1ubuntu1

---------------
hdparm (9.15-1ubuntu1) karmic; urgency=low

  * Merge from debian unstable (LP: #311451), remaining changes:
    + debian/control:
      - Do not depend on lsb-base (we no longer use init script)
      - Add Homepage
      - Add Breaks on old udev
      - Bump debhelper depends for dh_installudev changes
    + debian/hdparm.install, debian/hpdarm.udev:
      - Use hpdarm.udev instead of .rules
    + debian/hpdarm.dirs:
      - Drop unused /etc/udev/rules.d, add lib/udev for our udev-script
    + debian/rules, debian/hdparm.udev-script:
      - Install udev-script, drop init file stuff
      - Pass --priority=85 to dh_installudev

hdparm (9.15-1) unstable; urgency=low

  * New upstream version (closes: #505284)
  * opens devices with O_RDONLY (closes: #522091, #526516)

 -- Michael Terry <email address hidden> Mon, 15 Jun 2009 09:44:02 -0400

Changed in hdparm (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.