Fails to build due to compilation without -fPIC or PIC linking only on amd64

[Luís Infante da Câmara]

haskell-devscripts or GHC invokes non-PIC compilation followed by PIC linking, leading to linker errors on amd64 and armhf in the other packages listed in this bug. This is blocking the pandoc source package from migrating to the release pocket (bug #1982460).

For example, haskell-diff fails to build in kinetic-proposed only on amd64, with the following error (https://launchpad.net/ubuntu/+source/haskell-diff/0.4.1-1/+build/23854045):

/usr/bin/ld.gold: error: dist-ghc/build/Data/Algorithm/Diff.dyn_o: requires dynamic R_X86_64_PC32 reloc against 'Diffzm0zi4zi1zm1zzL3fycaRHO4aduijwvx7f_DataziAlgorithmziDiff_Both_con_info' which may overflow at runtime; recompile with -fPIC
/usr/bin/ld.gold: error: dist-ghc/build/Data/Algorithm/DiffOutput.dyn_o: requires dynamic R_X86_64_PC32 reloc against 'Diffzm0zi4zi1zm1zzL3fycaRHO4aduijwvx7f_DataziAlgorithmziDiffOutput_LineRange_con_info' which may overflow at runtime; recompile with -fPIC
/usr/bin/ld.gold: error: dist-ghc/build/Data/Algorithm/DiffContext.dyn_o: requires dynamic R_X86_64_PC32 reloc against 'Diffzm0zi4zi1zm1zzL3fycaRHO4aduijwvx7f_DataziAlgorithmziDiffContext_prettyContextDiff_closure' which may overflow at runtime; recompile with -fPIC
collect2: error: ld returned 1 exit status

[Gianfranco Costamagna (costamagnagianfranco)]

Hello, I uploaded in my ppa a haskell-devtools with hlibrary.mk patched this way

export DEB_LDFLAGS_MAINT_STRIP=-Wl,-Bsymbolic-functions

and now everything looks good again (except for some haskell libraries needing lto disabled too)
https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/+build/24188956

What is your proposed solution? enable PIC in devtools?

[Luís Infante da Câmara (luis220413)]

My proposed solution is to enable -fPIC in haskell-devscripts, to enhance security of Haskell code.

[Gianfranco Costamagna (costamagnagianfranco)]

Hello Luis, do you have a patch for this? All my attempts failed...

[Steve Langasek (vorlon)]

As no patch has been forthcoming to fix this to use -fPIC, I have uploaded Gianfranco's patch to disable -Wl,-Bsymbolic-functions so that we can move the haskell transition forward for kinetic.

[Launchpad Janitor (janitor)]

This bug was fixed in the package haskell-devscripts - 0.16.27ubuntu1

---------------
haskell-devscripts (0.16.27ubuntu1) kinetic; urgency=medium

  * Disable -Wl,-Bsymbolic-functions to fix broken builds, thanks
    to Gianfranco Costamagna. LP: #1982554.

 -- Steve Langasek <email address hidden> Mon, 22 Aug 2022 21:38:12 +0000

[Luís Infante da Câmara (luis220413)]

Steve Langasek is doing the necessary rebuilds.