| 2014-07-22 23:16:46 |
Chris Coulson |
bug |
|
|
added bug |
| 2014-07-25 00:02:13 |
Steve Beattie |
attachment added |
|
hardening-wrapper_2.5ubuntu3.debdiff https://bugs.launchpad.net/ubuntu/+source/hardening-wrapper/+bug/1347257/+attachment/4162387/+files/hardening-wrapper_2.5ubuntu3.debdiff |
|
| 2014-07-25 00:24:13 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2014-07-25 00:24:20 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2014-08-01 08:08:39 |
Martin Pitt |
hardening-wrapper (Ubuntu): status |
New |
Fix Committed |
|
| 2014-08-01 08:28:00 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/utopic-proposed/hardening-wrapper |
|
| 2014-08-01 10:07:40 |
Launchpad Janitor |
hardening-wrapper (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2014-10-07 14:39:36 |
Matthias Klose |
nominated for series |
|
Ubuntu Trusty |
|
| 2014-10-07 14:39:36 |
Matthias Klose |
bug task added |
|
hardening-wrapper (Ubuntu Trusty) |
|
| 2014-10-09 13:49:33 |
Matthias Klose |
description |
Firefox currently fails to build in utopic with the following error:
c++ -o hexdump.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /build/buildd/firefox-32.0~b1+build1/config/gcc_hidden.h -DANDROID_SMP=0 -DLOG_NDEBUG=0 -D_GLIBCXX_OS_DEFINES -DHAVE_SYS_UIO_H -DFAKE_LOG_DEVICE -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright -I. -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/binding/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/ -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/empty -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/system/core/include -I../../dist/include -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nspr -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nss -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include -I/build/buildd/firefox-32.0~b1+build1/modules/zlib/src -fPIC -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/hexdump.o.pp -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -g -Os -freorder-blocks -fomit-frame-pointer -Wno-format -Wno-multichar -Wno-sign-compare -Wno-unused /build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/foundation/hexdump.cpp
cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
cc1plus: some warnings being treated as errors
/build/buildd/firefox-32.0~b1+build1/config/rules.mk:1001: recipe for target 'hexdump.o' failed
make[6]: *** [hexdump.o] Error 1
https://launchpadlibrarian.net/180524763/buildlog_ubuntu-utopic-amd64.firefox_32.0~b1%2Bbuild1-0ubuntu1_FAILEDTOBUILD.txt.gz
Firefox is built with hardening-wrapper (including the format string hardening), but it specifies -Wno-format just for the code in this subdirectory - presumably because this is a third-party module |
Proposing to backport this unchanged to trusty. The patch is attached below in a comment. Verified that the additional parameters are not added.
Firefox currently fails to build in utopic with the following error:
c++ -o hexdump.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /build/buildd/firefox-32.0~b1+build1/config/gcc_hidden.h -DANDROID_SMP=0 -DLOG_NDEBUG=0 -D_GLIBCXX_OS_DEFINES -DHAVE_SYS_UIO_H -DFAKE_LOG_DEVICE -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright -I. -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/binding/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/ -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/empty -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/system/core/include -I../../dist/include -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nspr -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nss -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include -I/build/buildd/firefox-32.0~b1+build1/modules/zlib/src -fPIC -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/hexdump.o.pp -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -g -Os -freorder-blocks -fomit-frame-pointer -Wno-format -Wno-multichar -Wno-sign-compare -Wno-unused /build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/foundation/hexdump.cpp
cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
cc1plus: some warnings being treated as errors
/build/buildd/firefox-32.0~b1+build1/config/rules.mk:1001: recipe for target 'hexdump.o' failed
make[6]: *** [hexdump.o] Error 1
https://launchpadlibrarian.net/180524763/buildlog_ubuntu-utopic-amd64.firefox_32.0~b1%2Bbuild1-0ubuntu1_FAILEDTOBUILD.txt.gz
Firefox is built with hardening-wrapper (including the format string hardening), but it specifies -Wno-format just for the code in this subdirectory - presumably because this is a third-party module |
|
| 2014-10-09 13:50:27 |
Matthias Klose |
attachment added |
|
backport for trusty https://bugs.launchpad.net/ubuntu/+source/hardening-wrapper/+bug/1347257/+attachment/4229597/+files/hw.debdiff |
|
| 2014-10-09 13:50:40 |
Matthias Klose |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2014-10-09 13:52:48 |
Matthias Klose |
bug |
|
|
added subscriber Matthias Klose |
| 2014-10-10 14:35:28 |
Sebastien Bacher |
hardening-wrapper (Ubuntu Trusty): status |
New |
Fix Committed |
|
| 2014-10-10 14:35:30 |
Sebastien Bacher |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2014-10-20 19:08:44 |
Chris J Arges |
description |
Proposing to backport this unchanged to trusty. The patch is attached below in a comment. Verified that the additional parameters are not added.
Firefox currently fails to build in utopic with the following error:
c++ -o hexdump.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /build/buildd/firefox-32.0~b1+build1/config/gcc_hidden.h -DANDROID_SMP=0 -DLOG_NDEBUG=0 -D_GLIBCXX_OS_DEFINES -DHAVE_SYS_UIO_H -DFAKE_LOG_DEVICE -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright -I. -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/binding/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/ -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/empty -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/system/core/include -I../../dist/include -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nspr -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nss -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include -I/build/buildd/firefox-32.0~b1+build1/modules/zlib/src -fPIC -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/hexdump.o.pp -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -g -Os -freorder-blocks -fomit-frame-pointer -Wno-format -Wno-multichar -Wno-sign-compare -Wno-unused /build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/foundation/hexdump.cpp
cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
cc1plus: some warnings being treated as errors
/build/buildd/firefox-32.0~b1+build1/config/rules.mk:1001: recipe for target 'hexdump.o' failed
make[6]: *** [hexdump.o] Error 1
https://launchpadlibrarian.net/180524763/buildlog_ubuntu-utopic-amd64.firefox_32.0~b1%2Bbuild1-0ubuntu1_FAILEDTOBUILD.txt.gz
Firefox is built with hardening-wrapper (including the format string hardening), but it specifies -Wno-format just for the code in this subdirectory - presumably because this is a third-party module |
SRU Justification:
[Impact]
Some builds may fail because of the way hardening-wrapper adds flags to compilers.
[Test Case]
Try to compile firefox with hardening-wrapper installed.
[Regression Potential]
This changes the perl script to check if these options already exists so it doesn't read add them.
--
Proposing to backport this unchanged to trusty. The patch is attached below in a comment. Verified that the additional parameters are not added.
Firefox currently fails to build in utopic with the following error:
c++ -o hexdump.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /build/buildd/firefox-32.0~b1+build1/config/gcc_hidden.h -DANDROID_SMP=0 -DLOG_NDEBUG=0 -D_GLIBCXX_OS_DEFINES -DHAVE_SYS_UIO_H -DFAKE_LOG_DEVICE -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright -I. -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/binding/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/ -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/empty -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/system/core/include -I../../dist/include -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nspr -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nss -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include -I/build/buildd/firefox-32.0~b1+build1/modules/zlib/src -fPIC -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/hexdump.o.pp -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -g -Os -freorder-blocks -fomit-frame-pointer -Wno-format -Wno-multichar -Wno-sign-compare -Wno-unused /build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/foundation/hexdump.cpp
cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
cc1plus: some warnings being treated as errors
/build/buildd/firefox-32.0~b1+build1/config/rules.mk:1001: recipe for target 'hexdump.o' failed
make[6]: *** [hexdump.o] Error 1
https://launchpadlibrarian.net/180524763/buildlog_ubuntu-utopic-amd64.firefox_32.0~b1%2Bbuild1-0ubuntu1_FAILEDTOBUILD.txt.gz
Firefox is built with hardening-wrapper (including the format string hardening), but it specifies -Wno-format just for the code in this subdirectory - presumably because this is a third-party module |
|
| 2014-10-20 19:08:55 |
Chris J Arges |
bug |
|
|
added subscriber SRU Verification |
| 2014-10-20 19:08:57 |
Chris J Arges |
tags |
patch |
patch verification-needed |
|
| 2014-10-20 19:49:21 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/trusty-proposed/hardening-wrapper |
|
| 2014-10-21 13:45:07 |
Matthias Klose |
tags |
patch verification-needed |
patch verification-done |
|
| 2014-10-28 13:39:56 |
Launchpad Janitor |
hardening-wrapper (Ubuntu Trusty): status |
Fix Committed |
Fix Released |
|
| 2014-10-28 13:40:04 |
Chris J Arges |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2015-05-26 03:28:35 |
Launchpad Janitor |
branch linked |
|
lp:~ubuntu-branches/ubuntu/precise/hardening-wrapper/precise-security |
|
