Improvement: initscript enhancement with support for conf.d and configtest on startup

[born2chill]

The haproxy initscript misses a configtest option, which haproxy natively supports. It also does not warn the user, if haproxy has been disabled in the default file, but exits silently.
Also, it has become a de-facto standard for daemons to include conf.d configuration file support.
I attached a patch for the current init script, which remedies all these issues and should be forward/backward compatible to haproxy 1.3/1.4/1.5.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "patch for current haproxy init.d script" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Robie Basak (racb)]

Thank you for taking the time to report this bug and helping to make Ubuntu better.

haproxy in Ubuntu is currently identical to the Debian haproxy package from which it is derived, so it seems likely to me that Debian will benefit from this patch, too. I would also like to avoid the additional maintenance burden of forking Debian's packaging if possible, and this is better community etiquette anyway.

Please could you verify if this patch is suitable for Debian also, and if so, forward it to the Debian bug tracker? Then Ubuntu will automatically sync the patch after it is uploaded to Debian.

[Robie Basak (racb)]

Also, I didn't check if the init.d script is provided by packaging or comes directly from upstream. If it comes directly from upstream, then sending the patch upstream directly would be best.

[born2chill (david-gabriel)]

I filed a bug with debian, perhaps it will get included in one of the next releases:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=750459

[Robie Basak (racb)]

Thanks!

[Robie Basak (racb)]

Following Debian as I don't think it's appropriate for Ubuntu to diverge from Debian on this point. We'll follow whatever Debian does.