Ubuntu

gwibber-accounts crashed with UnicodeEncodeError in on_facebook_auth_title_change(): 'ascii' codec can't encode characters in position 0-7: ordinal not in range(128)

Reported by Vmaximoff on 2012-02-22
56
This bug affects 10 people
Affects Status Importance Assigned to Milestone
gwibber (Ubuntu)
High
Guillermo Martínez
Precise
High
Unassigned

Bug Description

Impact:

setting up account with non ascii chars fails

Test Case:

- create a facebook account with a "Š" in your name and try to set it up in gwibber

Regression potential:

account names could be incorrectly encoded

Vmaximoff (vemaximoff) wrote :
tags: removed: need-duplicate-check
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gwibber (Ubuntu):
status: New → Confirmed
visibility: private → public
Changed in gwibber (Ubuntu):
assignee: nobody → Ken VanDine (ken-vandine)
importance: Undecided → High
status: Confirmed → In Progress
Changed in gwibber (Ubuntu Precise):
importance: Undecided → High
status: New → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gwibber - 3.4.1-0ubuntu3

---------------
gwibber (3.4.1-0ubuntu3) quantal; urgency=low

  * debian/patches/lp_38667.patch
    - facebook: Don't crash on unicode characters in a username (LP: #938667)
 -- Ken VanDine <email address hidden> Thu, 17 May 2012 17:11:26 -0400

Changed in gwibber (Ubuntu):
status: In Progress → Fix Released
Changed in gwibber (Ubuntu Precise):
status: In Progress → Confirmed
Changed in gwibber (Ubuntu):
assignee: Ken VanDine (ken-vandine) → nobody
Sebastien Bacher (seb128) wrote :

setting to fix commited, the SRU is in the unapproved queue

Changed in gwibber (Ubuntu Precise):
status: Confirmed → Fix Committed
Chris Halse Rogers (raof) wrote :

Hi! One of the results of our SRU discussions at UDS was that we're planning to get

Chris Halse Rogers (raof) wrote :

Urgh. Whoops!

One of the results of our SRU discussions at UDS about how to reduce the large backlog of abandoned SRUs awaiting testing was that we're planning to get stricter on accepting SRUs into proposed. Specifically, they should have _at least_ a test case so that someone can easily verify the fix and a description of what aspects of the application are most likely to show regressions if they exist.

Thanks,
Your friendly neighbourhood SRU team.

tags: added: verification-needed

Hello Vmaximoff, or anyone else affected,

Accepted gwibber into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Sebastien Bacher (seb128) wrote :

Could you test the candidate update to confirm if it's working so it can get out of staging?

Štefan Baebler (stefanba) wrote :

after preparing package sources as defined in https://wiki.ubuntu.com/Testing/EnableProposed :
stefan@***:~$ sudo aptitude remove gwibber
The following packages will be REMOVED:
  gwibber
0 packages upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
Need to get 0 B of archives. After unpacking 809 kB will be freed.
(Reading database ... 268833 files and directories currently installed.)
Removing gwibber ...
Processing triggers for hicolor-icon-theme ...
Processing triggers for desktop-file-utils ...
Processing triggers for gnome-menus ...
Processing triggers for bamfdaemon ...
Rebuilding /usr/share/applications/bamf.index...

stefan@***:~$ sudo aptitude install gwibber/precise-proposed
Unable to find an archive "precise-proposed" for the package "gwibber"
Unable to find an archive "precise-proposed" for the package "gwibber"
The following NEW packages will be installed:
  gwibber
0 packages upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/156 kB of archives. After unpacking 809 kB will be used.
Selecting previously unselected package gwibber.
(Reading database ... 268741 files and directories currently installed.)
Unpacking gwibber (from .../gwibber_3.4.1-0ubuntu1_i386.deb) ...
Processing triggers for desktop-file-utils ...
Processing triggers for gnome-menus ...
Processing triggers for bamfdaemon ...
Rebuilding /usr/share/applications/bamf.index...
Processing triggers for hicolor-icon-theme ...
Setting up gwibber (3.4.1-0ubuntu1) ...

During Facebook authorization i got:
...
(gwibber:10040): GLib-GObject-WARNING **: g_object_set_property: object class `GwibberAccount' has no property named `uid'
Traceback (most recent call last):
  File "/usr/share/gwibber/plugins/facebook/gtk/facebook/__init__.py", line 171, in on_facebook_auth_title_change
    self.ui.get_object("fb_auth_done_label").set_label(_("%s has been authorized by Facebook") % str(self.account["username"]))
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0160' in position 0: ordinal not in range(128)

Unfortunately it doesn't seem fixed yet.

Changed in gwibber (Ubuntu Precise):
status: Fix Committed → Confirmed
Štefan Baebler (stefanba) wrote :

>UnicodeEncodeError: 'ascii' codec can't encode character u'\u0160' in position 0: ordinal not in range(128)
In the first place (postiton 0) of my name there should be letter "Š" (http://www.unicodemap.org/details/0x0160 , http://en.wikipedia.org/wiki/%C5%A0 ), but it seems written strangely as u'\u0160', possibly indicating it's trying to map double utf encoded character into ascii?

Sebastien Bacher (seb128) wrote :

@Štefan:

your log has
"Unpacking gwibber (from .../gwibber_3.4.1-0ubuntu1_i386.deb) ..."

or the version with the patch is 0ubuntu1.1:
https://launchpad.net/ubuntu/+source/gwibber/3.4.1-0ubuntu1.1

can you try again with proposed enable?

Štefan Baebler (stefanba) wrote :
Download full text (3.7 KiB)

this time after aptitude update it installed 3.4.1-0ubuntu1.1:
stefan@***:~$ sudo aptitude install gwibber-service/precise-proposed gwibber/precise-proposed
The following NEW packages will be installed:
  gwibber gwibber-service gwibber-service-facebook{a}
  gwibber-service-identica{a} gwibber-service-twitter{a} libgtkspell-3-0{a}
  libgwibber-gtk2{a} libgwibber2{a} python-libproxy{a}
0 packages upgraded, 9 newly installed, 0 to remove and 32 not upgraded.
Need to get 216 kB/376 kB of archives. After unpacking 2040 kB will be used.
Do you want to continue? [Y/n/?]
Get: 1 http://si.archive.ubuntu.com/ubuntu/ precise/main libgtkspell-3-0 i386 3.0.0~hg20110814-1 [15,1 kB]
Get: 2 http://si.archive.ubuntu.com/ubuntu/ precise-proposed/main gwibber-service all 3.4.1-0ubuntu1.1 [40,2 kB]
Get: 3 http://si.archive.ubuntu.com/ubuntu/ precise-proposed/main gwibber i386 3.4.1-0ubuntu1.1 [156 kB]
Get: 4 http://si.archive.ubuntu.com/ubuntu/ precise/main python-libproxy all 0.4.7-0ubuntu4 [4182 B]
Fetched 216 kB in 0s (312 kB/s)
Selecting previously unselected package libgtkspell-3-0.
(Reading database ... 268596 files and directories currently installed.)
Unpacking libgtkspell-3-0 (from .../libgtkspell-3-0_3.0.0~hg20110814-1_i386.deb) ...
Selecting previously unselected package gwibber-service.
Unpacking gwibber-service (from .../gwibber-service_3.4.1-0ubuntu1.1_all.deb) ...
Selecting previously unselected package libgwibber2.
Unpacking libgwibber2 (from .../libgwibber2_3.4.1-0ubuntu1_i386.deb) ...
Selecting previously unselected package libgwibber-gtk2.
Unpacking libgwibber-gtk2 (from .../libgwibber-gtk2_3.4.1-0ubuntu1_i386.deb) ...
Selecting previously unselected package gwibber.
Unpacking gwibber (from .../gwibber_3.4.1-0ubuntu1.1_i386.deb) ...
Selecting previously unselected package gwibber-service-facebook.
Unpacking gwibber-service-facebook (from .../gwibber-service-facebook_3.4.1-0ubuntu1_all.deb) ...
Selecting previously unselected package gwibber-service-identica.
Unpacking gwibber-service-identica (from .../gwibber-service-identica_3.4.1-0ubuntu1_all.deb) ...
Selecting previously unselected package gwibber-service-twitter.
Unpacking gwibber-service-twitter (from .../gwibber-service-twitter_3.4.1-0ubuntu1_all.deb) ...
Selecting previously unselected package python-libproxy.
Unpacking python-libproxy (from .../python-libproxy_0.4.7-0ubuntu4_all.deb) ...
Processing triggers for gconf2 ...
Processing triggers for libglib2.0-0 ...
Processing triggers for desktop-file-utils ...
Processing triggers for gnome-menus ...
Processing triggers for bamfdaemon ...
Rebuilding /usr/share/applications/bamf.index...
Processing triggers for hicolor-icon-theme ...
Setting up libgtkspell-3-0 (3.0.0~hg20110814-1) ...
Setting up gwibber-service (3.4.1-0ubuntu1.1) ...
Setting up libgwibber2 (3.4.1-0ubuntu1) ...
Setting up libgwibber-gtk2 (3.4.1-0ubuntu1) ...
Setting up gwibber (3.4.1-0ubuntu1.1) ...
Setting up gwibber-service-facebook (3.4.1-0ubuntu1) ...
Setting up gwibber-service-identica (3.4.1-0ubuntu1) ...
Setting up gwibber-service-twitter (3.4.1-0ubuntu1) ...
Setting up python-libproxy (0.4.7-0ubuntu4) ...
Processing triggers for libc-bin ...
ldconfig...

Read more...

Štefan Baebler (stefanba) wrote :
Download full text (3.5 KiB)

I noticed services were not from branch in my previous test, so i removed every gwibber package and then explicitly installed 3.4.1-0ubuntu1.1 from precise-proposed:
stefan@***:~$ sudo aptitude install gwibber-service/precise-proposed gwibber/precise-proposed libgwibber2/precise-proposed libgwibber-gtk2/precise-proposed gwibber-service-facebook/precise-proposed gwibber-service-identica/precise-proposed gwibber-service-twitter/precise-proposed
The following NEW packages will be installed:
  gwibber gwibber-service gwibber-service-facebook gwibber-service-identica
  gwibber-service-twitter libgwibber-gtk2 libgwibber2
0 packages upgraded, 7 newly installed, 0 to remove and 32 not upgraded.
Need to get 24,5 kB/357 kB of archives. After unpacking 1890 kB will be used.
Get: 1 http://si.archive.ubuntu.com/ubuntu/ precise-proposed/main gwibber-service-facebook all 3.4.1-0ubuntu1.1 [7760 B]
Get: 2 http://si.archive.ubuntu.com/ubuntu/ precise-proposed/main gwibber-service-identica all 3.4.1-0ubuntu1.1 [7790 B]
Get: 3 http://si.archive.ubuntu.com/ubuntu/ precise-proposed/main gwibber-service-twitter all 3.4.1-0ubuntu1.1 [8992 B]
Fetched 24,5 kB in 0s (85,6 kB/s)
Selecting previously unselected package gwibber-service.
(Reading database ... 268608 files and directories currently installed.)
Unpacking gwibber-service (from .../gwibber-service_3.4.1-0ubuntu1.1_all.deb) ...
Selecting previously unselected package libgwibber2.
Unpacking libgwibber2 (from .../libgwibber2_3.4.1-0ubuntu1.1_i386.deb) ...
Selecting previously unselected package libgwibber-gtk2.
Unpacking libgwibber-gtk2 (from .../libgwibber-gtk2_3.4.1-0ubuntu1.1_i386.deb) ...
Selecting previously unselected package gwibber.
Unpacking gwibber (from .../gwibber_3.4.1-0ubuntu1.1_i386.deb) ...
Selecting previously unselected package gwibber-service-facebook.
Unpacking gwibber-service-facebook (from .../gwibber-service-facebook_3.4.1-0ubuntu1.1_all.deb) ...
Selecting previously unselected package gwibber-service-identica.
Unpacking gwibber-service-identica (from .../gwibber-service-identica_3.4.1-0ubuntu1.1_all.deb) ...
Selecting previously unselected package gwibber-service-twitter.
Unpacking gwibber-service-twitter (from .../gwibber-service-twitter_3.4.1-0ubuntu1.1_all.deb) ...
Processing triggers for gconf2 ...
Processing triggers for libglib2.0-0 ...
Processing triggers for desktop-file-utils ...
Processing triggers for gnome-menus ...
Processing triggers for bamfdaemon ...
Rebuilding /usr/share/applications/bamf.index...
Processing triggers for hicolor-icon-theme ...
Setting up gwibber-service (3.4.1-0ubuntu1.1) ...
Setting up libgwibber2 (3.4.1-0ubuntu1.1) ...
Setting up libgwibber-gtk2 (3.4.1-0ubuntu1.1) ...
Setting up gwibber (3.4.1-0ubuntu1.1) ...
Setting up gwibber-service-facebook (3.4.1-0ubuntu1.1) ...
Setting up gwibber-service-identica (3.4.1-0ubuntu1.1) ...
Setting up gwibber-service-twitter (3.4.1-0ubuntu1.1) ...
Processing triggers for libc-bin ...
ldconfig deferred processing now taking place

still the same:
(gwibber:22129): GLib-GObject-WARNING **: g_object_set_property: object class `GwibberAccount' has no property named `uid'
Traceback (most recent call last):
  Fil...

Read more...

tags: added: verification-failed
removed: verification-needed
Sebastien Bacher (seb128) wrote :

do you get the issue with a new account as well? Ken suggested that maybe the datas are already on disk in a buggy way for your user and that it should work with a new user account or a guest session

Štefan Baebler (stefanba) wrote :

I first tried deleting all gwibber settings from my user account, but to no avail (couchdb wasn't cooperating).
So i then resorted to guest profile, which was never used for gwibber before and the same error still popped up in the log (but this time there was no dialog to submit error details to developers).

Facebook authorization itself was successfull as it showed my feed (this was the case also under my account but there i wasn't sure if it was remembered from before or was it using the new authorization).

Sebastien Bacher (seb128) wrote :

ok, thanks, we confirmed the issue with extra testing and it should be fixed for good this time:
http://bazaar.launchpad.net/~gwibber-committers/gwibber/3.4/revision/1318

there is another SRU waiting for the review in the queue which includes this fix

Changed in gwibber (Ubuntu Precise):
status: Confirmed → Fix Committed
description: updated
Brian Murray (brian-murray) wrote :

Hello Vmaximoff, or anyone else affected,

Accepted gwibber into precise-proposed. The package will build now and be available in a few hours. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-failed
tags: added: verification-needed
Sebastien Bacher (seb128) wrote :

I did create an account with a Š char in the name, confirmed the bug, installed the update and tried again and confirmed it's fixed -> verification-done

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gwibber - 3.4.2-0ubuntu1

---------------
gwibber (3.4.2-0ubuntu1) precise-proposed; urgency=low

  * New upstream release.
    - facebook: Don't crash on unicode characters in a username (LP: #938667)
    - libgwibber-gtk: Fixed up the GwibberGtkEntry widget's alignment and
      icon search path (LP: #1011392)
  * debian/patches/lp_938667.patch
    - dropped, merged upstream

gwibber (3.4.1-0ubuntu1.1) precise-proposed; urgency=low

  * debian/patches/lp_938667.patch
    - facebook: Don't crash on unicode characters in a username (LP: #938667)
 -- Ken VanDine <email address hidden> Mon, 11 Jun 2012 23:25:25 -0400

Changed in gwibber (Ubuntu Precise):
status: Fix Committed → Fix Released
Štefan Baebler (stefanba) wrote :

Thank you, it works perfectly now!

Changed in gwibber (Ubuntu):
assignee: nobody → Guillermo Martínez (avemaestro)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers