Comment 29 for bug 626023

Revision history for this message
Gabriel Samfira (gabriel-samfira) wrote :

About the avatar. It looks like the json received from google, in some cases does not include the thumbnailUrl (avatar) in the "actor" block:

"actor": {
          "profileUrl": "http://www.google.com/profiles/samfiragabriel",
          "thumbnailUrl": "",
          "id": "101735734890425678723",
          "name": "Gabriel-Adrian Samfira"
        }

The _actor method looks for the thumbnailUrl key, and defaults to:

https://mail.google.com/mail/images/blue_ghost.jpg?sz=45

if it doesn't exist. Unfortunately it exists, but its and empty string. I added a condition that deletes the key in case its an empty string, so it can default to blue_ghost.