Activity log for bug #1927100

Date Who What changed Old value New value Message
2021-05-04 13:25:18 sam tygier bug added bug
2021-08-27 14:27:10 Launchpad Janitor gvfs (Ubuntu): status New Confirmed
2021-10-16 04:44:19 buck2202 bug added subscriber buck2202
2021-10-16 11:03:34 buck2202 attachment added gvfs.debdiff https://bugs.launchpad.net/ubuntu/+source/gvfs/+bug/1927100/+attachment/5533422/+files/gvfs.debdiff
2021-10-16 12:28:14 Ubuntu Foundations Team Bug Bot tags patch
2021-10-16 12:28:23 Ubuntu Foundations Team Bug Bot bug added subscriber Ubuntu Sponsors Team
2021-10-17 05:52:18 Mathew Hodson gvfs (Ubuntu): importance Undecided Low
2021-10-17 05:54:42 Mathew Hodson nominated for series Ubuntu Focal
2021-10-17 05:54:42 Mathew Hodson bug task added gvfs (Ubuntu Focal)
2021-10-17 05:54:53 Mathew Hodson gvfs (Ubuntu Focal): importance Undecided Low
2021-10-17 05:54:57 Mathew Hodson gvfs (Ubuntu): status Confirmed Fix Released
2021-11-19 20:58:07 Brian Murray bug added subscriber Brian Murray
2021-11-19 20:58:09 Brian Murray gvfs (Ubuntu Focal): status New Incomplete
2021-12-03 20:07:19 Brian Murray removed subscriber Ubuntu Sponsors Team
2021-12-21 06:36:23 buck2202 attachment added 2-gvfs.debdiff https://bugs.launchpad.net/ubuntu/+source/gvfs/+bug/1927100/+attachment/5548854/+files/2-gvfs.debdiff
2021-12-21 06:39:59 buck2202 description On Ubuntu Mate 20.04. Sometime the Open and Save dialogs in GTK applications will over 20 seconds to display. I found https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 , which suggested this due to gvfsd-trash, and running `killall gvfsd-trash` which does temporary solve the problem. The issue is apparently fixed in gvfs 1.46.2 Please could 1.46.2 or the fix https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/96 be backported to Ubuntu 20.04 [Description] glib GFileMonitors can cause deadlocks if not explicitly cancelled before unref-ing (as of Dec 2021; see https://gitlab.gnome.org/GNOME/glib/-/issues/1941). In gvfs <1.46.2, gvfsd-trash can cause this deadlock, leading to 25s delays in spawning gtk+ dialogs system-wide. The best userspace workaround is explicitly pkill-ing gvfsd-trash at a sometimes frequent interval. This issue was reported and fixed in gvfs issue: https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 commit: https://gitlab.gnome.org/GNOME/gvfs/-/commit/dc21a0948bcbe8a6d79d674bd1e4d63ded57d340 merge: https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/96 [Test Case] To my knowledge, there is not a 100% reproducer for gvfs from userspace as this is a probable lock-ordering issue in lower-level code. https://gitlab.gnome.org/GNOME/glib/-/issues/1941 contains a reproducer for the underlying glib issue. User reports of gvfsd-trash manifesting this deadlock exist for Focal and Focal-based distributions, and it has been acknowledged and worked-around in gvfs. See: https://forums.linuxmint.com/viewtopic.php?f=47&t=328966 (Linux Mint forums) https://github.com/linuxmint/nemo/issues/2497 (Linux Mint nemo -- file manager) https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 (gvfs bug report, includes diagnosis and stacktrace showing the gvfsd-trash thread) The code change patched-in here has propagated to various other projects. See: https://bugs.launchpad.net/ubuntu/+source/libxmlb/+bug/1890313 https://github.com/fwupd/fwupd/issues/2350 [Regression Potential] This patch explicitly cancels GFileMonitors before "unreferencing" them to workaround a known glib issue. Absent any currently-unknown issues with the GFileMonitor framework, code added by this patch should be entirely within valid usage of GFileMonitors, is already present in gvfs releases in wide distribution, and, at worst, should become superfluous if/when the underlying glib issue is fixed. In the event that gvfsd-trash had some (currently unknown) mismanagement of its file watchers, it's possible that attempting to cancel an invalid monitor might behave differently than unref-ing it (which was already happening), but, this scenario would likely be bad either way. [Original Description] On Ubuntu Mate 20.04. Sometime the Open and Save dialogs in GTK applications will over 20 seconds to display. I found https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 , which suggested this due to gvfsd-trash, and running `killall gvfsd-trash` which does temporary solve the problem. The issue is apparently fixed in gvfs 1.46.2 Please could 1.46.2 or the fix https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/96 be backported to Ubuntu 20.04
2021-12-21 06:40:45 buck2202 description [Description] glib GFileMonitors can cause deadlocks if not explicitly cancelled before unref-ing (as of Dec 2021; see https://gitlab.gnome.org/GNOME/glib/-/issues/1941). In gvfs <1.46.2, gvfsd-trash can cause this deadlock, leading to 25s delays in spawning gtk+ dialogs system-wide. The best userspace workaround is explicitly pkill-ing gvfsd-trash at a sometimes frequent interval. This issue was reported and fixed in gvfs issue: https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 commit: https://gitlab.gnome.org/GNOME/gvfs/-/commit/dc21a0948bcbe8a6d79d674bd1e4d63ded57d340 merge: https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/96 [Test Case] To my knowledge, there is not a 100% reproducer for gvfs from userspace as this is a probable lock-ordering issue in lower-level code. https://gitlab.gnome.org/GNOME/glib/-/issues/1941 contains a reproducer for the underlying glib issue. User reports of gvfsd-trash manifesting this deadlock exist for Focal and Focal-based distributions, and it has been acknowledged and worked-around in gvfs. See: https://forums.linuxmint.com/viewtopic.php?f=47&t=328966 (Linux Mint forums) https://github.com/linuxmint/nemo/issues/2497 (Linux Mint nemo -- file manager) https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 (gvfs bug report, includes diagnosis and stacktrace showing the gvfsd-trash thread) The code change patched-in here has propagated to various other projects. See: https://bugs.launchpad.net/ubuntu/+source/libxmlb/+bug/1890313 https://github.com/fwupd/fwupd/issues/2350 [Regression Potential] This patch explicitly cancels GFileMonitors before "unreferencing" them to workaround a known glib issue. Absent any currently-unknown issues with the GFileMonitor framework, code added by this patch should be entirely within valid usage of GFileMonitors, is already present in gvfs releases in wide distribution, and, at worst, should become superfluous if/when the underlying glib issue is fixed. In the event that gvfsd-trash had some (currently unknown) mismanagement of its file watchers, it's possible that attempting to cancel an invalid monitor might behave differently than unref-ing it (which was already happening), but, this scenario would likely be bad either way. [Original Description] On Ubuntu Mate 20.04. Sometime the Open and Save dialogs in GTK applications will over 20 seconds to display. I found https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 , which suggested this due to gvfsd-trash, and running `killall gvfsd-trash` which does temporary solve the problem. The issue is apparently fixed in gvfs 1.46.2 Please could 1.46.2 or the fix https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/96 be backported to Ubuntu 20.04 [Description/Impact] glib GFileMonitors can cause deadlocks if not explicitly cancelled before unref-ing (as of Dec 2021; see https://gitlab.gnome.org/GNOME/glib/-/issues/1941). In gvfs <1.46.2, gvfsd-trash can cause this deadlock, leading to 25s delays in spawning gtk+ dialogs system-wide. The best userspace workaround is explicitly pkill-ing gvfsd-trash at a sometimes frequent interval. This issue was reported and fixed in gvfs issue: https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 commit: https://gitlab.gnome.org/GNOME/gvfs/-/commit/dc21a0948bcbe8a6d79d674bd1e4d63ded57d340 merge: https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/96 [Test Case] To my knowledge, there is not a 100% reproducer for gvfs from userspace as this is a probable lock-ordering issue in lower-level code. https://gitlab.gnome.org/GNOME/glib/-/issues/1941 contains a reproducer for the underlying glib issue. User reports of gvfsd-trash manifesting this deadlock exist for Focal and Focal-based distributions, and it has been acknowledged and worked-around in gvfs. See: https://forums.linuxmint.com/viewtopic.php?f=47&t=328966 (Linux Mint forums) https://github.com/linuxmint/nemo/issues/2497 (Linux Mint nemo -- file manager) https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 (gvfs bug report, includes diagnosis and stacktrace showing the gvfsd-trash thread) The code change patched-in here has propagated to various other projects. See: https://bugs.launchpad.net/ubuntu/+source/libxmlb/+bug/1890313 https://github.com/fwupd/fwupd/issues/2350 [Regression Potential] This patch explicitly cancels GFileMonitors before "unreferencing" them to workaround a known glib issue. Absent any currently-unknown issues with the GFileMonitor framework, code added by this patch should be entirely within valid usage of GFileMonitors, is already present in gvfs releases in wide distribution, and, at worst, should become superfluous if/when the underlying glib issue is fixed. In the event that gvfsd-trash had some (currently unknown) mismanagement of its file watchers, it's possible that attempting to cancel an invalid monitor might behave differently than unref-ing it (which was already happening), but, this scenario would likely be bad either way. [Original Description] On Ubuntu Mate 20.04. Sometime the Open and Save dialogs in GTK applications will over 20 seconds to display. I found https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 , which suggested this due to gvfsd-trash, and running `killall gvfsd-trash` which does temporary solve the problem. The issue is apparently fixed in gvfs 1.46.2 Please could 1.46.2 or the fix https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/96 be backported to Ubuntu 20.04
2022-01-05 12:21:19 Robie Basak bug watch added https://gitlab.gnome.org/GNOME/glib/-/issues/1941
2022-03-28 09:23:36 Robie Basak bug added subscriber Robie Basak
2022-04-20 00:59:23 Chris Halse Rogers gvfs (Ubuntu Focal): status Incomplete Fix Committed
2022-04-20 00:59:25 Chris Halse Rogers bug added subscriber Ubuntu Stable Release Updates Team
2022-04-20 00:59:27 Chris Halse Rogers bug added subscriber SRU Verification
2022-04-20 00:59:32 Chris Halse Rogers tags patch patch verification-needed verification-needed-focal
2022-05-08 15:54:18 buck2202 tags patch verification-needed verification-needed-focal patch verification-done-focal verification-needed
2022-05-09 08:48:47 Launchpad Janitor gvfs (Ubuntu Focal): status Fix Committed Fix Released
2022-05-09 08:48:52 Robie Basak removed subscriber Ubuntu Stable Release Updates Team