Remove type-ahead patch.

Bug #1818819 reported by Gustav Hartvigsson on 2019-03-06
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gtk+3.0 (Ubuntu)
Wishlist
Unassigned

Bug Description

In the Ubuntu version of Gtk+ 3 type-ahead as been re-patched in. This causes unexpected behaviours for the file-chooser.

The type-ahead patch should be removed for the following reasons:

1) In file-chooser when you try to search using the looking-glass icon search-dialogue the focus does not stay in the search box, so you have to click in the box each time you type a letter.[1]

2) A magically appearing type-ahead box is not expected and confusing.

3) This behaviour was removed from Nautilus, and from main-line Gtk+ years ago. Having this behaviour re-added is not something that should have happened. There is a search button for a reason. [2]

It's better to make people use the less confusing search box than the very confusing type-ahead box.

I understand that you might think it is good for the old-timers, but it is totally broken, and has no place in a modern operating system.

---------------

[1] https://bugs.launchpad.net/ubuntu-gnome/+bug/1592177 , https://gitlab.gnome.org/GNOME/gtk/issues/1572

[2] It does not make sense when looking at HIG. And how most GNOME and Gtk+ apps are designed. It is a weird legacy design choice from before Gtk+ modernised and made things much clearer.
https://developer.gnome.org/hig/stable/search.html.en

Sebastien Bacher (seb128) wrote :

Thank you for your bug report. It's a tricky one, and still a topic lot of users care about, see the comments/activity upstream on
https://bugzilla.gnome.org/show_bug.cgi?id=748672
https://bugzilla.gnome.org/show_bug.cgi?id=784029
https://gitlab.gnome.org/GNOME/gtk/issues/839

The recent comment on the gitlab ticket hints some users still strongly feel like the old way was better

That said you are right that the patch is buggy, and it might be useful to get some feedback from our users how they like the new way or not so we are going to try dropping that patch for Disco.

affects: gtk+3.0 (Ubuntu) → ubuntu
Changed in ubuntu:
importance: Undecided → Wishlist
status: New → In Progress
affects: ubuntu → gtk+3.0 (Ubuntu)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk+3.0 - 3.24.5-1ubuntu2

---------------
gtk+3.0 (3.24.5-1ubuntu2) disco; urgency=medium

  * debian/patches/restore_filechooser_typeaheadfind.patch:
    - remove our patch to restore typeahead in the filechooser, when it
      was added back to the package the upstream code had no replacement,
      nowadays they trigger a search (which is also what nautilus does now).
      The patch was also buggy and creating focus issue in the search entry.
      (lp: #1818819, #1592177)

 -- Sebastien Bacher <email address hidden> Wed, 06 Mar 2019 13:46:50 +0100

Changed in gtk+3.0 (Ubuntu):
status: In Progress → Fix Released
Adolfo Jayme (fitojb) wrote :

> has no place in a modern operating system.

LOL

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.