Update gtk to 3.24.4

Bug #1808233 reported by Jeremy Bicha on 2018-12-12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gtk+3.0 (Ubuntu)
Jeremy Bicha

Bug Description

There is a new release in the stable 3.24 series.

This also bundles the emoji fixes from LP: #1807719 and LP: #1807721 and the Xfce flickering fix from LP: #1798861.


Test Case
Run several apps in the default Ubuntu install and make sure that there are no visible regressions.

Make sure that GTK switches look OK.

We will also be checking Xfce to validate the fix for LP: #1798861.

Regression Potential
There is a standing microrelease exception for GNOME point releases.

I believe this is the second time in recent history that we've pushed a gtk point release as an SRU. The other example was 3.22.25 for Ubuntu 17.10 (LP: #1728421). We never ended up doing one for Ubuntu 18.04 LTS since it already included 3.22.30, the final 3.22 release. It hasn't been practical to update 18.04's gtk to the 3.24 series (bumped dependencies are one problem).


By the way, pre-release gtk3 is actually getting a bit more testing than a year ago since more developers and users are using development Flatpak releases of popular GNOME apps. (On the other hand, there were a few regressions in the 3.24.2 and 3.24.3 releases.)

This update changes the ON/OFF switches for GNOME's default Adwaita theme to use ❙/○ for all languages (or ⏽/⭘ if they are supported in a font you have installed: currently, that's fonts-symbola which we no longer install by default). Previously, it was ❙/○ for most languages but ON/OFF for English (because English has short words that could fit on a switch). This doesn't affect default Ubuntu 18.10 which uses Yaru which doesn't use labels on its switches. This is technically a UI change, but it is useful for compatibility with Flatpak apps that are being built with the new GTK. This change is small enough that it could be reverted for Ubuntu 18.10 if necessary.

Other Info
The commit history shows themeing changes to the GNOME default themes (Adwaita and Adwaita Dark which are bundled inside gtk3). But those changes were reverted for this release to make it easier for distros like us to push the update to our stable release.

The next scheduled gtk3 release (3.24.5 ? in March?) will include those changes. See https://blog.gtk.org/2019/01/14/theme-changes-in-gtk-3/ for more details.

Jeremy Bicha (jbicha) on 2018-12-12
Changed in gtk+3.0 (Ubuntu):
status: Fix Committed → Triaged
Jeremy Bicha (jbicha) wrote :

There will be a 3.24.3 release "soon" so I think it's best to wait for that before pushing to Ubuntu 18.10.

tags: added: upgrade-software-version
Jeremy Bicha (jbicha) on 2018-12-15
Changed in gtk+3.0 (Ubuntu Cosmic):
assignee: nobody → Jeremy Bicha (jbicha)
importance: Undecided → Medium
status: New → Triaged
Changed in gtk+3.0 (Ubuntu):
status: Triaged → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk+3.0 - 3.24.2-2ubuntu2

gtk+3.0 (3.24.2-2ubuntu2) disco; urgency=medium

  * Cherry-pick x11-Fix-deprecation-macro-use.patch:
    - Fix deprecation macro use to fix crashes seen on Xfce

gtk+3.0 (3.24.2-2ubuntu1) disco; urgency=medium

  * Merge from Debian. Remaining changes:
    + Install a settings.ini file to set our themes
    + Update debian/libgtk-3-0.symbols
    + debian/control.in:
      - Build-depend on adwaita-icon-theme-full for icon name check test
    + autopkgtest: installed-tests: Depend on adwaita-icon-theme-full
    + debian/control.in, debian/rules:
      - use dh-translations for language packs integration
    + Ubuntu-specific patches:
      - 073_treeview_almost_fixed.patch
      - bzg_gtkcellrenderer_grabbing_modifier.patch
      - ubuntu_gtk_custom_menu_items.patch
      - print-dialog-show-options-of-remote-dnssd-printers.patch
      - uimanager-guard-against-nested-node-updates.patch
      - x-canonical-accel.patch
      - message-dialog-restore-traditional-look-on-unity.patch
      - 0001-gtk-reftest-Force-icon-theme-to-Adwaita.patch
      - restore_filechooser_typeaheadfind.patch
      - 0001-calendar-always-emit-day-selected-once.patch
      - 0001-gtkwindow-set-transparent-background-color.patch
      - unity-border-radius.patch
      - unity-headerbar-maximized-mode.patch

gtk+3.0 (3.24.2-2) unstable; urgency=medium

  * Add Revert-update-some-a11y-test-results.patch:
    - Revert a late change that broke our build tests
  * Use xvfb-run for build tests

gtk+3.0 (3.24.2-1) unstable; urgency=medium

  * New upstream release (LP: #1808233)
    - Fix tooltip flickering regression in Xfce (Closes: #911148) (LP: #1798861)
  * Drop patches applied in new release:
    - wayland-Avoid-crashes-inside-wl_proxy_marshal.patch
    - Force-emoji-presentation.patch
    - emojichooser-Pass-chooser-to-add_emoji.patch
  * Cherry-pick Revert-Fix-deprecation-warnings.patch:
    - Fix typo that broke the build
  * debian/libgtk-3-0.symbols: Add new symbol

 -- Jeremy Bicha <email address hidden> Thu, 13 Dec 2018 18:01:53 -0500

Changed in gtk+3.0 (Ubuntu):
status: Fix Committed → Fix Released
Jeremy Bicha (jbicha) on 2019-01-15
summary: - Update gtk to 3.24.2
+ Update gtk to 3.24.3
Changed in gtk+3.0 (Ubuntu):
status: Fix Released → Fix Committed
Jeremy Bicha (jbicha) on 2019-01-15
description: updated
Jeremy Bicha (jbicha) on 2019-01-15
Changed in gtk+3.0 (Ubuntu Cosmic):
status: Triaged → In Progress
Jeremy Bicha (jbicha) on 2019-01-21
summary: - Update gtk to 3.24.3
+ Update gtk to 3.24.4
description: updated
Fernando (fmuro) wrote :

Hi! Sorry to bother here but I wanted to attract your attention to the following bug, in case you could consider dropping the type ahead patch in future updates: https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1592177

Hello Jeremy, or anyone else affected,

Accepted gtk+3.0 into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gtk+3.0/3.24.4-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gtk+3.0 (Ubuntu Cosmic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-cosmic
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers