Fix variant selection in emoji chooser

Bug #1807721 reported by Jeremy Bicha on 2018-12-10
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gtk+3.0 (Ubuntu)
Medium
Unassigned
Bionic
Medium
Jeremy Bicha
Cosmic
Medium
Jeremy Bicha

Bug Description

Impact
======
The variant selector in the emoji chooser was broken and will crash the app if used.

Test Case
=========
In an app like gedit, right click in the text area and select Insert Emoji
Look for one of the "people" emoji.
Right-click (or long-click) on the emoji and select one of the skin tones instead of the default yellow.
The emoji with the skin tone you selected should be added to the text area.

Regression Potential
====================
This fix was included in the gtk 3.24.2 release. There is a standing microrelease exception for GNOME point releases.

GTK 3.24 was a big enough release (with some bumped dependencies) that it's not very practical to push to Ubuntu 18.04 LTS so we selectively cherry-pick fixes there.

https://wiki.ubuntu.com/StableReleaseUpdates#GNOME

https://gitlab.gnome.org/GNOME/gtk/commit/dbbc7b3859f4b
https://gitlab.gnome.org/GNOME/gtk/issues/1398

Other Info
==========
This bug is fixed in gtk 3.24.2. Its SRU for cosmic is being tracked in LP: #1808233

Jeremy Bicha (jbicha) on 2018-12-10
description: updated
Jeremy Bicha (jbicha) on 2018-12-10
Changed in gtk+3.0 (Ubuntu Bionic):
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Jeremy Bicha (jbicha)
Changed in gtk+3.0 (Ubuntu Cosmic):
assignee: nobody → Jeremy Bicha (jbicha)
importance: Undecided → Medium
status: New → In Progress
Jeremy Bicha (jbicha) on 2018-12-12
description: updated
description: updated
description: updated
Brian Murray (brian-murray) wrote :

Why is the cosmic task open here? I don't see an upload in the cosmic queue and the description leads me to believe this may already be fixed there.

Jeremy Bicha (jbicha) wrote :

Brian, I have now added a note to the bug description to explain that the cosmic fix is being handled as part of the gtk 3.24.2 SRU. I did upload this fix for cosmic but I got Steve to reject it for me since we are doing to do the 3.24.2 SRU instead. I still haven't uploaded 3.24.2 to cosmic since I expect a 3.24.3 release "soon".

If you want to accept the bionic fix, I'll wait to verify the fix until after this issue is also fixed is in cosmic-proopsed. Or we can just wait a bit longer for bionic too.

description: updated
Changed in gtk+3.0 (Ubuntu Cosmic):
status: In Progress → Triaged
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk+3.0 - 3.24.2-2ubuntu2

---------------
gtk+3.0 (3.24.2-2ubuntu2) disco; urgency=medium

  * Cherry-pick x11-Fix-deprecation-macro-use.patch:
    - Fix deprecation macro use to fix crashes seen on Xfce

gtk+3.0 (3.24.2-2ubuntu1) disco; urgency=medium

  * Merge from Debian. Remaining changes:
    + Install a settings.ini file to set our themes
    + Update debian/libgtk-3-0.symbols
    + debian/control.in:
      - Build-depend on adwaita-icon-theme-full for icon name check test
    + autopkgtest: installed-tests: Depend on adwaita-icon-theme-full
    + debian/control.in, debian/rules:
      - use dh-translations for language packs integration
    + Ubuntu-specific patches:
      - 073_treeview_almost_fixed.patch
      - bzg_gtkcellrenderer_grabbing_modifier.patch
      - ubuntu_gtk_custom_menu_items.patch
      - print-dialog-show-options-of-remote-dnssd-printers.patch
      - uimanager-guard-against-nested-node-updates.patch
      - x-canonical-accel.patch
      - message-dialog-restore-traditional-look-on-unity.patch
      - 0001-gtk-reftest-Force-icon-theme-to-Adwaita.patch
      - restore_filechooser_typeaheadfind.patch
      - 0001-calendar-always-emit-day-selected-once.patch
      - 0001-gtkwindow-set-transparent-background-color.patch
      - unity-border-radius.patch
      - unity-headerbar-maximized-mode.patch

gtk+3.0 (3.24.2-2) unstable; urgency=medium

  * Add Revert-update-some-a11y-test-results.patch:
    - Revert a late change that broke our build tests
  * Use xvfb-run for build tests

gtk+3.0 (3.24.2-1) unstable; urgency=medium

  * New upstream release (LP: #1808233)
    - Fix tooltip flickering regression in Xfce (Closes: #911148) (LP: #1798861)
  * Drop patches applied in new release:
    - wayland-Avoid-crashes-inside-wl_proxy_marshal.patch
    - Force-emoji-presentation.patch
    - emojichooser-Pass-chooser-to-add_emoji.patch
  * Cherry-pick Revert-Fix-deprecation-warnings.patch:
    - Fix typo that broke the build
  * debian/libgtk-3-0.symbols: Add new symbol

 -- Jeremy Bicha <email address hidden> Thu, 13 Dec 2018 18:01:53 -0500

Changed in gtk+3.0 (Ubuntu):
status: Fix Committed → Fix Released
Jeremy Bicha (jbicha) wrote :

Uploaded to the cosmic queue now that 3.24.3 was released.

Changed in gtk+3.0 (Ubuntu Cosmic):
status: Triaged → In Progress

Hello Jeremy, or anyone else affected,

Accepted gtk+3.0 into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gtk+3.0/3.24.4-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gtk+3.0 (Ubuntu Cosmic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-cosmic
Steve Langasek (vorlon) wrote :

Hello Jeremy, or anyone else affected,

Accepted gtk+3.0 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gtk+3.0/3.22.30-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gtk+3.0 (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers