Don't let offscreen widgets do grab adds

[Cody Russell]

Widgets inside GtkOffscreenWindow seem like they should not be allowed to do grab the mouse or whatever, as this can deactivate open menus and stuff.

[Cody Russell (bratsche)]

https://bugzilla.gnome.org/show_bug.cgi?id=607668

[Sebastien Bacher (seb128)]

Thank you for your work there

[Launchpad Janitor (janitor)]

This bug was fixed in the package gtk+2.0 - 2.19.3-1ubuntu4

---------------
gtk+2.0 (2.19.3-1ubuntu4) lucid; urgency=low

  * debian/patches/071_no_offscreen_widgets_grabbing.patch:
    - change by Cody Russell to not let offscreen widgets do grabbing
      (Lp: #512427)
 -- Sebastien Bacher <email address hidden> Mon, 25 Jan 2010 23:13:51 +0100

[Alistair Buxton (a-j-buxton)]

This patch causes an annoying g_critical if you add a grab on a widget before it is realized. In this case toplevel->window will be null.

This also make me wonder what happens if you add a grab to an offscreen widget before realizing it.

[djb (djb0)]

This patch has propagated to Debian too, where it causes this

every time a GtkComboBox with wrap-width not set is opened.

This seems bad. Can this patch be removed? I'm not sure it's applicable in 2016. It's weird also that a patch with such a weak synopsis was accepted:

"seem like they should not be allowed to do grab the mouse or whatever"

What was that supposed to mean?

[djb (djb0)]

The bug this causes is

(GameConqueror.py:19834): Gdk-CRITICAL **: gdk_window_get_window_type: assertion 'GDK_IS_WINDOW (window)' failed

as documented here

https://bugzilla.gnome.org/show_bug.cgi?id=771242