Gimp crashes with text tool & caps lock

[z3z]

[Impact]

Gimp crashes with a segfault when I use caps lock while renaming a layer. It is possible Caps lock causes crashes in other events also.

[Test Case]

Steps to reproduce:

1. Open a new blank gimp document
2. select the text tool
3. type a couple of words of text (gimp will create a text layer above the background layer)
4. with the text tool still selected, click on the background layer (just to move away from the text layer)
5. now double click on the text layer to rename the layer (layer name gets highlighted)
6. press the caps lock key
7. click on the background layer again (without renaming or doing anything to the text layer)
Now repeat steps 5 and 6.
Gimp crashes.

[Regression Potential]

None expected. The patch used has been taken from upstream development.

https://git.gnome.org/browse/gtk%2B/commit/?id=2811221d7039bd82265ce36a1b0dd9a0eeb431ad

Packages for Xenial and Yakkety have been built in a PPA and regression tested.

[ Other Info ]

I can force this to happen every time I launch Gimp. Rebooting makes no difference. It seems to be the second time I press caps lock that forces the crash. I tried launching Gimp with caps lock on vs caps lock off, but I don't believe it made any difference. I can force a crash every time following the above sequence.

I deleted my gimp preferences folder then rebooted for good measure. Gimp created a fresh preferences folder, but it hasn't solved the problem. I was originally in single window mode, but the new preferences folder put me back to multi window, but it crashes either way.

I ran dmesg | tail after the crash and got the following line:

gimp-2.8[2976]: segfault at 14 ip 00007ff5100e0cd9 sp 00007ffef11bfcb0 error 4 in libgtk-x11-2.0.so.0.2400.30[7ff51001b000+43e000]

I'm using a fresh install of Xubuntu 16.04 with nvidia 361.42 driver (available from the Additional Drivers tab). In that same tab, I also have enabled Processor microcode firmware for Intel CPUs. Terminal tells me Gimp version is 2.8.16-1ubuntu1

I'm not very experienced with bug reporting and not sure what other information I need to supply. Gimp was absolutely rock solid on this machine with 15.10, so it may be a Xubuntu issue.

Hope someone can take a look at this. Thanks.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Tarik (tarik-causevic)]

Ubuntu 14.04.03, same sequence of events causes a crash without any error reporting triggered. Caps lock seems to cause crashes in other events also, but cannot find another repeatable sequence that causes this also.

[JF (jfcandidofilho)]

I'm not using Ubuntu for some years but I think it is valid to say I'm having issues too while using Arch Linux. Been some months!

I found the same bug report in RHEL's Bugzilla (https://<email address hidden>/msg697314.html). And I think I will create one ticket in Arch's bug report environment if there is no report yet (probably not). Not that it matters here but it is avalid to know. But I need to check Debian that I sometimes use.

This is a problems because while I know it's a necessity to save often to be sure that anything bad doesn't happen, whenever you get yourself lost into the creativity world, you forget to save. Always!

The basic solution for now seems to be a button connected through my PC's USB port to automatically save. I need to dev the bord first but I guarantee it will have a big flashy red led-button and a siren connected to it with automatic alarm with 1ms trigger.

[JF (jfcandidofilho)]

Plese, forget about RHEL's bug. Not relation or whatsoever. Seems like I have a bug myself.

[JF (jfcandidofilho)]

Upon writting the bug in Arch's bug report tracker (bug: https://bugs.archlinux.org/task/49949), I tryed to reproduce. And ater reading that it seems to have a relation to GTK+ and that it was fixed (read it here by clicking at: https://bugzilla.gnome.org/show_bug.cgi?id=648419), I concluded:

Seems like they (??) forgot to fix the issue regarding the layer's name dialogs. The bug seems to be non-existent in Arch regarding the "Text Tool" but still present when regarding the layer's name editor.

[z3z (z3z)]

I'm the original submitter of this bug. I ended up reinstalling Ubuntu 14.04 because of this issue, as Gimp is an essential package for me and it was unusable because of the crashes.

Today I tried installing the new Ubuntu 16.04.01 release in a spare partition in the hope that it had been fixed, but no joy. Bug is still present in the updated release and I can reliably crash Gimp with the caps lock key. I have no issues on Ubuntu 14.04.4.

[Rael Gugelmin Cunha (rael-gc)]

Man, this is so annoying!

[Martin Wimpress  (flexiondotorg)]

Attached is a debdiff for gtk+2.0 (Yakkety) that adds a patch to explicitly disconnect keymap signals.

[Martin Wimpress  (flexiondotorg)]

Attached is a debdiff for gtk+2.0 (Xenial) that adds a patch to explicitly disconnect keymap signals.

[Iain Lane (laney)]

Uploaded to unapproved, thanks.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gtk+2.0 - 2.24.31-1ubuntu1

---------------
gtk+2.0 (2.24.31-1ubuntu1) zesty; urgency=low

  * Merge with Debian unstable. Remaining changes:
    - d/libgtk2.0-0.symbols: update symbols file.
    - d/libgtk2.0-dev.manpages: add gtk-builder-convert.1 manpage.
    - d/rules: enable manpage.
    - d/update-icon-caches: run with "--include-image-data" flag.
    - add Ubuntu patches:
      + debian/patches/012_ubuntu-set-grab-add.patch
        - Added ubuntu_gtk_widget_set_has_grab so we can grab sliders and
          things in menus, needed by ido
      + debian/patches/062_dnd_menubar.patch:
        - Allow click on menubars for dnd
      + debian/patches/063_treeview_almost_fixed.patch:
        - Add an ubuntu-almost-fixed-height-mode property, (required for
          software-center)
      + debian/patches/071_no_offscreen_widgets_grabbing.patch:
        - Don't let offscreen widgets do grabbing
      + debian/patches/090_logging_file_saves.patch:
        - improve the logging of saved files
      + debian/patches/092_default_to_xdg_document_dir.patch:
        - Use $XDG_DOCUMENTS_DIR as default directory rather than the home
          directory for the 'Print to File' function.
      + debian/patches/093_gtk3_gtkimage_fallbacks_use.patch:
        - Backported gtk3 patch to add a "use-fallback" property to GtkImage,
          using it "icon-name and GIcon type of GtkImages can use automatic
          fallback names.", it will be useful for the indicator stack
      + debian/patches/095_git_menus_scrolling.patch:
        - backported gtk3 commit to fix menu scrolling issues
      + debian/patches/096_git_gtkprintsettings.patch:
        - upstream git commit backported from the gtk3 serie, don't ignore the
          gtkprintsettings resolution settings
      + debian/patches/097_statusicon_image_fallback.patch: Make GtkStatusIcon
        images use fallbacks by default if the property is available.
      + debian/patches/098_multiarch_module_path.patch:
        - Fallback to the pre-multiarch directory for compatibility
      + debian/patches/099_printer_filename_fix.patch
        - Fix to the print dialog for print to file, make sure a non-hidden filename
          is the default
      + debian/patches/100_overlay_scrollbar_loading.patch
        - support for dynamically loading overlay scrollbars
      + debian/patches/gtk-shell-shows-menubar.patch:
        - list gtk-shell-shows-menubar setting, that's required to have the local
          menubars hidding under unity in favor of the unity ones,
      + debian/patches/print-dialog-show-options-of-remote-dnssd-printers.patch:
        - Make printing on remote DNS-SD/Bonjour-shared printers work
      + debian/patches/backport_search_printer_location.patch
        - The list of printers should be searchable/sortable
      + debian/patches/menubar_toolbar_dragging.patch:
        - Allow windows to be dragged using blank spaces in the toolbar as
          well as the menubar
      + debian/patches/use-secrets-service-for-cups-auth_info.patch
  * Fixes issue with GtkEntry causing applications to crash (LP: #1576424)

gtk+2.0 (2.24.31-1) unstable; urgency=medium

...

[Brian Murray (brian-murray)]

Hello z3z, or anyone else affected,

Accepted gtk+2.0 into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gtk+2.0/2.24.30-4ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Brian Murray (brian-murray)]

Hello z3z, or anyone else affected,

Accepted gtk+2.0 into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gtk+2.0/2.24.30-1ubuntu1.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[z3z (z3z)]

Hi,

I've applied this update to Ubuntu 16.10 Yakkety, and I'm pleased to report that it's been successful. I repeated the steps I outlined in the first comment and it did not crash. I've spent the last five minutes trying various other combinations of caps lock presses to see if I could force a crash, but all seems to work as it should. I've therefore changed the tag to verification-done.

Thank you everyone who worked on this! :)

[Launchpad Janitor (janitor)]

This bug was fixed in the package gtk+2.0 - 2.24.30-4ubuntu3

---------------
gtk+2.0 (2.24.30-4ubuntu3) yakkety; urgency=medium

  * debian/patches/lp1576424-explicitly-disconnect-keymap-signals.patch
    - GtkEntry: Explicitly disconnect keymap signals. (LP: #1576424)

 -- Martin Wimpress <email address hidden> Tue, 04 Oct 2016 17:07:26 +0100

[Sebastien Bacher (seb128)]

Could somebody test on xenial?

[Łukasz Zemczak (sil2100)]

As part of a recent change in the Stable Release Update verification policy we would like to inform that for a bug to be considered verified for a given release a verification-done-$RELEASE tag needs to be added to the bug where $RELEASE is the name of the series the package that was tested (e.g. verification-done-xenial). Please note that the global 'verification-done' tag can no longer be used for this purpose.

Thank you!

[Jean-Baptiste Lallement (jibel)]

SRU verification for Xenial:
I have reproduced the problem with gtk+2.0 2.24.30-1ubuntu1 in xenial and have verified that the version of gtk+2.0 2.24.30-1ubuntu1.16.04.1 in -proposed fixes the issue.

Marking as verification-done

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for gtk+2.0 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gtk+2.0 - 2.24.30-1ubuntu1.16.04.1

---------------
gtk+2.0 (2.24.30-1ubuntu1.16.04.1) xenial; urgency=medium

  * debian/patches/lp1576424-explicitly-disconnect-keymap-signals.patch
    - GtkEntry: Explicitly disconnect keymap signals. (LP: #1576424)

 -- Martin Wimpress <email address hidden> Tue, 04 Oct 2016 17:07:26 +0100