patch to restore transparency in system tray icon

[Dallen Wilson]

Binary package hint: gstm

The gSTM system tray icon has a white background in maverick, even though the image file being used has a transparent background. It looks like this is an issue that affects many applications, possibly related to gnome-panel.

I've written a patch to correct the problem in gSTM, by using GtkStatusIcon to provide the system tray icon, rather then the eggtrayicon library it was using.

The patch was written using the gstm1.2-7ubuntu1 package as it's source; It may not apply to the upstream source.

[Sebastien Bacher (seb128)]

Thank you for your work, did that got sent upstream? It also seems you patch drop the debian copyright which is wrong

[Dallen Wilson (dallen.wilson)]

The patch has been submitted upstream, under SourceForge ticket #3200715.

The patch does indeed drop a portion of the debian/copyright file, specifically the portion of the License section for the eggtrayicon library, which is licensed under the LGPL. This is Right as far as I can see, since the patch also removes the eggtrayicon library and all references and dependencies related to it. The License for the gSTM program as a whole is under the GPL, and it's portion of debian/copyright remains unaffected.

[Juliano Jeziorny (kadu)]

Hi Dallen,

I've tried to apply your patch and got the following error:

# patch -p1 < 01-eggtrayicon-to-gtkstatusicon
patching file debian/copyright
patching file src/callbacks.c
patching file src/main.c
patching file src/Makefile.am
patching file src/Makefile.in
patching file src/notarea.c
Hunk #1 FAILED at 31.
1 out of 6 hunks FAILED -- saving rejects to file src/notarea.c.rej

[Dallen Wilson (dallen.wilson)]

Can you send me the src/notarea.c.rej file to have a look at? Also, what source package were you applying it to?

[Thomas (t.c)]

Hopefully somebody can fix the non transparent icon...
with this patch or something else :)

[Benjamin Flesch (bflesch)]

Is it possible to make any progress on this issue? On 13.04, GSTM is totally hidden and cannot be used right now.

@Dallen can you adapt your patch to the latest release so we can have a look at it again? Thanks!

[Dallen Wilson (dallen.wilson)]

@bf: The issue you're seeing in 13.04 is a separate problem, gstm uses the systray and that was removed in the newer versions of gnome, in favour of the App Indicator system. In 13.04 they apparently removed backwards-compatibility for systray.

I don't use gstm anymore but I can take a look and see what would be involved in changing it to use App Indicator instead of systray.

[Dallen Wilson (dallen.wilson)]

I've updated the patch slightly, it no longer modifies debian/copyright. Package Maintainers please note, this file will have to be updated by hand, as the LGPL sections pertaining to the eggtrayicon library no longer apply.

The patch has been tested and applies cleanly against https://launchpad.net/ubuntu/+archive/primary/+files/gstm_1.2.orig.tar.gz (md5sum 7fa71b86969d8d695c3b062780a5694e).

When used as the last patch in debian/patches/series using the latest ubuntu gstm package (1.2-8.1ubuntu1) it applies but several hunks are offset. Quilt refresh corrects the issue.