[gst-hybris] No thumbnailing even though image is playable on phone

Bug #1236874 reported by Thomas Strehl
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
The Savilerow project
Fix Released
High
Unassigned
gst-plugins-bad1.0 (Ubuntu)
Fix Released
Critical
Jim Hodapp

Bug Description

Video to reproduce can be found at http://www.doi.gov/news/video/thisweeksept202013.cfm.

The video shows up via mediascanner but has no thumbnail. Also, the video just plays fine on the device.

Thomas Strehl (strehl-t)
Changed in thumbnailer:
assignee: nobody → Jussi Pakkanen (jpakkane)
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Gstreamer logs say this:

0:00:01.203387760 3862 0x13cd4c0 FIXME bin gstbin.c:4008:gst_bin_query: implement duration caching in GstBin again

And, sure enough, the duration it gives for that file is 0.

This is either a bug in Gstreamer or the codecs it uses.

Revision history for this message
Thomas Strehl (strehl-t) wrote :

And why is this only a problem when thumbnailing but not playing the video?

Revision history for this message
Thomas Strehl (strehl-t) wrote :

Mediascanner logs show: CRITICAL critical: gst_amc_format_free: assertion 'format != NULL' failed

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

This is a known issue, and it happens because the software rendering path is not working correctly atm. It plays the file fine because it works when doing hw rendering (via a native window, zero copy).

To make it work with software rendering, it needs to deal with the buffers internally so we can copy that over to the next element in the pipeline. Jim is working on a fix.

affects: thumbnailer → gst-plugins-bad1.0 (Ubuntu)
Changed in gst-plugins-bad1.0 (Ubuntu):
assignee: Jussi Pakkanen (jpakkane) → nobody
summary: - No thumbnailing even though image is playable on phone
+ [gst-hybris] No thumbnailing even though image is playable on phone
Changed in gst-plugins-bad1.0 (Ubuntu):
assignee: nobody → Jim Hodapp (jhodapp)
importance: Undecided → Critical
status: New → Confirmed
Matt Fischer (mfisch)
Changed in sevilerow:
status: New → Confirmed
importance: Undecided → Medium
importance: Medium → High
assignee: nobody → Matthew Fischer (mfisch)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

I have a fix submitted and rsalveti is working to push the fix to the platform. I still couldn't get a thumbnail generated by the mediascanner, but it'd be really helpful if someone working on the mediascanner could take my fixes and try them out and tell me why it might still not be working. I want to know if the individual frame generated by the decoder isn't quite right, or if the fact that the pipeline doesn't tear down cleanly that is preventing the thumbnail from being generated.

Changed in gst-plugins-bad1.0 (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Testing it by yourself is quite simple. Libthumbnailer has a hidden standalone executable that does the screenshotting. You use it like this:

/usr/share/thumbnailer/vs-thumb video_file.avi output_file.jpg

(The application will move to /usr/lib/${platform}/thumbnailer/vs-thumb at some point.)

The source code of the executable is in this one file should you need to tweak it for testing:

http://bazaar.launchpad.net/~unity-team/thumbnailer/trunk/view/head:/src/vs-thumb.cpp

Jim Hodapp (jhodapp)
Changed in gst-plugins-bad1.0 (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

As of today this seems to work. The only exception is this file:

http://samplemedia.linaro.org/MPEG2/big_buck_bunny_480p_MPEG2_MP2_25fps_1800K.MPG

which freezes vs-thumb. This message is printed.

(vs-thumb:4853): GStreamer-CRITICAL **: gst_element_seek_simple: assertion 'seek_pos >= 0' failed

Which is the same it printed on avi files before the fixes mentioned in this bug were merged.

I don't know whether we support MPEG2 or not, but at least it should not freeze completely.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

I can take a look at this, but there will definitely be certain files that have issues and such. This is the nature of media playback and we'll have to take things on a case-by-case basis. There's a higher priority fix that I have to do first, then I'll take a look at this.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Attaching a backtrace of all thumbnailer threads when it freezes.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Adding strace log (caution - it's huge) for the problematic MPEG2 file, just in case it provides anything useful...

Alex Chiang (achiang)
affects: sevilerow → savilerow
Revision history for this message
Chris Wayne (cwayne) wrote :

Still seeing this issue in custom build #150

Matt Fischer (mfisch)
Changed in savilerow:
assignee: Matt Fischer (mfisch) → nobody
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

mark as fix release unless there are someone else see this happens.

Changed in savilerow:
status: Confirmed → Fix Released
Alexander (avgancccp)
Changed in gst-plugins-bad1.0 (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.