Candidate revision gscan2pdf_0.9.21-1ubuntu1

Bug #195540 reported by Jeffrey Ratcliffe
2
Affects Status Importance Assigned to Milestone
gscan2pdf (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: gscan2pdf

gscan2pdf (0.9.21-1ubuntu1) hardy; urgency=low

  * Fixed incorrect error saving image (LP: #195113)
  * Fixed random problems importing PDF (LP: #195416)
  * Set default frontend (LP: #195417)
  * Fixed about dialog (LP: #195418)

 -- Jeffrey Ratcliffe <email address hidden> Sun, 24 Feb 2008 17:56:19 +0100

Revision history for this message
Jeffrey Ratcliffe (jeffreyratcliffe) wrote :
Changed in gscan2pdf:
status: New → Confirmed
Revision history for this message
Daniel Holbach (dholbach) wrote :

Are the changes you introduce from Upstream? If not, it might be worth forwarding them upstream first to get input for them.

Revision history for this message
Jeffrey Ratcliffe (jeffreyratcliffe) wrote : Re: [Bug 195540] Re: Candidate revision gscan2pdf_0.9.21-1ubuntu1

On 26/02/2008, Daniel Holbach <email address hidden> wrote:
> Are the changes you introduce from Upstream? If not, it might be worth
> forwarding them upstream first to get input for them.

I am upstream. I didn't prepare a new upstream version because

a. hardy version freeze
b. it would have new features which aren't necessarily mature enough for hardy.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Great. If it landed in Upstream code, that's good enough to know.

Revision history for this message
Daniel Holbach (dholbach) wrote :

It'd be nice if you could adhere to https://wiki.ubuntu.com/DebianMaintainerField (update-maintainer of the ubuntu-dev-tools package should do it automatically for you).

Also it'd be great if you could list this bug in debian/changelog too, that way it'll be automatically closed on upload.

  * Bug fix upload (LP: #195540)
   - Fixed incorrect error saving image (LP: #195113)
   - Fixed random problems importing PDF (LP: #195416)
   - Set default frontend (LP: #195417)
   - Fixed about dialog (LP: #195418)
  * debian/control: adhere to https://wiki.ubuntu.com/DebianMaintainerField

is something I'd suggest.

Revision history for this message
Jeffrey Ratcliffe (jeffreyratcliffe) wrote :

On 26/02/2008, Daniel Holbach <email address hidden> wrote:
> It'd be nice if you could adhere to
> https://wiki.ubuntu.com/DebianMaintainerField (update-maintainer of the
> ubuntu-dev-tools package should do it automatically for you).

If you want, sure, but as I am also the Debian maintainer, I figured
it made more sense to leave it.

> Also it'd be great if you could list this bug in debian/changelog too,
> that way it'll be automatically closed on upload.

I should have thought of that myself. Perhaps
https://wiki.ubuntu.com/MOTU/Contributing could be updated as a
reminder. Would you like me to do this?

> * Bug fix upload (LP: #195540)
> - Fixed incorrect error saving image (LP: #195113)
> - Fixed random problems importing PDF (LP: #195416)
> - Set default frontend (LP: #195417)
> - Fixed about dialog (LP: #195418)
> * debian/control: adhere to https://wiki.ubuntu.com/DebianMaintainerField
>
> is something I'd suggest.

Fine, if you still want me to update the maintainer field. Let me
know, and I'll update the debdiff accordingly.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Please still change the Maintainer field - I know that in your case it's non-sensical, but dpkg-buildpackage won't let me build a source package *GRRRR*

https://wiki.ubuntu.com/MOTU/Contributing already mentions (LP: #123456) but maybe it should be more prominent. :-)

Thanks for all your work!

Revision history for this message
Jeffrey Ratcliffe (jeffreyratcliffe) wrote :

On 26/02/2008, Daniel Holbach <email address hidden> wrote:
> Please still change the Maintainer field - I know that in your case it's

Revised debdiff attached.

> https://wiki.ubuntu.com/MOTU/Contributing already mentions (LP: #123456)
> but maybe it should be more prominent. :-)

The closest I can find to this on that page is:

Add a line to the changelog for each change you make to the package.
For any that close launchpad bugs, end the line with "(LP:
#bugnumber)". For any that close Debian bugs, end the line with
"(Debian: #bugnumber)". If a fix closes both, only include the LP
entry.

So I added a couple of lines.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Hum... is this OK?

daniel@bert:~/gscan2pdf-0.9.21$ patch -p1 <../gscan2pdf_0.9.21-1ubuntu1.debdiff
patching file debian/changelog
patching file debian/control
patching file bin/gscan2pdf
patch unexpectedly ends in middle of line
Hunk #28 succeeded at 6681 with fuzz 1.
daniel@bert:~/gscan2pdf-0.9.21$

Revision history for this message
Daniel Holbach (dholbach) wrote :

Diffing it with the previous patch suggests it IS OK. The final newline is missing for some reason.

Thanks a lot for your outstanding work on this. You definitely ROCK!

Revision history for this message
Daniel Holbach (dholbach) wrote :

I just added
 XSBC-Original-Maintainer: Jeffrey Ratcliffe <email address hidden>
to debian/control.

Thanks again - uploaded.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gscan2pdf - 0.9.21-1ubuntu1

---------------
gscan2pdf (0.9.21-1ubuntu1) hardy; urgency=low

  * Bug fix upload (LP: #195540)
   - Fixed incorrect error saving image (LP: #195113)
   - Fixed random problems importing PDF (LP: #195416)
   - Set default frontend (LP: #195417)
   - Fixed about dialog (LP: #195418)
  * debian/control: adhere to https://wiki.ubuntu.com/DebianMaintainerField

 -- Jeffrey Ratcliffe <email address hidden> Tue, 26 Feb 2008 19:46:22 +0100

Changed in gscan2pdf:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers