correctly parse PMEM memory ranges to pass it to the kernel

Bug #1716424 reported by Mathieu Trudel-Lapierre on 2017-09-11
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
grub2 (Ubuntu)
Status tracked in Artful
Xenial
Critical
Mathieu Trudel-Lapierre
Zesty
High
Mathieu Trudel-Lapierre
Artful
Undecided
Unassigned
grub2-signed (Ubuntu)
Status tracked in Artful
Xenial
Undecided
Unassigned
Zesty
Undecided
Unassigned
Artful
Undecided
Unassigned

Bug Description

[Impact]
If trying to boot a system with PMEM:

"Unknown memory type 14, considering reserved"

The system will then not have access to EFIPresistentMemory ranges, because grub could not hand them over to the kernel to use. The resulting system would be missing a /dev/pmemN device.

Grub requires 4 cherry-picked commits:

    - debian/patches/git_pmem_really_mark_mem_reserved_3d2c8048.patch
    - debian/patches/git_pmem_translate_persistent_type_76ce1de7.patch
    - debian/patches/git_pmem_mmap_handle_pmem_c79c59f1.patch
    - debian/patches/git_pmem_efiemu_handle_pmem_ae3b83a4.patch

[Test case]
- Boot PMEM-enabled system with updated grub

[Regression Potential]
This changes handling of memory ranges in grub, and may lead to incorrectly passing memory to the kernel, or otherwise allowing allocation of memory within reserved ranges. This would typically lead to a failure to boot the kernel, or missing memory-based devices (such a missing /dev/pmem0).

Changed in grub2 (Ubuntu Artful):
status: New → Fix Released
Changed in grub2 (Ubuntu Xenial):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
importance: Undecided → Critical
status: New → Triaged
Changed in grub2 (Ubuntu Zesty):
status: New → Triaged
importance: Undecided → High
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
Changed in grub2 (Ubuntu Xenial):
status: Triaged → In Progress
Steve Langasek (vorlon) wrote :

Can you expand on the test case to explain how to configure such a pmem-enabled system?

Changed in grub2 (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-xenial

Hello Mathieu, or anyone else affected,

Accepted grub2 into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/grub2/2.02~beta2-36ubuntu3.13 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in grub2-signed (Ubuntu Artful):
status: New → Fix Released
Changed in grub2-signed (Ubuntu Xenial):
status: New → Fix Committed
Steve Langasek (vorlon) wrote :

Hello Mathieu, or anyone else affected,

Accepted grub2-signed into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/grub2-signed/1.66.13 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

As a part of the Stable Release Updates quality process a search for Launchpad bug reports using the version of grub2 from xenial-proposed was performed and bug 1719271 was found. Please investigate this bug report to ensure that a regression will not be created by this SRU. In the event that this is not a regression remove the "verification-failed" tag from this bug report and add the tag "bot-stop-nagging" to bug 1719271 (not this bug). Thanks!

tags: added: verification-failed

As a part of the Stable Release Updates quality process a search for Launchpad bug reports using the version of grub2-signed from xenial-proposed was performed and bug 1719622 was found. Please investigate that bug report to ensure that a regression will not be created by this SRU. In the event that this is not a regression remove the "verification-failed" tag from this bug report and add the tag "bot-stop-nagging" to bug 1719622 (not this bug). Thanks!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers