grub-ieee1275 should not change boot-device for every upgrade

Bug #1549064 reported by Mathieu Trudel-Lapierre on 2016-02-24
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
grub2 (Ubuntu)
Critical
Mathieu Trudel-Lapierre
Trusty
Critical
Unassigned
grub2-signed (Ubuntu)
Critical
Unassigned
Trusty
Critical
Unassigned

Bug Description

[Impact]
This affects all ppc64el users whenever they upgrade grub.

[Test case]
1) run 'nvram --print-config=boot-device'
2) upgrade grub-ieee1275
2) run 'nvram --print-config=boot-device'

The value should not change between runs, it should also not be touched at all (even if it's set to the same value).
This can be further verified by modifying boot-device to an arbitrary value before running the grub upgrade.

[Regression potential]
This has minimal potential for regression. It removes a code path which might otherwise break booting after upgrading grub on the affected systems. One possibility for regression is that if code paths are subsequently added to register openfirmware devices, this should be guarded with an 'if (update_nvram)' test to make sure it only ever happens when the --no-nvram flag is *NOT* passed to grub-install.

---

grub-ieee1275 should call grub-install with --no-nvram in postinst, so as not to modify boot-device in OpenFirmware everytime the grub package is updated.

description: updated
Changed in grub2 (Ubuntu):
status: New → In Progress
importance: Undecided → Critical
assignee: nobody → Mathieu Trudel-Lapierre (mathieu-tl)
Changed in grub2 (Ubuntu Trusty):
importance: Undecided → Critical
status: New → In Progress

Hello Mathieu, or anyone else affected,

Accepted grub2 into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/grub2/2.02~beta2-9ubuntu1.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in grub2 (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in grub2-signed (Ubuntu Trusty):
status: New → In Progress
Adam Conrad (adconrad) wrote :

Hello Mathieu, or anyone else affected,

Accepted grub2-signed into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/grub2-signed/1.34.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in grub2-signed (Ubuntu Trusty):
status: In Progress → Fix Committed
Changed in grub2-signed (Ubuntu Trusty):
importance: Undecided → Critical
Changed in grub2-signed (Ubuntu):
importance: Undecided → Critical

As a part of the Stable Release Updates quality process a search for Launchpad bug reports using the version of grub2-signed from trusty-proposed was performed and bug 1570438 was found. Please investigate this bug report to ensure that a regression will not be created by this SRU. In the event that this is not a regression remove the "verification-failed" tag from this bug report and add the tag "bot-stop-nagging" to bug 1570438 (not this bug). Thanks!

tags: added: verification-failed

As a part of the Stable Release Updates quality process a search for Launchpad bug reports using the version of grub2 from trusty-proposed was performed and bug 1590243 was found. Please investigate that bug report to ensure that a regression will not be created by this SRU. In the event that bug 1590243 is not a regression, tag it "bot-stop-nagging". Thanks!

It doesn't look to me like these crashes are relevant to this SRU -- they appear to have existed prior to it.

tags: removed: verification-failed

Verified that the fix works correctly.

tags: added: verification-done
removed: verification-needed
Martin Pitt (pitti) on 2016-06-21
Changed in grub2-signed (Ubuntu):
status: New → Invalid
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package grub2 - 2.02~beta2-9ubuntu1.8

---------------
grub2 (2.02~beta2-9ubuntu1.8) trusty; urgency=medium

  * debian/prep-bootdev.c: add prep-bootdev for use in postinst (and to help
    detecting the prep partition on ppc64el in general).
  * debian/rules: build the prep-bootdev binary for grub-ieee1275.
  * debian/control: add libparted-dev to Build-Depends for prep-bootdev.
  * debian/grub-ieee1275-bin.install.ppc64el.in: ship prep-bootdev.
  * debian/clean: clean up prep-bootdev.
  * debian/postinst.in: (LP: #1549064)
    - run prep-bootdev to have a device to point grub-ieee1275 to to install
      the new bootloader data to when calling grub-install.
    - run grub-install with --no-nvram to avoid clobbering the boot-device
      variable every time grub is updated.

 -- Mathieu Trudel-Lapierre <email address hidden> Wed, 24 Feb 2016 14:39:34 -0500

Changed in grub2 (Ubuntu Trusty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for grub2 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package grub2-signed - 1.34.9

---------------
grub2-signed (1.34.9) trusty; urgency=medium

  * Rebuild against grub-efi-amd64 2.02~beta2-9ubuntu1.8 (LP: #1549064)

 -- Mathieu Trudel-Lapierre <email address hidden> Thu, 25 Feb 2016 15:10:23 -0500

Changed in grub2-signed (Ubuntu Trusty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers