GRUB_CRYPTODISK_ENABLE should be GRUB_ENABLE_CRYPTODISK

Bug #1232237 reported by TJ
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
grub2 (Ubuntu)
Medium
Unassigned

Bug Description

There's a bug in the grub source package for encrypted disk support where the shell environment variable is incorrectly named as "GRUB_CRYPTODISK_ENABLE" when it should be "GRUB_ENABLE_CRYPTODISK". This prevents grub-install from correctly building an encrypted installation.

$ grep -rn GRUB_CRYPTODISK_ENABLE {/usr/share/grub/*,/usr/sbin/grub-install}
/usr/share/grub/grub-mkconfig_lib:74: if [ x$GRUB_CRYPTODISK_ENABLE = xy ]; then
/usr/share/grub/grub-mkconfig_lib:167: if [ x$GRUB_CRYPTODISK_ENABLE = xy ]; then
/usr/sbin/grub-install:707: if [ x$GRUB_CRYPTODISK_ENABLE = xy ]; then

An in-place workaround is:

$ sudo sed -i 's/GRUB_CRYPTODISK_ENABLE/GRUB_ENABLE_CRYPTODISK/g' {/usr/share/grub/grub-mkconfig_lib,/usr/sbin/grub-install}

Upstream now has a patch which does the same thing. See:

http://lists.gnu.org/archive/html/grub-devel/2013-09/msg00147.html

Related branches

Steve Langasek (vorlon)
affects: grub (Ubuntu) → grub2 (Ubuntu)
TJ (tj)
Changed in grub2 (Ubuntu):
status: Confirmed → Triaged
Colin Watson (cjwatson)
Changed in grub2 (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package grub2 - 2.02~beta2-5

---------------
grub2 (2.02~beta2-5) experimental; urgency=medium

  * Add a number of EFI debugging commands to the signed image (lsefi,
    lsefimmap, lsefisystab, lssal).
  * Add gfxterm_background to the signed image so that background_image
    works in UEFI Secure Boot mode. Thanks to syscon-hh for the report.

 -- Colin Watson <email address hidden> Mon, 27 Jan 2014 10:03:00 +0000

Changed in grub2 (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Phillip Susi (psusi) wrote :

I'm not sure why this was marked as fixed. The change log does not say it was, and the default file still does not have this setting in it, and new bugs continue to be reported.

Changed in grub2 (Ubuntu):
status: Fix Released → New
Revision history for this message
TJ (tj) wrote :

This was fixed in:

grub2 (2.00+20131208-1) experimental; urgency=low

  * New upstream snapshot.
    - Skip issuing cursor on/off sequences on Macs (closes: #683068).
    - Move grub-mknetdir to /usr/bin (closes: #688799).
    - Apply program name transformations at build-time rather than at
      run-time (closes: #696465).
    - Add info documentation for grub-mount (closes: #666427).
    - Clean up dangling references to grub-setup (LP: #1082045).
    - Avoid installing to sectors matching the signature of an Acer
      registration utility with several sightings in the wild (LP: #987022).
    - Document the need for GRUB_DEFAULT=saved in grub-set-default(8)
      (LP: #1102925).
    - Fix missing PVs if they don't contain an "interesting" LV (probably
      closes: #650724, #707613).
    - Reimplement grub-reboot to not depend on saved_entry (closes: #707695,
      LP: #704406).
    - Fix Ctrl-u handling to copy the killed characters to the kill buffer
      as UCS4 stored as grub_uint32_t rather than as 8-bit characters stored
      as char (closes: #710076).
    - Fix inconsistent use of GRUB_CRYPTODISK_ENABLE and
      GRUB_ENABLE_CRYPTODISK (LP: #1232237).

Changed in grub2 (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers