Activity log for bug #283520

Date Who What changed Old value New value Message
2008-10-15 01:38:35 Agostino Russo bug added bug
2008-10-15 01:39:09 Agostino Russo grub-installer: status New Triaged
2008-10-15 01:39:09 Agostino Russo grub-installer: importance Undecided High
2008-10-15 01:39:09 Agostino Russo grub-installer: statusexplanation
2008-10-15 01:41:50 Agostino Russo grub-installer: status Triaged Confirmed
2008-10-15 02:15:36 Agostino Russo description Binary package hint: grub-installer Seems like the old code was removed in recent revisions, in particular there used to be the following snippet which is required by wubi if db_get grub-installer/bootdev_directory && [ "$RET" ]; then sed -i "/^# groot=/s:).*:)$RET:" $ROOT/boot/grub/$menu_file need_update_grub=1 fi Without the above, groot is not correct for loopinstallations. Binary package hint: grub-installer Loop-installations expect a root argument such as: root ()/ubuntu/disks There following code used to replace the existing groot to produce the above string if db_get grub-installer/bootdev_directory && [ "$RET" ]; then sed -i "/^# groot=/s:).*:)$RET:" $ROOT/boot/grub/$menu_file need_update_grub=1 fi But because of the way the new update-grub handles of groot/boot_device, the groot string returned is formatted differently (there are no "()") and the above sed command fails. The following should work: if db_get grub-installer/bootdev_directory && [ "$RET" ]; then sed -i "s:^# groot=.*:# groot=()$RET:" $ROOT/boot/grub/$menu_file need_update_grub=1 fi
2008-10-15 02:28:07 Agostino Russo description Binary package hint: grub-installer Loop-installations expect a root argument such as: root ()/ubuntu/disks There following code used to replace the existing groot to produce the above string if db_get grub-installer/bootdev_directory && [ "$RET" ]; then sed -i "/^# groot=/s:).*:)$RET:" $ROOT/boot/grub/$menu_file need_update_grub=1 fi But because of the way the new update-grub handles of groot/boot_device, the groot string returned is formatted differently (there are no "()") and the above sed command fails. The following should work: if db_get grub-installer/bootdev_directory && [ "$RET" ]; then sed -i "s:^# groot=.*:# groot=()$RET:" $ROOT/boot/grub/$menu_file need_update_grub=1 fi Binary package hint: grub-installer Loop-installations expect a root argument such as: root ()/ubuntu/disks There following code used to replace the existing groot to produce the above string if db_get grub-installer/bootdev_directory && [ "$RET" ]; then sed -i "/^# groot=/s:).*:)$RET:" $ROOT/boot/grub/$menu_file need_update_grub=1 fi But because of the recent changes in update-grub that provide UUID support, groot/boot_device are handled differently, and in particular the groot string returned is a UUID with no "()", hence the above sed command fails. The following should work: if db_get grub-installer/bootdev_directory && [ "$RET" ]; then sed -i "s:^# groot=.*:# groot=()$RET:" $ROOT/boot/grub/$menu_file need_update_grub=1 fi
2008-10-15 02:28:24 Agostino Russo grub-installer: status Confirmed Triaged
2008-10-15 08:25:10 Launchpad Janitor grub-installer: status Triaged Fix Released
2008-10-15 09:26:01 Agostino Russo grub-installer: status Fix Released In Progress
2008-10-15 09:26:01 Agostino Russo grub-installer: statusexplanation Colin, I doubt that grub4dos supports UUIDs (haven't tested that), and even if it does, things will be a bit tricky, since A) in case of updates we need to ship a new grub4dos (wubildr & co, which, by the way, might not be under /host) B) wubi actually uses a first embedded menu.lst that uses heuristics to set the bootloader root and then loads a second menu.lst (the one visible as /boot/grub/menu.lst) within that root. The second menu.lst does not set root, it only sets the relative path, which is why we use "()". Such heuristic approach, while not bullet proof for obvious reasons, seemed to work ok also with multiple disks. Hence i would suggest to stick with "root ()/relative/path" for this release.
2008-10-15 10:20:05 Launchpad Janitor grub-installer: status In Progress Fix Released
2009-11-17 18:58:00 Ubuntu QA Website tags iso-testing
2009-12-05 08:03:39 Launchpad Janitor branch linked lp:ubuntu/grub-installer