| 2017-01-12 17:31:45 |
bugproxy |
bug |
|
|
added bug |
| 2017-01-12 17:31:49 |
bugproxy |
tags |
|
architecture-ppc64le bugnameltc-150508 severity-high targetmilestone-inin16042 |
|
| 2017-01-12 17:31:50 |
bugproxy |
attachment added |
|
grub-installer_prep-nvme-disk_xenial.debdiff https://bugs.launchpad.net/bugs/1656048/+attachment/4803508/+files/grub-installer_prep-nvme-disk_xenial.debdiff |
|
| 2017-01-12 17:31:52 |
bugproxy |
attachment added |
|
grub-installer_prep-nvme-disk_zesty.debdiff https://bugs.launchpad.net/bugs/1656048/+attachment/4803509/+files/grub-installer_prep-nvme-disk_zesty.debdiff |
|
| 2017-01-12 17:31:53 |
bugproxy |
ubuntu: assignee |
|
Taco Screen team (taco-screen-team) |
|
| 2017-01-12 17:31:56 |
bugproxy |
affects |
ubuntu |
debian-installer (Ubuntu) |
|
| 2017-01-12 21:16:46 |
Mathieu Trudel-Lapierre |
debian-installer (Ubuntu): assignee |
Taco Screen team (taco-screen-team) |
Mathieu Trudel-Lapierre (cyphermox) |
|
| 2017-01-12 21:16:51 |
Mathieu Trudel-Lapierre |
debian-installer (Ubuntu): status |
New |
In Progress |
|
| 2017-01-12 21:16:54 |
Mathieu Trudel-Lapierre |
debian-installer (Ubuntu): importance |
Undecided |
High |
|
| 2017-01-12 21:16:59 |
Mathieu Trudel-Lapierre |
nominated for series |
|
Ubuntu Xenial |
|
| 2017-01-12 21:16:59 |
Mathieu Trudel-Lapierre |
bug task added |
|
debian-installer (Ubuntu Xenial) |
|
| 2017-01-12 21:17:27 |
Mathieu Trudel-Lapierre |
affects |
debian-installer (Ubuntu) |
grub-installer (Ubuntu) |
|
| 2017-01-16 20:57:14 |
Launchpad Janitor |
grub-installer (Ubuntu): status |
In Progress |
Fix Released |
|
| 2017-01-17 01:56:18 |
Mathieu Trudel-Lapierre |
description |
== Comment: #0 - Mauricio Faria De Oliveira - 2017-01-12 05:22:08 ==
---Problem Description---
On ppc64el, the grub-installer script attempts to detect which PReP partition is in the same disk as of the installed system, in order to install grub into it.
This check is not working properly for NVMe devices, and needs an update.
It might result in overwriting the PReP partition of another disk, possibly another Linux distro/version, which is unrelated to the current installation.
Patches for Xenial and Zesty are attached.
Problem example:
---
- PReP partition actually is '/dev/nvme1n1p1'
- PReP partition detected is '/dev/sda1'
~ # /usr/lib/grub-installer/prep-bootdev -l
/dev/sda1
/dev/nvme1n1p1
/dev/nvme0n1p1
~ # grep grub-install /var/log/syslog
...
Jan 11 22:17:25 main-menu[518]: INFO: Menu item 'grub-installer' selected
Jan 11 22:17:25 grub-installer: info: architecture: ppc64el/chrp_ibm
Jan 11 22:17:29 grub-installer: info: Identified partition label for /dev/nvme1n1p2: gpt
Jan 11 22:17:29 grub-installer: info: Wiping PReP partition /dev/sda1
...
Jan 11 22:17:33 grub-installer: info: Running chroot /target grub-install --force "/dev/sda1"
...
Jan 11 22:17:33 grub-installer: info: grub-install ran successfully
~ # in-target ofpathname /dev/sda1
~ # in-target nvram --print-config=boot-device
~ # tail -n2 /var/log/syslog
... in-target: /pci@800000020000015/pci1014,034A@0/sas/disk@5000c50067b1166b
... in-target: /pci@800000020000015/pci1014,034A@0/sas/disk@5000c50067b1166b
Patch applied:
---
~ # grep grub-installer /var/log/syslog
...
Jan 11 23:59:25 main-menu[518]: INFO: Menu item 'grub-installer' selected
Jan 11 23:59:25 grub-installer: info: architecture: ppc64el/chrp_ibm
Jan 11 23:59:27 grub-installer: info: Identified partition label for /dev/nvme1n1p2: gpt
Jan 11 23:59:27 grub-installer: info: Wiping PReP partition /dev/nvme1n1p1
...
Jan 11 23:59:30 grub-installer: info: Running chroot /target grub-install --force "/dev/nvme1n1p1"
...
Jan 11 23:59:31 grub-installer: info: grub-install ran successfully
~ # in-target nvram --print-config=boot-device
~ # tail -n1 /var/log/syslog
... in-target: /pci@800000020000028/pci1bb1,121@0/namespace@1
After reboot of installation done:
0 > printenv boot-device
-------------- Partition: common -------- Signature: 0x70 ---------------
boot-device /pci@800000020000028/pci1bb1,121@0/namespace@1
== Comment: #1 - Mauricio Faria De Oliveira <mauricfo@br.ibm.com> - 2017-01-12 05:24:08 ==
Patch for Xenial
== Comment: #2 - Mauricio Faria De Oliveira <mauricfo@br.ibm.com> - 2017-01-12 05:24:26 ==
Patch for Zesty. |
[Impact]
NVMe installs on ppc64el for PReP.
[Test case]
Attempt to install Ubuntu on a ppc64el where a PReP partition is required; make sure to put the new PReP partition on the NVMe disk. See Problem Description below.
[Regression Potential]
Any failure to install PReP on ppc64el on a system with NVMe should be considered a regression of this bug.
----
== Comment: #0 - Mauricio Faria De Oliveira - 2017-01-12 05:22:08 ==
---Problem Description---
On ppc64el, the grub-installer script attempts to detect which PReP partition is in the same disk as of the installed system, in order to install grub into it.
This check is not working properly for NVMe devices, and needs an update.
It might result in overwriting the PReP partition of another disk, possibly another Linux distro/version, which is unrelated to the current installation.
Patches for Xenial and Zesty are attached.
Problem example:
---
- PReP partition actually is '/dev/nvme1n1p1'
- PReP partition detected is '/dev/sda1'
~ # /usr/lib/grub-installer/prep-bootdev -l
/dev/sda1
/dev/nvme1n1p1
/dev/nvme0n1p1
~ # grep grub-install /var/log/syslog
...
Jan 11 22:17:25 main-menu[518]: INFO: Menu item 'grub-installer' selected
Jan 11 22:17:25 grub-installer: info: architecture: ppc64el/chrp_ibm
Jan 11 22:17:29 grub-installer: info: Identified partition label for /dev/nvme1n1p2: gpt
Jan 11 22:17:29 grub-installer: info: Wiping PReP partition /dev/sda1
...
Jan 11 22:17:33 grub-installer: info: Running chroot /target grub-install --force "/dev/sda1"
...
Jan 11 22:17:33 grub-installer: info: grub-install ran successfully
~ # in-target ofpathname /dev/sda1
~ # in-target nvram --print-config=boot-device
~ # tail -n2 /var/log/syslog
... in-target: /pci@800000020000015/pci1014,034A@0/sas/disk@5000c50067b1166b
... in-target: /pci@800000020000015/pci1014,034A@0/sas/disk@5000c50067b1166b
Patch applied:
---
~ # grep grub-installer /var/log/syslog
...
Jan 11 23:59:25 main-menu[518]: INFO: Menu item 'grub-installer' selected
Jan 11 23:59:25 grub-installer: info: architecture: ppc64el/chrp_ibm
Jan 11 23:59:27 grub-installer: info: Identified partition label for /dev/nvme1n1p2: gpt
Jan 11 23:59:27 grub-installer: info: Wiping PReP partition /dev/nvme1n1p1
...
Jan 11 23:59:30 grub-installer: info: Running chroot /target grub-install --force "/dev/nvme1n1p1"
...
Jan 11 23:59:31 grub-installer: info: grub-install ran successfully
~ # in-target nvram --print-config=boot-device
~ # tail -n1 /var/log/syslog
... in-target: /pci@800000020000028/pci1bb1,121@0/namespace@1
After reboot of installation done:
0 > printenv boot-device
-------------- Partition: common -------- Signature: 0x70 ---------------
boot-device /pci@800000020000028/pci1bb1,121@0/namespace@1
== Comment: #1 - Mauricio Faria De Oliveira <mauricfo@br.ibm.com> - 2017-01-12 05:24:08 ==
Patch for Xenial
== Comment: #2 - Mauricio Faria De Oliveira <mauricfo@br.ibm.com> - 2017-01-12 05:24:26 ==
Patch for Zesty. |
|
| 2017-01-17 01:57:01 |
Mathieu Trudel-Lapierre |
grub-installer (Ubuntu Xenial): importance |
Undecided |
High |
|
| 2017-01-17 01:57:06 |
Mathieu Trudel-Lapierre |
grub-installer (Ubuntu Xenial): status |
New |
In Progress |
|
| 2017-01-17 01:57:10 |
Mathieu Trudel-Lapierre |
grub-installer (Ubuntu Xenial): assignee |
|
Mathieu Trudel-Lapierre (cyphermox) |
|
| 2017-01-17 16:57:45 |
Mathieu Trudel-Lapierre |
grub-installer (Ubuntu): milestone |
|
ubuntu-17.01 |
|
| 2017-01-25 06:40:49 |
Steve Langasek |
grub-installer (Ubuntu Xenial): status |
In Progress |
Fix Committed |
|
| 2017-01-25 06:40:52 |
Steve Langasek |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2017-01-25 06:40:56 |
Steve Langasek |
bug |
|
|
added subscriber SRU Verification |
| 2017-01-25 06:41:10 |
Steve Langasek |
tags |
architecture-ppc64le bugnameltc-150508 severity-high targetmilestone-inin16042 |
architecture-ppc64le bugnameltc-150508 severity-high targetmilestone-inin16042 verification-needed |
|
| 2017-01-27 13:19:25 |
bugproxy |
tags |
architecture-ppc64le bugnameltc-150508 severity-high targetmilestone-inin16042 verification-needed |
architecture-ppc64le bugnameltc-150508 severity-high targetmilestone-inin16042 verification-done |
|
| 2017-02-09 03:39:15 |
Launchpad Janitor |
grub-installer (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2017-02-09 03:39:19 |
Chris J Arges |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
