Re-enable dLeyna grilo plugin

[Alessandro Astone]

== SRU Justification ==

[Impact]

Not recollecting the full history but at least in 22.04/Jammy LTS Ubuntu supported access to DNLA services for example via rhythmbox through grilo. At some point (before 24.04 Noble LTS) this was disabled (compile time configuration) upstream support was expected to have gone away. This changed now and support has been turned on again in Plucky.

This leaves a gap where upgrading from Jammy to Noble regresses user-experience. That could be avoided by simply restoring the configuration to what is was in Jammy.

I double checked the setup and found that Jammy had the exact same packaging as it is being proposed. The split of grilo-plugins-0.3-base (main) and grilo-plugins-0.3-extra (universe) did exist and also the recommends for dleyna-server by grilo-plugins-0.3-extra.

[Test Plan]

This requires a DLNA source (eg. minidlna) being present in the local network. With the current version of grilo-plugins-*-extra this will not be detected when starting rhythmbox. With the proposed changes it will find the DLNA source.

I did apply the proposed diff to the current grilo-plugins in Noble, compiled them and was able to access my DLNA music files again.

[Where Problems Could Occur]

This will likely re-instate some/all previously known issues with DLNA support.

In my case there is a very minor issue that the self-made NAS which also runs the DLNA service shows up twice. But that is because its exposed through a .local and made-up local domain. All my fault here.

Otherwise this does not really change code, merely modify the configure run before compiling to enable support as it was before.

[Other Info]

 grilo-plugins-0.3-extra | 0.3.14-1ubuntu2 | jammy/universe | amd64, arm64, armhf, ppc64el, riscv64, s390x
 grilo-plugins-0.3-extra | 0.3.16-1.1ubuntu6 | noble/universe | amd64, arm64, armhf, ppc64el, riscv64, s390x

https://launchpad.net/~smb/+archive/ubuntu/noble/+sourcepub/17113585/+listing-archive-extra

--- Original Description --

The dLeyna grilo plugin was disabled because the dleyna-server package was dropped in Ubuntu after being deprecated upstream.
However dleyna now has a new maintainer upstream and is maintained in Ubuntu at https://launchpad.net/ubuntu/+source/dleyna, so it can be enabled again.

This will be part of the grilo-plugins-0.3-extra package (universe), like before it was dropped.

[Alessandro Astone (aleasto)]

Attaching debdiff.
It also includes a no-change merge with debian, for "Switch to liblua5.4-dev" which we already had in Ubuntu.

I've forwarded the "Recommend dleyna-server" change to debian here: https://salsa.debian.org/berto/grilo-plugins/-/merge_requests/6

[Sebastien Bacher (seb128)]

Thanks!

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "grilo-plugins_0.3.16-4ubuntu1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Launchpad Janitor (janitor)]

This bug was fixed in the package grilo-plugins - 0.3.16-4ubuntu1

---------------
grilo-plugins (0.3.16-4ubuntu1) plucky; urgency=medium

  * Merge with Debian unstable. Remaining changes:
    - Split package into -base and -extra (Closes: #805609)
  * Re-enable dLeyna plugin (LP: #2093324)
  * Recommend dleyna-server (LP: #2093324)

grilo-plugins (0.3.16-4) unstable; urgency=medium

  * debian/control: Switch to liblua5.4-dev (Closes: #1087571).

 -- Alessandro Astone <email address hidden> Thu, 09 Jan 2025 17:06:03 +0100

[Stefan Bader (smb)]

Could we get this change back into at least 24.04/Noble? It is in the same stage there (24.04 and 24.10 share the same version). I tested on noble that the changes done for Plucky also work there and enables to find my minidlna server at home.

[Stefan Bader (smb)]

Assuming noble being forward copied to oracular (otherwise the version number needs to be adjusted) the following debdiff would enable DNLA for rhythmbox (using grilo-plugin).

[Alessandro Astone (aleasto)]

Thank you for testing!

I don't think this qualifies for an SRU... But I'm not a sponsor so not my call.

[Stefan Bader (smb)]

I would have agreed years ago. Feels less strict often these days. But one could argue this is a regression release for Noble since 22.04/Jammy LTS did support DLNA (once installing the grilo libs completely, but that is a different issue).

[Lukas Märdian (slyon)]

I see that the dleyna-server binary is built out of src:dleyna starting with Noble.

In Debian (https://salsa.debian.org/berto/grilo-plugins/-/merge_requests/6) the "Recommends: dleyna-server" was downgraded to a "Suggests: dleyna-server" and we should probably do the same in Ubuntu, to avoid unnecessary delta and to avoid a component-mismatch, as grilo-plugins (from "main") cannot Depend/Recommend dleyna (from "universe").

@smb, if you want to push this for SRU, please elaborate on your rationale by filling the full SRU template [1] in the bug description. Should a SRU be rejected, it could still be pushed for noble-backports [2].

I'm removing the ~ubuntu-sponsors subscriber (for now), as it's already sponsored into Plucky and not yet ready for SRU, due to the missing template/paperwork. Feel free to re-subscribe ~ubuntu-sponsors, once it's ready for SRU.

[1] https://documentation.ubuntu.com/sru/en/latest/reference/bug-template/
[2] https://wiki.ubuntu.com/UbuntuBackports

[Alessandro Astone (aleasto)]

> In Debian (https://salsa.debian.org/berto/grilo-plugins/-/merge_requests/6) the "Recommends: dleyna-server" was downgraded to a "Suggests: dleyna-server" and we should probably do the same in Ubuntu, to avoid unnecessary delta and to avoid a component-mismatch, as grilo-plugins (from "main") cannot Depend/Recommend dleyna (from "universe").

Just one note on this: there is no component-mismatch because the dleyna plugin is already part of a different binary package `grilo-plugins-0.3-extra`, which is already a delta from Debian dating all the way back from the initial MIR for grilo, where plugins were split into a "base" set and an "extra" set.

[Lukas Märdian (slyon)]

Thanks for providing additional context.

I can confirm that the new "Recommends: dleyna-server" is what we have in Plucky today and what we have in Jammy. This is OK as the "grilo-plugins-0.3-extra" binary is indeed split-off and in "universe" (despite src:grilo-plugins being in "main"). So does not introduce a component-mismatch! Sorry for my confusion.

[Lukas Märdian (slyon)]

Thanks @smb for providing a debdiff to fix this!

After my statement from above (comment #11) and the updated SRU template, this LGTM!

We currently have the same version of grilo-plugins in Noble & Oracular, so your patch applies to both, but we need to adopt the version string accordingly to provide a clean upgrade path, e.g.:

Oracular: 0.3.16-1.1ubuntu6.1~24.10.1
Noble: 0.3.16-1.1ubuntu6.1~24.04.1

=> I fixed this for you! And uploaded to Oracular and Noble for SRU queue review.

[Timo Aaltonen (tjaalton)]

Hello Alessandro, or anyone else affected,

Accepted grilo-plugins into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/grilo-plugins/0.3.16-1.1ubuntu6.1~24.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Alessandro, or anyone else affected,

Accepted grilo-plugins into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/grilo-plugins/0.3.16-1.1ubuntu6.1~24.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Stefan Bader (smb)]

ii grilo-plugins-0.3 0.3.16-1.1ubuntu6.1~24.04.1 all transitional package
ii grilo-plugins-0.3-base:amd64 0.3.16-1.1ubuntu6.1~24.04.1 amd64 Framework for discovering and browsing media - Plugins
ii grilo-plugins-0.3-extra:amd64 0.3.16-1.1ubuntu6.1~24.04.1 amd64 Framework for discovering and browsing media - Extra Plugins

Confirming that with the above version installed rhythmbox is showing my home DLNA server in the shared section. Before that was not true.

[Andreas Hasenack (ahasenack)]

This is blocked on the oracular verification being done.

[Stefan Bader (smb)]

Ok, took a while since I had to get a VM set up with transparent bridging. But repeated the test now with oracular and the 0.3.16-1.1ubuntu6.1~24.10.1 versions of grilo-plugins installed into the oracular desktop VM and can confirm that this is able to access the DLNA files.

[Launchpad Janitor (janitor)]

This bug was fixed in the package grilo-plugins - 0.3.16-1.1ubuntu6.1~24.10.1

---------------
grilo-plugins (0.3.16-1.1ubuntu6.1~24.10.1) oracular; urgency=medium

  * Re-enable dLeyna plugin (LP: #2093324)
  * Recommend dleyna-server (LP: #2093324)

 -- Stefan Bader <email address hidden> Mon, 17 Mar 2025 12:05:34 +0100

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for grilo-plugins has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package grilo-plugins - 0.3.16-1.1ubuntu6.1~24.04.1

---------------
grilo-plugins (0.3.16-1.1ubuntu6.1~24.04.1) noble; urgency=medium

  * Re-enable dLeyna plugin (LP: #2093324)
  * Recommend dleyna-server (LP: #2093324)

 -- Stefan Bader <email address hidden> Mon, 17 Mar 2025 12:05:34 +0100