Comment 75 for bug 7906

tags 181378 patch
forcemerge 181378 442882
thanks

Hello,

Please find attached updated patches for grep-2.5.3~dfsg:
 * 64-egf-speedup.patch
   This provides the speedup when the DFA algorithm is not used.
   But the DFA algorithm is used for most grep execution.
   (So there are no speed improvements if 65-dfa-optional.patch is not
   applied)
 * 65-dfa-optional.patch
   This disables the DFA algorithm, which can be very slow in UTF-8
   environments. The DFA algorithm can be enabled with an environment
   variable.
   (This patch is not valid if 64-egf-speedup.patch is not applied)

These two patches are tightly coupled and must be applied together.

There used to be also two other patches in the 2.5.1, which improve the
results of the grep testsuite:
 * 66-match_icase.patch
   This patch fixes some some usage of the -i option.
   It could probably be applied without the previous patches.

 * 67-w.patch
   This patch fixes the -w option.
   This probably fixes issues introduced by the first two patches.

I tried to add a few comments in the header of the patches.

With the 4 patches applied, 3 tests fail in the grep testsuite, but the
results are better than an unpatched upstream.

It could be nice to have a patch to split the testsuite in two categories:
known working test case) and known broken test cases (i.e. in the spencer1
testsuite, I don't expect the handling of case insensitive matches for non
latin characters to be fixed in a near future).
This would allow to run the testsuite at build time and detect regressions
in later uploads.
There are currently too many test cases/sub cases that fail to consider
the testsuite as useful at build time.

I'm also concerned about the maintainability of these patches.
I will try reduce their size and comment them, but do not wait for this
for an upload (I won't have time in the next two weeks).

With these 4 patches applied, there are probably a few bugs in the BTS
which can be closed (obviously the "grep too slow" bugs, but you should
also check if the locale dependent bugs (or the bugs which involve the -i
or -w options) are still reproducible)

I will subscribe to the PTS for grep, but do not hesitate to ping me if
these patches broke grep.

Kind Regards,
--
Nekral