2016-02-19 11:05:08 |
Stefan Bader |
bug |
|
|
added bug |
2016-02-19 11:05:08 |
Stefan Bader |
attachment added |
|
Testfile that causes the problem https://bugs.launchpad.net/bugs/1547466/+attachment/4575500/+files/grant_table.h |
|
2016-02-19 11:07:05 |
Stefan Bader |
grep (Ubuntu): importance |
Undecided |
High |
|
2016-02-24 19:34:02 |
Brian Murray |
grep (Ubuntu): status |
New |
Incomplete |
|
2016-02-24 19:34:10 |
Brian Murray |
bug |
|
|
added subscriber Brian Murray |
2016-02-25 07:35:50 |
Stefan Bader |
grep (Ubuntu): status |
Incomplete |
New |
|
2016-03-02 18:48:59 |
Launchpad Janitor |
grep (Ubuntu): status |
New |
Confirmed |
|
2016-03-02 18:49:12 |
Brian Murray |
tags |
xenial |
wily xenial |
|
2016-03-10 20:59:58 |
Wolfgang Hänsch |
bug |
|
|
added subscriber Wolfgang Hänsch |
2016-03-11 22:53:36 |
Brian Murray |
tags |
wily xenial |
rls-x-incoming wily xenial |
|
2016-04-25 16:57:41 |
Brian Murray |
grep (Ubuntu): assignee |
|
Martin Pitt (pitti) |
|
2016-04-25 19:01:05 |
Martin Pitt |
nominated for series |
|
Ubuntu Xenial |
|
2016-04-25 19:01:05 |
Martin Pitt |
bug task added |
|
grep (Ubuntu Xenial) |
|
2016-04-25 19:01:05 |
Martin Pitt |
nominated for series |
|
Ubuntu Yakkety |
|
2016-04-25 19:01:05 |
Martin Pitt |
bug task added |
|
grep (Ubuntu Yakkety) |
|
2016-04-27 14:06:16 |
Martin Pitt |
bug watch added |
|
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800670 |
|
2016-04-27 14:06:16 |
Martin Pitt |
bug task added |
|
grep (Debian) |
|
2016-04-27 14:09:07 |
Martin Pitt |
grep (Ubuntu Xenial): assignee |
|
Martin Pitt (pitti) |
|
2016-04-27 14:09:20 |
Martin Pitt |
grep (Ubuntu Yakkety): status |
Confirmed |
Fix Released |
|
2016-04-27 14:10:26 |
Martin Pitt |
description |
I noticed this staring to happen in Xenial about two days ago. When running sbuild (or now the buildd, too), the build breaks when trying to compile a generated file. I traced the problem down to grep suddenly acting weird. When not having any language set (or a non-UTF8 mode) it will start printing some lines of a source file and then suddenly end that by printing "Binary file ... matches".
With the attached file, the difference can be observed (running Xenial):
LANG=C grep -v xxx grant_table.h
and
LANG=C.UTF-8 grep -v xxx grant_table.h |
I noticed this starting to happen in Xenial about two days ago. When running sbuild (or now the buildd, too), the build breaks when trying to compile a generated file. I traced the problem down to grep suddenly acting weird. When not having any language set (or a non-UTF8 mode) it will start printing some lines of a source file and then suddenly end that by printing "Binary file ... matches".
With the attached file, the difference can be observed (running Xenial):
LANG=C grep -v xxx grant_table.h
and
LANG=C.UTF-8 grep -v xxx grant_table.h
Upstream bug: http://bugs.gnu.org/23234 |
|
2016-04-27 14:11:15 |
Martin Pitt |
grep (Ubuntu Xenial): status |
New |
In Progress |
|
2016-04-27 14:44:41 |
Martin Pitt |
description |
I noticed this starting to happen in Xenial about two days ago. When running sbuild (or now the buildd, too), the build breaks when trying to compile a generated file. I traced the problem down to grep suddenly acting weird. When not having any language set (or a non-UTF8 mode) it will start printing some lines of a source file and then suddenly end that by printing "Binary file ... matches".
With the attached file, the difference can be observed (running Xenial):
LANG=C grep -v xxx grant_table.h
and
LANG=C.UTF-8 grep -v xxx grant_table.h
Upstream bug: http://bugs.gnu.org/23234 |
I noticed this staring to happen in Xenial about two days ago. When running sbuild (or now the buildd, too), the build breaks when trying to compile a generated file. I traced the problem down to grep suddenly acting weird. When not having any language set (or a non-UTF8 mode) it will start printing some lines of a source file and then suddenly end that by printing "Binary file ... matches".
With the attached file, the difference can be observed (running Xenial):
LANG=C grep -v xxx grant_table.h
and
LANG=C.UTF-8 grep -v xxx grant_table.h
SRU INFORMATION
===============
Upstream fixes:
- http://git.savannah.gnu.org/cgit/grep.git/commit/?id=d8a366218 (but depends on previous patches and is not sufficient by itself)
- http://git.savannah.gnu.org/cgit/grep.git/commit/?id=d8a366218 (tests+doc)
Test case:
Call grep on a file or a string with non-ASCII characters in the C locale:
$ echo 'héll☺ ≥x' | LC_ALL=C grep .
In xenial this just shows "Binary file (standard input) matches", with the fix it should show the actual input string (with some garbled output of course as the UTF-8 chars cannot be displayed in C)
Regression potential: grep is being used in tons of places; during xenial we had to fix/put a "use grep -a" workaround into a lot of packages to fix the fallout from grep 2.23 which introduced this. That said, as a result of "Binary file matches" does not give any more information than the actual string match, and scripts which get along with this answer most likely just check the exit code anyway (which does not change), the risk is bearable. |
|
2016-04-27 21:19:10 |
Martin Pitt |
description |
I noticed this staring to happen in Xenial about two days ago. When running sbuild (or now the buildd, too), the build breaks when trying to compile a generated file. I traced the problem down to grep suddenly acting weird. When not having any language set (or a non-UTF8 mode) it will start printing some lines of a source file and then suddenly end that by printing "Binary file ... matches".
With the attached file, the difference can be observed (running Xenial):
LANG=C grep -v xxx grant_table.h
and
LANG=C.UTF-8 grep -v xxx grant_table.h
SRU INFORMATION
===============
Upstream fixes:
- http://git.savannah.gnu.org/cgit/grep.git/commit/?id=d8a366218 (but depends on previous patches and is not sufficient by itself)
- http://git.savannah.gnu.org/cgit/grep.git/commit/?id=d8a366218 (tests+doc)
Test case:
Call grep on a file or a string with non-ASCII characters in the C locale:
$ echo 'héll☺ ≥x' | LC_ALL=C grep .
In xenial this just shows "Binary file (standard input) matches", with the fix it should show the actual input string (with some garbled output of course as the UTF-8 chars cannot be displayed in C)
Regression potential: grep is being used in tons of places; during xenial we had to fix/put a "use grep -a" workaround into a lot of packages to fix the fallout from grep 2.23 which introduced this. That said, as a result of "Binary file matches" does not give any more information than the actual string match, and scripts which get along with this answer most likely just check the exit code anyway (which does not change), the risk is bearable. |
I noticed this staring to happen in Xenial about two days ago. When running sbuild (or now the buildd, too), the build breaks when trying to compile a generated file. I traced the problem down to grep suddenly acting weird. When not having any language set (or a non-UTF8 mode) it will start printing some lines of a source file and then suddenly end that by printing "Binary file ... matches".
With the attached file, the difference can be observed (running Xenial):
LANG=C grep -v xxx grant_table.h
and
LANG=C.UTF-8 grep -v xxx grant_table.h
SRU INFORMATION
===============
Upstream fixes:
- http://git.savannah.gnu.org/cgit/grep.git/commit/?id=d8a366218 (but depends on previous patches and is not sufficient by itself)
- http://git.savannah.gnu.org/cgit/grep.git/commit/?id=d8a366218 (tests+doc)
Test case:
Call grep on a file or a string with non-ASCII characters in the C locale:
$ echo 'héll☺ ≥x' | LC_ALL=C grep .
In xenial this just shows "Binary file (standard input) matches", with the fix it should show the actual input string (with some garbled output of course as the UTF-8 chars cannot be displayed in C)
Regression potential: grep is being used in tons of places; during xenial we had to fix/put a "use grep -a" workaround into a lot of packages to fix the fallout from grep 2.23 which introduced this. That said, as a result of "Binary file matches" does not give any more information than the actual string match, and scripts which get along with this answer most likely just check the exit code anyway (which does not change), the risk is bearable.
We will soon do a test rebuild in yakkety with gcc-6 and grep 2.25, and will sift through the results to identify new FTBFS that are due to grep 2.25. This SRU should not be released until this happens. |
|
2016-04-27 23:46:59 |
Bug Watch Updater |
grep (Debian): status |
Unknown |
Fix Released |
|
2016-04-29 12:19:15 |
Timo Aaltonen |
grep (Ubuntu Xenial): status |
In Progress |
Fix Committed |
|
2016-04-29 12:19:17 |
Timo Aaltonen |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
2016-04-29 12:19:22 |
Timo Aaltonen |
bug |
|
|
added subscriber SRU Verification |
2016-04-29 12:19:29 |
Timo Aaltonen |
tags |
rls-x-incoming wily xenial |
rls-x-incoming verification-needed wily xenial |
|
2016-04-29 18:30:58 |
Wolfgang Hänsch |
removed subscriber Wolfgang Hänsch |
|
|
|
2016-06-08 06:23:22 |
Mathew Hodson |
grep (Ubuntu Xenial): importance |
Undecided |
High |
|
2016-06-08 06:27:23 |
Mathew Hodson |
tags |
rls-x-incoming verification-needed wily xenial |
regression-release rls-x-incoming verification-needed wily xenial |
|
2016-06-08 09:24:22 |
Stefan Bader |
tags |
regression-release rls-x-incoming verification-needed wily xenial |
regression-release rls-x-incoming verification-done wily xenial |
|
2016-06-08 16:25:26 |
Launchpad Janitor |
grep (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
2016-06-08 16:25:31 |
Chris J Arges |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
2016-06-10 08:12:47 |
Martin Pitt |
summary |
grep switches into binary mode while processing a text file |
grep switches into binary mode while processing a text file under the C locale |
|