gravitywars has no .desktop file

Bug #174906 reported by Siegfried Gevatter on 2007-12-08
4
Affects Status Importance Assigned to Milestone
gravitywars (Debian)
Fix Released
Unknown
gravitywars (Ubuntu)
Low
Unassigned

Bug Description

Binary package hint: gravitywars

gravitywars doesn't appear in the menu as it has no .desktop file.

Related branches

Changed in gravitywars:
importance: Undecided → Low
status: New → Triaged

I'm working for this

Changed in gravitywars:
assignee: nobody → palma-salvatore

This is the buxfix

Changed in gravitywars:
assignee: palma-salvatore → nobody
Siegfried Gevatter (rainct) wrote :

Thanks!

It seems this application doesn't neither have an icon. If I'm right, could you please add one?

Hi!
The icon is in the debian directory and I added a link to it in the .desktop file.

Sorry this is the debdiff :)

Siegfried Gevatter (rainct) wrote :

The patch is installing the .desktop file in "gravitywars-1.102/tmp/toIOR9aJ3R/gravitywars-1.102/debian" instead of "gravitywars-1.102/debian"; I'm attaching a working one.

Beside that it looks good to me. Feel free to subscribe ubuntu-universe-sponsors...

Thanks!

Siegfried Gevatter (rainct) wrote :

s/installing/placing

Changed in gravitywars:
status: Unknown → Fix Committed
Daniel Holbach (dholbach) wrote :

Sorry, bug spam necessary because of bug 176085.

This bug has a patch attached, which needs review and sponsoring.

Steve Langasek (vorlon) wrote :

Hi Salvatore,

This patch results in a separate copy of gravitywars.xpm being installed under the pixmaps directory. I realize it's a small file, but it still seems preferable to me to install just one copy and then add a symlink to it from the other location. Would you consider making this change and submitting an updated patch?

Changed in gravitywars:
assignee: nobody → palma-salvatore
status: Triaged → In Progress

Done.

Steve Langasek (vorlon) wrote :

Sorry, but the added symlink is wrong; it points to /usr/share/pixmaps/gravitywars/gravitywars.xpm, which does not exist. It should of course point to /usr/share/games/gravitywars/gravitywars.xpm.

Also, it's a bit more elegant to create a debian/gravitywars.links file to use for this symlink, rather than calling dh_link with a -p option; the -p prevents dh_link from working right in the future if other binary packages are added to this source that need to use dh_link.

This is the debdiff correct

Steve Langasek (vorlon) wrote :

thank you for your perseverance, Salvatore. This package will be uploaded shortly.

gravitywars (1.102-31ubuntu1) hardy; urgency=low

  * Provide a .desktop file (LP: #174906)
  * Debian/control:
    - Update maintainer field
  * Add debian/gravitywars.links

 -- Salvatore Palma <email address hidden> Sun, 16 Dec 2007 20:31:35 +0100

Changed in gravitywars:
status: In Progress → Fix Released
Changed in gravitywars:
assignee: palma-salvatore → nobody
Changed in gravitywars (Debian):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.