[papercut] CTRL-V doesnt paste in gpaint

Bug #444750 reported by Martin Olsson on 2009-10-06
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
One Hundred Papercuts
Undecided
Matt Wheeler
gpaint (Ubuntu)
Wishlist
Unassigned

Bug Description

Binary package hint: gpaint

In karmic, press PrtScn to take a screenshot and then click the "copy to clipboard" button and then start "gpaint" and press CTRL-V. Nothing happens because CTRL-V is not bound to paste inside gpaint (gpaint has perfectly working "paste" functionality though, it's just that the devs forgot to hook up CTRL-V as a shortcut keybinding. Other stuff inside gpaint does have shortcut keys setup though, check out the image menu for example).

Fixing this involves opening the gpaint.glade file in the root directory of the source package. Here you will see existing shortcut keys being setup, like for example the "accelerator" below:

                        <widget class="GtkMenuItem" id="rotate_p90_menu">
                          <property name="visible">True</property>
                          <property name="tooltip" translatable="yes">Rotate 90 degrees Clockwise</property>
                          <property name="label" translatable="yes">Rotate Right</property>
                          <property name="use_underline">True</property>
                          <signal name="activate" handler="on_rotate_menu_activate"/>
                          <accelerator key="R" modifiers="GDK_CONTROL_MASK" signal="activate"/>
                        </widget>

...then just fine the one for the "paste" menu item in the "edit" menu and bind CTRL-V as an accelerator for that item (and do CTRL-C for copy while at it).

This is a great newbie bug for someone looking to make their first contribution to Ubuntu.

ProblemType: Bug
Architecture: amd64
Date: Tue Oct 6 19:35:46 2009
DistroRelease: Ubuntu 9.10
Package: gpaint 0.3.3-2.1ubuntu1
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-11.38-generic
SourcePackage: gpaint
Uname: Linux 2.6.31-11-generic x86_64

Martin Olsson (mnemo) wrote :
tags: added: papercut
Matt Wheeler (funkyhat) on 2009-10-06
Changed in gpaint (Ubuntu):
assignee: nobody → Matt Wheeler (funkyhat)
Changed in hundredpapercuts:
assignee: nobody → Matt Wheeler (funkyhat)
Matt Wheeler (funkyhat) wrote :

Here is the patch - I added a few extra keyboard shortcuts, looks like it didn't have any at all.

Fabrice Coutadeur (fabricesp) wrote :

Hi,

As gpaint is using dpatch, can you please convert your source changes into a patch?
Also, as Debian has gpaint 0.3.3-3, and this version has a patch that fixes a coredump, I'll merge your changes with version 0.3.3-3, except if you do it.

Thanks for your work,

Fabrice

Changed in gpaint (Ubuntu):
importance: Undecided → Wishlist
status: New → Incomplete
Changed in gpaint (Ubuntu):
status: Incomplete → New
Matt Wheeler (funkyhat) wrote :

dpatch based patch attached

Matt Wheeler (funkyhat) wrote :

I've now merged the new version from debian as well as added my keyboard shortcuts patch, here's the new patch.
Wasn't sure if I needed to file a new bug for the merge, so I didn't.

Changed in gpaint (Ubuntu):
assignee: Matt Wheeler (funkyhat) → fabrice_sp (fabricesp)
status: New → In Progress
Fabrice Coutadeur (fabricesp) wrote :

Uploaded. Thanks for your contribution!

During the merge process, you lost the previous Ubuntu changelog entries. Please do not forget to add them next time. Also, I deleted the duplicated fix_non_printable_string patch.

And next time, please post the debdiff between Debian and Ubuntu, and not the one between Ubuntu and Ubuntu: in case of upstream version change, this debdiff can be huge :-)

And also, do not forget to send your patch to upstream and/or Debian

Thanks,
Fabrice

Changed in gpaint (Ubuntu):
assignee: fabrice_sp (fabricesp) → nobody
status: In Progress → Triaged
Fabrice Coutadeur (fabricesp) wrote :

gpaint is in main, so I'll post the updated debdiff and subscribe main sponsors

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gpaint - 0.3.3-3ubuntu1

---------------
gpaint (0.3.3-3ubuntu1) karmic; urgency=low

  * Merge with Debian Unstable, remaining changes:
    - debian/control: Add ${misc:Depends} to Depends.
  * Adding various keyboard shortcuts (LP: #444750)

gpaint (0.3.3-3) unstable; urgency=low

  * Updated menu entry with a new SVG icon (Closes: #497483) (LP: #127298).
    Thanks to Fernando Muñoz for the art.
  * debian/patches/21_fix_crash_on_fill_button_click.dpatch: Added. Fixes a
    crash when the fill button is clicked before the text tool is selected.
    (Closes: #544162)(LP: #348764)
  * debian/patches/22_fix_not_printable_string.dpatch: Added. Ignores
    non-printable characters on text input. (Closes: #535217).
    Thanks Ying-Chun Liu for the patch

 -- Matt Wheeler <email address hidden> Thu, 08 Oct 2009 21:42:08 +0100

Changed in gpaint (Ubuntu):
status: Triaged → Fix Released
Przemek K. (azrael) on 2009-11-13
Changed in hundredpapercuts:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers