Duplicate entry for `multi-user.target` in the startup scripts

[Chloé Smith]

[Impact]

``google-guest-agent`` is provided by Google for installation within guests that run on GCE. It's just one of a collection of tools and daemons that ensure that the Ubuntu images published to GCE run properly on their platform.

A member of the Google team pointed out to CPC that there seems to be an error in the file ``google-startup-scripts.service``; namely there's a duplicate entry for ``multi-user.target`` that doesn't make sense. Rectifying it easy to do, low risk and will look good for Ubuntu, so let's do it!

[Test Case]

When a new version of ``google-guest-agent`` is uploaded to ``-proposed``, the following will happen...

 * an image based on -proposed will be built especially for GCE (by the CPC team) and published to the ``ubuntu-os-cloud-devel`` project
 * the GCE team will be asked to validate that the new package addresses the issues it is expected to address, and that the image passes their internal image validation.
 * Each test image will be launched, and we (CPC) will validate:
 ** the package version
 ** that the correct ssh keys have been imported
 ** that the Google specific services are running successfully

If all the testing indicates that the new package is acceptable, verification will be considered to be done.

[Other Information]

This bug is used for tracking of releasing the new versions for all supported series, as per the approved policy mentioned in the following MRE:

https://wiki.ubuntu.com/gce-compute-image-packages-Updates

The updated package is not built for riscv64 on Focal, but it is not used on riscv64 either, thus please release the SRU without the risc64 binaries.

The package does not build for powerpc on Xenial, but this is OK since it is not used on powerpc either.

[Misc]

I have attached a .debdiff for ease - the patch was created using the usual ``quilt`` workflow (quilt push -a, quilt new ..., quilt add ..., quilt header -e, etc). The error was introduced by an older patch, instead of editing it I made a new patch to maintain history.

[Chloé Smith (kajiya)]

FYI, I've accidentally included the 2 unnecessary lines at the top of the debdiff - my bad.

[Chloé Smith (kajiya)]

Here's the raw patch

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "0005-remove-dupe-multi-user-target.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Utkarsh Gupta (utkarsh)]

Sponsored the upload to Lunar after minor clean ups. Thank you.

[Chloé Smith (kajiya)]

Small change to the bug description to add the MRE

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20220622.00-0ubuntu3

---------------
google-guest-agent (20220622.00-0ubuntu3) lunar; urgency=medium

  * d/p/0005-remove-dupe-multi-user-target.patch: Add patch to
    fix duplicate `multi-user.target` entries. (LP: #1998864)

 -- Chloé 'kajiya' Smith <email address hidden> Mon, 05 Dec 2022 19:52:50 +0000

[Chloé Smith (kajiya)]

Will continue with the SRU *after* I've fixed lunar... just realised there's a typo in ``0005-remove-dupe-multi-user-target.patch`` that's going to cause issues.

[Utkarsh Gupta (utkarsh)]

Sadly because of the typo, this bug is not fixed, so setting it to "New" again.

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20220622.00-0ubuntu4

---------------
google-guest-agent (20220622.00-0ubuntu4) lunar; urgency=medium

  * d/p/0005-remove-dupe-multi-user-target.patch: fix breaking typo
    in the service file. (LP: #1998864)

 -- Chloé 'kajiya' Smith <email address hidden> Thu, 08 Dec 2022 7:19:31 +0000

[Chloé Smith (kajiya)]

Marked as "Invalid" for all the stable releases as the fix is not SRU-able (i.e. not a bugfix, just tidies things up). I'll ask to have this fix bundled in with the next upstream-release update (example old bug here: https://bugs.launchpad.net/ubuntu/+source/google-guest-agent/+bug/1938286)

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20230426.00-0ubuntu2~22.10.0

---------------
google-guest-agent (20230426.00-0ubuntu2~22.10.0) kinetic; urgency=medium

  * No-change rebuild for Kinetic

google-guest-agent (20230426.00-0ubuntu2) mantic; urgency=medium

  * d/rules: Add --no-stop-on-upgrade for upgrade path
    to enforce no stop of the services on package upgrade.
    This has the desired side-effect of not stopping, starting or
    restarting the services as a part of the upgrade (LP: #2019089)
  * d/{rules,install}: ship gce-workload-cert-refresh.timer.

 -- Utkarsh Gupta <email address hidden> Thu, 25 May 2023 13:11:33 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20230426.00-0ubuntu2~22.04.0

---------------
google-guest-agent (20230426.00-0ubuntu2~22.04.0) jammy; urgency=medium

  * No-change rebuild for Jammy.

google-guest-agent (20230426.00-0ubuntu2) mantic; urgency=medium

  * d/rules: Add --no-stop-on-upgrade for upgrade path
    to enforce no stop of the services on package upgrade.
    This has the desired side-effect of not stopping, starting or
    restarting the services as a part of the upgrade (LP: #2019089)
  * d/{rules,install}: ship gce-workload-cert-refresh.timer.

 -- Utkarsh Gupta <email address hidden> Thu, 25 May 2023 13:13:37 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20230426.00-0ubuntu2~20.04.0

---------------
google-guest-agent (20230426.00-0ubuntu2~20.04.0) focal; urgency=medium

  * No-change rebuild for Focal.

google-guest-agent (20230426.00-0ubuntu2) mantic; urgency=medium

  * d/rules: Add --no-stop-on-upgrade for upgrade path
    to enforce no stop of the services on package upgrade.
    This has the desired side-effect of not stopping, starting or
    restarting the services as a part of the upgrade (LP: #2019089)
  * d/{rules,install}: ship gce-workload-cert-refresh.timer.

 -- Utkarsh Gupta <email address hidden> Thu, 25 May 2023 13:16:13 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20230426.00-0ubuntu2~18.04.0

---------------
google-guest-agent (20230426.00-0ubuntu2~18.04.0) bionic; urgency=medium

  * No-change rebuild for Bionic.

google-guest-agent (20230426.00-0ubuntu2) mantic; urgency=medium

  * d/rules: Add --no-stop-on-upgrade for upgrade path
    to enforce no stop of the services on package upgrade.
    This has the desired side-effect of not stopping, starting or
    restarting the services as a part of the upgrade (LP: #2019089)
  * d/{rules,install}: ship gce-workload-cert-refresh.timer.

 -- Utkarsh Gupta <email address hidden> Thu, 25 May 2023 13:22:23 +0530