[MIR] google-glog

Bug #1151844 reported by Alan Griffiths on 2013-03-07
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gflags (Ubuntu)
Undecided
Unassigned
google-glog (Ubuntu)
Undecided
Unassigned

Bug Description

Rationale
========

There is currently no C++ compatible logging package in main.

Canonical projects that require logging should not be resolving the requirement.

The mir project is an an example - and glog seems the most lightweight solution to its logging requirements. As a system component, mir requires all dependencies to be in main. Other components will have the same requirements.

Violations of UbuntuMainInclusionRequirements
========================================

There's a dependency on libgflags, but no violations

Michael Terry (mterry) wrote :

Is this for Raring or S?

Changed in google-glog (Ubuntu):
status: New → Incomplete
Alan Griffiths (alan-griffiths) wrote :

For raring

Michael Terry (mterry) wrote :

This is ftbfs on armhf

Alan Griffiths (alan-griffiths) wrote :

Looking at glog ftbs on armhf I see a stack trace with "__libc_do_syscall" where "DieInThread" is expected.

Googling says others see the same but I don't yet understand what's going on. Is the stack frame different on armhf?

Alan Griffiths (alan-griffiths) wrote :

Looks like the failing test is x86/x86_64 specific. Can we patch?

=== modified file 'src/signalhandler_unittest.sh'
--- src/signalhandler_unittest.sh 2012-06-21 21:07:21 +0000
+++ src/signalhandler_unittest.sh 2013-03-13 14:15:15 +0000
@@ -72,6 +72,13 @@
   exit 0
 fi

+# The symbols don't match on ARM.
+# We just skip the test for ARM.
+if [ `expr match \`uname -p\` "arm*"` ]; then
+ echo "PASS (We don't test the signal handler on ARM.)"
+ exit 0
+fi
+
 # Test for a case the program kills itself by SIGSEGV.
 GOOGLE_LOG_DIR=. $BINARY segv 2> signalhandler.out1
 for pattern in SIGSEGV 0xdead main "Aborted at [0-9]"; do

Michael Terry (mterry) wrote :

With the latest upload to fix the ftbfs issue, google-glog looks fine. Has a good test suite, no important bugs, good packaging. Approved. Would be nice to see a bug subscriber, but is not a blocker.

Changed in google-glog (Ubuntu):
status: Incomplete → Fix Committed
Michael Terry (mterry) wrote :

gflags looks good too. Approved. Also could use a bug subscriber.

Changed in gflags (Ubuntu):
status: New → Fix Committed
Robert Ancell (robert-ancell) wrote :

Bug subscribers added

Colin Watson (cjwatson) wrote :

Moved to main.

Changed in gflags (Ubuntu):
status: Fix Committed → Fix Released
Changed in google-glog (Ubuntu):
status: Fix Committed → Fix Released
Sebastien Bacher (seb128) wrote :

The component was demoted in previous cycles and needs to be promoted back, there is no action needed on the bug but changing to fix-commited to help with the component mismatch summary of the situation

Changed in google-glog (Ubuntu):
status: Fix Released → Fix Committed
Changed in gflags (Ubuntu):
status: Fix Released → Fix Committed
Steve Langasek (vorlon) wrote :
Download full text (3.5 KiB)

Thanks, repromoted.

Override component to main
google-glog 0.3.4-2 in yakkety: universe/libs -> main
libgoogle-glog-dev 0.3.4-2 in yakkety amd64: universe/libdevel/optional/100% -> main
libgoogle-glog-dev 0.3.4-2 in yakkety arm64: universe/libdevel/optional/100% -> main
libgoogle-glog-dev 0.3.4-2 in yakkety armhf: universe/libdevel/optional/100% -> main
libgoogle-glog-dev 0.3.4-2 in yakkety i386: universe/libdevel/optional/100% -> main
libgoogle-glog-dev 0.3.4-2 in yakkety powerpc: universe/libdevel/optional/100% -> main
libgoogle-glog-dev 0.3.4-2 in yakkety ppc64el: universe/libdevel/optional/100% -> main
libgoogle-glog-dev 0.3.4-2 in yakkety s390x: universe/libdevel/optional/100% -> main
libgoogle-glog-doc 0.3.4-2 in yakkety amd64: universe/doc/optional/100% -> main
libgoogle-glog-doc 0.3.4-2 in yakkety arm64: universe/doc/optional/100% -> main
libgoogle-glog-doc 0.3.4-2 in yakkety armhf: universe/doc/optional/100% -> main
libgoogle-glog-doc 0.3.4-2 in yakkety i386: universe/doc/optional/100% -> main
libgoogle-glog-doc 0.3.4-2 in yakkety powerpc: universe/doc/optional/100% -> main
libgoogle-glog-doc 0.3.4-2 in yakkety ppc64el: universe/doc/optional/100% -> main
libgoogle-glog-doc 0.3.4-2 in yakkety s390x: universe/doc/optional/100% -> main
libgoogle-glog0v5 0.3.4-2 in yakkety amd64: universe/libs/optional/100% -> main
libgoogle-glog0v5 0.3.4-2 in yakkety arm64: universe/libs/optional/100% -> main
libgoogle-glog0v5 0.3.4-2 in yakkety armhf: universe/libs/optional/100% -> main
libgoogle-glog0v5 0.3.4-2 in yakkety i386: universe/libs/optional/100% -> main
libgoogle-glog0v5 0.3.4-2 in yakkety powerpc: universe/libs/optional/100% -> main
libgoogle-glog0v5 0.3.4-2 in yakkety ppc64el: universe/libs/optional/100% -> main
libgoogle-glog0v5 0.3.4-2 in yakkety s390x: universe/libs/optional/100% -> main
gflags 2.1.2-3 in yakkety: universe/libs -> main
libgflags-dev 2.1.2-3 in yakkety amd64: universe/libdevel/optional/100% -> main
libgflags-dev 2.1.2-3 in yakkety arm64: universe/libdevel/optional/100% -> main
libgflags-dev 2.1.2-3 in yakkety armhf: universe/libdevel/optional/100% -> main
libgflags-dev 2.1.2-3 in yakkety i386: universe/libdevel/optional/100% -> main
libgflags-dev 2.1.2-3 in yakkety powerpc: universe/libdevel/optional/100% -> main
libgflags-dev 2.1.2-3 in yakkety ppc64el: universe/libdevel/optional/100% -> main
libgflags-dev 2.1.2-3 in yakkety s390x: universe/libdevel/optional/100% -> main
libgflags-doc 2.1.2-3 in yakkety amd64: universe/doc/optional/100% -> main
libgflags-doc 2.1.2-3 in yakkety arm64: universe/doc/optional/100% -> main
libgflags-doc 2.1.2-3 in yakkety armhf: universe/doc/optional/100% -> main
libgflags-doc 2.1.2-3 in yakkety i386: universe/doc/optional/100% -> main
libgflags-doc 2.1.2-3 in yakkety powerpc: universe/doc/optional/100% -> main
libgflags-doc 2.1.2-3 in yakkety ppc64el: universe/doc/optional/100% -> main
libgflags-doc 2.1.2-3 in yakkety s390x: universe/doc/optional/100% -> main
libgflags2v5 2.1.2-3 in yakkety amd64: universe/libs/optional/100% -> main
libgflags2v5 2.1.2-3 in yakkety arm64: universe/libs/optional/100% -> main
libgflags2v5 2.1.2-3 in yakkety armhf: uni...

Read more...

Changed in google-glog (Ubuntu):
status: Fix Committed → Fix Released
Changed in gflags (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers