Needs to be either ported to xulrunner 2.0, or drop it's dependency on xulrunner entirely

Bug #722611 reported by Chris Coulson on 2011-02-21
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
google-gadgets (Ubuntu)
High
Unassigned

Bug Description

We want to drop xulrunner-1.9.2 from the archive (to try and avoid having to support 2 different versions), but google-gadgets is depending quite heavily on the current version.

I made a start to port it (and also adding proper JS_BeginRequest/JS_EndRequest guarding around code which touches a JSContext as this is enforced when running against debug builds of Spidermonkey, which I've been doing to investigate problems I'm having).

However, this still isn't working and I've already invested way too much of my time on this. Somebody else needs to pick this up, else we'll drop it from the archive. This seems pretty dead upstream anyway, and I expect we'll get frequent changes to jsapi nearly every cycle now, which is going to make supporting this a significant amount of work.

Chris Coulson (chrisccoulson) wrote :

Here's what I started. It builds fine, but crashes inside JS_InitClass on a non-debug build of spidermonkey

Changed in google-gadgets (Ubuntu):
importance: Undecided → High
status: New → Triaged
tags: added: patch
kuh3h3 (kuh3h3) wrote :
Download full text (3.2 KiB)

attached patch compile failed.

libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../.. -D__STDC_CONSTANT_MACROS -DNDEBUG -DGGL_MODULE_DIR=\"/usr/lib/google-gadgets/modules\" -DGGL_INCLUDE_DIR=\"/usr/include/google-gadgets\" -DGGL_SYSDEPS_INCLUDE_DIR=\"/usr/lib/google-gadgets/include\" -DGGL_LIBEXEC_DIR=\"/usr/lib/google-gadgets\" -DGGL_RESOURCE_DIR=\"/usr/share/google-gadgets\" -DGGL_HOST_LINUX=1 -DGGL_LITTLE_ENDIAN -DHAVE_PTHREAD=1 -DHAVE_X11=1 -DHAVE_DBUS_LIBRARY -DHAVE_RSVG_LIBRARY -DHAVE_STARTUP_NOTIFICATION -DHAVE_NETWORK_MANAGER -DHAVE_NEW_NETWORK_MANAGER_API -DHAVE_JAVA_SCRIPT_H -DGGL_GTK_WEBKIT_SUPPORT_JSC -DHAVE_MKDTEMP -DHAVE_MMAP "-DGGL_DIST_INFO=\"linux-i686 (Ubuntu natty (development branch)) (-)\"" -DGGL_DEFAULT_GST_AUDIO_SINK=\"autoaudiosink\" -DGGL_DEFAULT_BROWSER_PLUGINS_DIR=\"/usr/lib/xulrunner-addons/plugins\" -DGGL_ENABLE_XDGMIME -DGGL_GTK_HTML_SCRIPT_ENGINE=\"xulrunner\" -DGGL_GTK_XML_HTTP_REQUEST=\"soup\" -DGGL_QT_SCRIPT_ENGINE=\"smjs\" -DXP_UNIX -DJS_THREADSAFE -I/usr/include/xulrunner-2.0b7 -I/usr/include/nspr -DHAVE_JSVERSION_H -DHAVE_JS_SetOperationCallback -DHAVE_JS_TriggerAllOperationCallbacks -DXPCOM_GLUE -fshort-wchar -I/usr/include/xulrunner-2.0b7 -I/usr/include/xulrunner-2.0b7/nspr -I/usr/include/xulrunner-2.0b7 -I/usr/include/xulrunner-2.0b7/content -I/usr/include/xulrunner-2.0b7/dom -I/usr/include/xulrunner-2.0b7/xpconnect -I/usr/include/xulrunner-2.0b7/widget -I/usr/include/xulrunner-2.0b7/gtkembedmoz -I/usr/include/xulrunner-2.0b7/xpcom -I/usr/include/xulrunner-2.0b7/string -DMOZILLA_FIVE_HOME=\"/usr/lib/xulrunner-2.0b7\" -DGGL_MOZJS_LIBNAME=\"libmozjs.so\" -O2 -Wall -fstack-protector -fcheck-new -g -O2 -c js_script_context.cc -fPIC -DPIC -o .libs/libggadget_smjs_la-js_script_context.o
In file included from js_script_context.cc:22:0:
/usr/include/xulrunner-2.0b7/jscntxt.h: In function ‘JSContext* js_ContextFromLinkField(JSCList*)’:
/usr/include/xulrunner-2.0b7/jscntxt.h:3007:44: warning: invalid access to non-static data member ‘JSContext::link’ of NULL object
/usr/include/xulrunner-2.0b7/jscntxt.h:3007:44: warning: (perhaps the ‘offsetof’ macro was used incorrectly)
js_script_context.cc: At global scope:
js_script_context.cc:102:1: error: invalid conversion from ‘JSBool (*)(JSContext*, const char*, jsval*)’ to ‘JSBool (*)(JSContext*, char*, jsval*)’
js_script_context.cc: In member function ‘ggadget::smjs::NativeJSWrapper* ggadget::smjs::JSScriptContext::WrapNativeObjectToJSInternal(JSObject*, ggadget::smjs::NativeJSWrapper*, ggadget::ScriptableInterface*, JSBool)’:
js_script_context.cc:293:23: error: request for member ‘func’ in ‘ggadget::libmozjs::JS_BeginRequest.ggadget::libmozjs::JS_BeginRequestType::func’, which is of non-class type ‘void (*)(JSContext*)’
make[4]: *** [libggadget_smjs_la-js_script_context.lo] error 1
make[4]: Leaving directory `/media/sdc1/google-gadgets-0.11.2/extensions/smjs_script_runtime'
make[3]: *** [all-recursive] error 1
make[3]: Leaving directory `/media/sdc1/google-gadgets-0.11.2/extensions/smjs_script_runtime'
make[2]: *** [all-recursive] error 1
make[2]: Leaving directory `/media/sdc1/google-gadgets-0.11.2/extensions'
make[1]: *** [all-recursive] error 1
make...

Read more...

Chris Coulson (chrisccoulson) wrote :

We've dropped this from the archive now

Changed in google-gadgets (Ubuntu):
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Patches