[SRU] Update xenial and yakkety to match zesty version

Bug #1647017 reported by Stéphane Graber
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
golang-gopkg-lxc-go-lxc.v2 (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Stéphane Graber
Yakkety
Fix Released
Undecided
Stéphane Graber
lxd (Ubuntu)
Fix Released
Undecided
Unassigned
Yakkety
Fix Released
Undecided
Stéphane Graber

Bug Description

== Rationale ==
Update go-lxc to match in all supported Ubuntu releases. This includes adding a couple more bindings related to attach which will be used as the basis for an attach bugfix in the upcoming LXD bugfix release.

== Test case ==
Current LXD from the target series and the current upstream LXD should be rebuilt against this and the testsuite run. This on top of the autopkgtests included in the go-lxc package will validate that this didn't cause regressions and that the new bindings work properly (as used in current upstream LXD).

== Regression potential ==
go-lxc is only used by LXD at this point and LXD CI runs against the latest go-lxc upstream. This is also the version of go-lxc which is in the current development release and so has effectively received the most stress testing by LXD upstream.

The risk of regression is therefore very low and the content of this new snapshot is basically limited to clean additions or straightforward bugfixes.

go-lxc is used by LXD as the way to interact with liblxc.
As a result, upstream changes for it are usually restricted to bugfixes or minor improvements (for things like CRIU support). To make our lives easier, we like to keep go-lxc in sync in all supported Ubuntu releases to match the LXC version that we also keep in sync there.

To do so, we need to SRU a new version of go-lxc to xenial and yakkety, with the following upstream changelog:
 - bindings C: check for LXC_DEVEL in version.h file
 - bindings go: check for LXC_DEVEL in version.h
 - lxc-binding: add binding for c->attach()
 - container: add RunCommandNoWait()
 - lxc_test: add test for RunCommandNoWait()
 - Move LXC_DEVEL define to after version.h include
 - c/r: make sure container is running before doing a dump
 - container, error: return correct error
 - Fix TestRunCommandNoWait failure
 - tests: Skip architecture test on !x86
 - tests: Make skip messages consistent
 - Run "go fmt"

The xenial SRU will not require any extra work. The next LXD upload will simply pick up the new go-lxc at build time.

For the yakkety SRU, we will need to upload a no change rebuild of LXD to build against the new go-lxc and we'll need them both to be released at the same time. That's because of the addition of the "attach()" function which changes the Go shared library hash.

Changed in golang-gopkg-lxc-go-lxc.v2 (Ubuntu):
status: New → Fix Released
no longer affects: lxd (Ubuntu Xenial)
Changed in lxd (Ubuntu):
status: New → Invalid
status: Invalid → Fix Released
Changed in lxd (Ubuntu Yakkety):
status: New → In Progress
Changed in golang-gopkg-lxc-go-lxc.v2 (Ubuntu Yakkety):
status: New → In Progress
Changed in golang-gopkg-lxc-go-lxc.v2 (Ubuntu Xenial):
status: New → In Progress
Changed in lxd (Ubuntu Yakkety):
status: In Progress → Triaged
Changed in golang-gopkg-lxc-go-lxc.v2 (Ubuntu Xenial):
assignee: nobody → Stéphane Graber (stgraber)
Changed in golang-gopkg-lxc-go-lxc.v2 (Ubuntu Yakkety):
assignee: nobody → Stéphane Graber (stgraber)
Changed in lxd (Ubuntu Yakkety):
assignee: nobody → Stéphane Graber (stgraber)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Stéphane, or anyone else affected,

Accepted golang-gopkg-lxc-go-lxc.v2 into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-gopkg-lxc-go-lxc.v2/0.0~git20161126.1.82a07a6-0ubuntu1~ubuntu16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in golang-gopkg-lxc-go-lxc.v2 (Ubuntu Yakkety):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in golang-gopkg-lxc-go-lxc.v2 (Ubuntu Xenial):
status: In Progress → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Stéphane, or anyone else affected,

Accepted golang-gopkg-lxc-go-lxc.v2 into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-gopkg-lxc-go-lxc.v2/0.0~git20161126.1.82a07a6-0ubuntu1~ubuntu16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Stéphane Graber (stgraber) wrote :

Local test rebuild worked fine, autopkgtest looks happy, releasing.

Changed in lxd (Ubuntu Yakkety):
status: Triaged → Fix Released
tags: added: verification-done
removed: verification-needed
Revision history for this message
Stéphane Graber (stgraber) wrote : Update Released

The verification of the Stable Release Update for golang-gopkg-lxc-go-lxc.v2 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package golang-gopkg-lxc-go-lxc.v2 - 0.0~git20161126.1.82a07a6-0ubuntu1~ubuntu16.04.1

---------------
golang-gopkg-lxc-go-lxc.v2 (0.0~git20161126.1.82a07a6-0ubuntu1~ubuntu16.04.1) xenial; urgency=medium

  * Update to current upstream snapshot (LP: #1647017)
    - bindings C: check for LXC_DEVEL in version.h file
    - bindings go: check for LXC_DEVEL in version.h
    - lxc-binding: add binding for c->attach()
    - container: add RunCommandNoWait()
    - lxc_test: add test for RunCommandNoWait()
    - Move LXC_DEVEL define to after version.h include
    - c/r: make sure container is running before doing a dump
    - container, error: return correct error
    - Fix TestRunCommandNoWait failure
    - tests: Skip architecture test on !x86
    - tests: Make skip messages consistent
    - Run "go fmt"
  * Restrict autopkgtest to standalone systems

 -- Stéphane Graber <email address hidden> Sat, 26 Nov 2016 15:42:53 -0500

Changed in golang-gopkg-lxc-go-lxc.v2 (Ubuntu Xenial):
status: Fix Committed → Fix Released
Changed in golang-gopkg-lxc-go-lxc.v2 (Ubuntu Yakkety):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers