currently FTBFS due to TestTLSConfig

Bug #1930772 reported by Dan Bungert
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
golang-github-prometheus-common (Debian)
Fix Released
Unknown
golang-github-prometheus-common (Ubuntu)
Fix Released
Low
William Wilson

Bug Description

golang-github-prometheus-common package currently FTBFS due to TestTLSConfig

=== RUN TestTLSConfig http_config_test.go:519: Unexpected TLS Config result:

[...]
RootCAs:0xc00011d470
[...]
         expected
[...]
RootCAs:0xc00011cf30
[...]
-- FAIL: TestTLSConfig (0.00s)

This is reported upstream at https://github.com/prometheus/common/issues/267
This is also already fixed in commit 10e1378a4a94394e5671c529b7d87833c2b70d13

This also appears to be related to go 1.16 - previous versions of go appear to not trigger the issue (or so I infer from the upstream bug report).

Filing the bug largely to track this as a known issue and mark it in the
update-excuses report. Should be resolved when a new version is uploaded, or
the above fix could be cherry-picked if someone is so inclined.

Changed in golang-github-prometheus-common (Ubuntu):
assignee: nobody → William Wilson (jawn-smith)
status: New → In Progress
Revision history for this message
William Wilson (jawn-smith) wrote :

This patch cherry picks a minor upstream change to enable building with golang 1.16.

Changed in golang-github-prometheus-common (Ubuntu):
status: In Progress → Fix Committed
Changed in golang-github-prometheus-common (Debian):
status: Unknown → New
Mathew Hodson (mhodson)
Changed in golang-github-prometheus-common (Ubuntu):
importance: Undecided → Low
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

sponsored

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package golang-github-prometheus-common - 0.15.0-2ubuntu1

---------------
golang-github-prometheus-common (0.15.0-2ubuntu1) impish; urgency=medium

  * Cherry pick code from upstream to fix an issue with RootCA comparison. As
    of go 1.16 these RootCAs will never be equal, so we just compare the
    subjects instead of the entire value. (LP: #1930772)

 -- William 'jawn-smith' Wilson <email address hidden> Wed, 23 Jun 2021 17:25:06 +0000

Changed in golang-github-prometheus-common (Ubuntu):
status: Fix Committed → Fix Released
Changed in golang-github-prometheus-common (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.