FFe: Sync golang-fsnotify 1.4.7-1 (universe) from Debian unstable (main)

Bug #1753767 reported by Anthony Fok on 2018-03-06
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
golang-fsnotify (Ubuntu)
Undecided
Unassigned

Bug Description

Please sync src:golang-fsnotify 1.4.7-1 from Debian (unstable).
Upstream fixes some deadlocks and race conditions between 1.4.2 and 1.4.7:

  ## v1.4.7 / 2018-01-09

  * BSD/macOS: Fix possible deadlock on closing the watcher on kqueue
    (thanks @nhooyr and @glycerine)
  * Tests: Fix missing verb on format string (thanks @rchiossi)
  * Linux: Fix deadlock in Remove (thanks @aarondl)
  * Linux: Watch.Add improvements (avoid race, fix consistency,
    reduce garbage) (thanks @twpayne)
  * Docs: Moved FAQ into the README (thanks @vahe)
  * Linux: Properly handle inotify's IN_Q_OVERFLOW event
    (thanks @zeldovich)
  * Docs: replace references to OS X with macOS

It would be great to have src:golang-fsnotify (golang-github-fsnotify-fsnotify-dev) included in Bionic especially because it is used by popular packages like docker.io and hugo.

Many thanks!

Anthony Fok (foka) on 2018-03-06
tags: added: upgrade-software-version
description: updated
Anthony Fok (foka) on 2018-03-06
summary: - Freeze exception: Please sync golang-fsnotify 1.4.7-1 from Debian
+ Freeze exception: Please sync golang-fsnotify 1.4.7-1 from Debian sid
+ main

debian/changelog from src:golang-fsnotify 1.4.2-1 currently in bionic:

golang-fsnotify (1.4.7-1) unstable; urgency=medium

  [ Paul Tagliamonte ]
  * Remove Built-Using from arch:all -dev package

  [ Anthony Fok ]
  * New upstream version 1.4.7
  * Bump Standards-Version to 4.1.3:
    Use https form of the copyright-format URL in debian/copyright,
    and change priority from extra to optional.
  * Use debhelper (>= 11).
  * Add myself to the list of Uploaders.
  * Apply "cme fix dpkg" fixes to debian/control.
  * Remove all old transitional packages, namely, golang-fsnotify-dev
    and golang-github-go-fsnotify-fsnotify-dev.

 -- Anthony Fok <email address hidden> Fri, 02 Mar 2018 07:19:15 -0700

Anthony Fok (foka) on 2018-03-06
summary: - Freeze exception: Please sync golang-fsnotify 1.4.7-1 from Debian sid
- main
+ FFe: Sync golang-fsnotify 1.4.7-1 (universe) from Debian unstable (main)
Anthony Fok (foka) wrote :

Hi again.

Only after I posted the debian/changelog above did I realize a "FFe Sync from Debian" is also required for src:golang-github-revel-revel due to the removal of old transitional packages "golang-fsnotify-dev" and "golang-github-go-fsnotify-fsnotify-dev". (Sorry for the trouble!)

Please see that request here:

https://bugs.launchpad.net/ubuntu/+source/golang-github-revel-revel/+bug/1753829

Michael Hudson-Doyle (mwhudson) wrote :

The only part of this that comes close to requiring an FFe is the removal of the transitional packages, according to my poking around there are still packages in bionic that build-depend on them (prometheus-mailexporter, golang-github-revel-revel). Would you be ok with me uploading an 1ubuntu1 that still has those?

Anthony Fok (foka) wrote :

> The only part of this that comes close to requiring an FFe
> is the removal of the transitional packages

Thank you for the clarification! I am very new to the Ubuntu freeze/release process, and mistakenly thought every sync after a Feature Freeze (March 1st) required filing a FFe.
I have just started using "requestsync" like an hour ago and

> Would you be ok with me uploading an 1ubuntu1 that still has those?

Yes, definitely! Sorry for causing you extra work! I wasn't think far ahead enough to check for reverse dependencies in Ubuntu before removing those transitional packages in Debian golang-fsnotify (1.4.7-1).

Thank you so much, Michael!

P.S. If you prefer to keep packages in both Debian and Ubuntu identical, I'd be happy to upload a golang-fsnotify (1.4.7-2) reverting the removal of the transitional packages. Let me know. ;-)

Michael Hudson-Doyle (mwhudson) wrote :

I synced golang-github-revel-revel, what's your plan for prometheus-mailexporter? I guess fixing it's build deps in debian and then syncing it is probably the best plan.

Anthony Fok (foka) wrote :

> I synced golang-github-revel-revel,

Awesome! Thank you!

> what's your plan for prometheus-mailexporter?
> I guess fixing its build deps in debian
> and then syncing it is probably the best plan.

Great idea! And... it is done! Please see

https://bugs.launchpad.net/ubuntu/+source/prometheus-mailexporter/+bug/1753905

Thanks again!

Michael Hudson-Doyle (mwhudson) wrote :

This bug was fixed in the package golang-fsnotify - 1.4.7-1
Sponsored for Anthony Fok (foka)

---------------
golang-fsnotify (1.4.7-1) unstable; urgency=medium

  [ Paul Tagliamonte ]
  * Remove Built-Using from arch:all -dev package

  [ Anthony Fok ]
  * New upstream version 1.4.7
  * Bump Standards-Version to 4.1.3:
    Use https form of the copyright-format URL in debian/copyright,
    and change priority from extra to optional.
  * Use debhelper (>= 11).
  * Add myself to the list of Uploaders.
  * Apply "cme fix dpkg" fixes to debian/control.
  * Remove all old transitional packages, namely, golang-fsnotify-dev
    and golang-github-go-fsnotify-fsnotify-dev.

 -- Anthony Fok <email address hidden> Fri, 02 Mar 2018 07:19:15 -0700

Changed in golang-fsnotify (Ubuntu):
status: New → Fix Released
Anthony Fok (foka) wrote :

Thanks a million, Michael! :-)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers