increase in SUBBUCKETS has performance impact

Bug #1916536 reported by Dan Streetman
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
golang-1.14 (Ubuntu)
New
Medium
Unassigned
Focal
New
Medium
Unassigned
Groovy
Won't Fix
Medium
Unassigned
Hirsute
Won't Fix
Medium
Unassigned
golang-1.15 (Ubuntu)
New
Medium
Unassigned
Focal
Invalid
Undecided
Unassigned
Groovy
Invalid
Undecided
Unassigned
Hirsute
Won't Fix
Medium
Unassigned

Bug Description

[impact]

a negative performance impact is found with the increase in SUBBUCKETS

[test case]

TBD

[regression potential]

any regression would likely cause performance issues

[scope]

this is needed only for golang 1.14 and 1.15; the patch is not added in 1.13 or earlier, nor in 1.16.

Specifically, this is needed in f/g/h in the specific golang versions as shown:

$ grep -E 'SUBBUCKETS += 32' */*/golang-*/src/cmd/link/internal/ld/pcln.go
golang-1.14/focal/golang-1.14-1.14.3/src/cmd/link/internal/ld/pcln.go: SUBBUCKETS = 32
golang-1.14/groovy/golang-1.14-1.14.7/src/cmd/link/internal/ld/pcln.go: SUBBUCKETS = 32
golang-1.14/hirsute/golang-1.14-1.14.7/src/cmd/link/internal/ld/pcln.go: SUBBUCKETS = 32
golang-1.15/hirsute/golang-1.15-1.15.8/src/cmd/link/internal/ld/pcln.go: SUBBUCKETS = 32

[other info]

this was added to golang-1.14 with the patch:
debian/patches/0001-cmd-link-add-support-for-external-linking-on-linux-r.patch
and golong-1.15 with the similar patch:
debian/patches/fc3e6af10297b424175b44d2274de04c5f0b9e82.patch

There does not appear to be any documentation or explanation for why the patch modifies SUBBUCKETS.

Upstream, this appears to have been done with the commit 15eaa870e14195c17dbb4be0d11bc40dba94ff22, which does not change SUBBUCKETS.

Dan Streetman (ddstreet)
Changed in golang-1.15 (Ubuntu Focal):
status: New → Invalid
Changed in golang-1.15 (Ubuntu Groovy):
status: New → Invalid
Changed in golang-1.15 (Ubuntu Hirsute):
importance: Undecided → Medium
Changed in golang-1.15 (Ubuntu Groovy):
importance: Undecided → Medium
Changed in golang-1.15 (Ubuntu Focal):
importance: Undecided → Medium
importance: Medium → Undecided
Changed in golang-1.15 (Ubuntu Groovy):
importance: Medium → Undecided
Changed in golang-1.14 (Ubuntu Focal):
importance: Undecided → Medium
Changed in golang-1.14 (Ubuntu Groovy):
importance: Undecided → Medium
Changed in golang-1.14 (Ubuntu Hirsute):
importance: Undecided → Medium
Revision history for this message
Brian Murray (brian-murray) wrote :

The Groovy Gorilla has reached end of life, so this bug will not be fixed for that release

Changed in golang-1.14 (Ubuntu Groovy):
status: New → Won't Fix
Revision history for this message
Brian Murray (brian-murray) wrote :

The Hirsute Hippo has reached End of Life, so this bug will not be fixed for that release.

Changed in golang-1.14 (Ubuntu Hirsute):
status: New → Won't Fix
Changed in golang-1.15 (Ubuntu Hirsute):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.